Maintenence countdown timer #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timer will appear during maintenance calculated by the current client time - Maintenance.EndDateTime from kc server
…rules * use babel to deal with browser js compatibility when build js * lint kc-maintainance to comply with linting rules * ignore file type *.min.js from linting
message shown on the right before maintenance: begins in during maintenance: ends in
- grayscale button - remove #login link - shake effect when hover or click Once maintenance is over, launcher button will return to normal
makemek
added a commit
that referenced
this pull request
Apr 25, 2017
* load kcs_const.js from kc server * basic timer layout * uglify js and reload browser on change * countdown timer during maintenance Timer will appear during maintenance calculated by the current client time - Maintenance.EndDateTime from kc server * setup browser-side javascript to be compatible with modcolle linting rules - use babel to deal with browser js compatibility when build js - lint kc-maintainance to comply with linting rules - ignore file type *.min.js from linting * support countdown before maintenance starts * message notification before and during maintenance message shown on the right before maintenance: begins in during maintenance: ends in * disable launcher button during Kancolle maintenance - grayscale button - remove #login link - shake effect when hover or click Once maintenance is over, launcher button will return to normal * delete unused kc-maintenace.js left over from rebasing
Closed
makemek
added a commit
that referenced
this pull request
Apr 26, 2017
* load kcs_const.js from kc server * basic timer layout * uglify js and reload browser on change * countdown timer during maintenance Timer will appear during maintenance calculated by the current client time - Maintenance.EndDateTime from kc server * setup browser-side javascript to be compatible with modcolle linting rules - use babel to deal with browser js compatibility when build js - lint kc-maintainance to comply with linting rules - ignore file type *.min.js from linting * support countdown before maintenance starts * message notification before and during maintenance message shown on the right before maintenance: begins in during maintenance: ends in * disable launcher button during Kancolle maintenance - grayscale button - remove #login link - shake effect when hover or click Once maintenance is over, launcher button will return to normal * delete unused kc-maintenace.js left over from rebasing
makemek
added a commit
that referenced
this pull request
Apr 26, 2017
Notable Changes: * Maintenance Countdown Timer #16 appear when `Maintenance.IsDoing` in [Kancolle's config](http://203.104.209.7/gadget/js/kcs_const.js) set to `1` and `Maintenance.EndDateTime` is greater than client's machine time. * `kancolle` folder removed #24 Modding content by redirecting url has been suspended. If implement, they will be moved to a dedicated microservice. * Use Node Alpine docker image #25 Smaller image size
makemek
added a commit
that referenced
this pull request
Apr 26, 2017
Notable Changes: * Maintenance Countdown Timer #16 appear when `Maintenance.IsDoing` in [Kancolle's config](http://203.104.209.7/gadget/js/kcs_const.js) set to `1` and `Maintenance.EndDateTime` is greater than client's machine time. * `kancolle` folder removed #24 Modding content by redirecting url has been suspended. If implement, they will be moved to a dedicated microservice. * Use Node Alpine docker image #25 Smaller image size PR-URL: #34
makemek
added a commit
that referenced
this pull request
Apr 26, 2017
* load kcs_const.js from kc server * basic timer layout * uglify js and reload browser on change * countdown timer during maintenance Timer will appear during maintenance calculated by the current client time - Maintenance.EndDateTime from kc server * setup browser-side javascript to be compatible with modcolle linting rules - use babel to deal with browser js compatibility when build js - lint kc-maintainance to comply with linting rules - ignore file type *.min.js from linting * support countdown before maintenance starts * message notification before and during maintenance message shown on the right before maintenance: begins in during maintenance: ends in * disable launcher button during Kancolle maintenance - grayscale button - remove #login link - shake effect when hover or click Once maintenance is over, launcher button will return to normal * delete unused kc-maintenace.js left over from rebasing
makemek
added a commit
that referenced
this pull request
Apr 26, 2017
Notable Changes: * Maintenance Countdown Timer #16 appear when `Maintenance.IsDoing` in [Kancolle's config](http://203.104.209.7/gadget/js/kcs_const.js) set to `1` and `Maintenance.EndDateTime` is greater than client's machine time. * `kancolle` folder removed #24 Modding content by redirecting url has been suspended. If implement, they will be moved to a dedicated microservice. * Use Node Alpine docker image #25 Smaller image size PR-URL: #34
makemek
added a commit
that referenced
this pull request
Apr 26, 2017
* load kcs_const.js from kc server * basic timer layout * uglify js and reload browser on change * countdown timer during maintenance Timer will appear during maintenance calculated by the current client time - Maintenance.EndDateTime from kc server * setup browser-side javascript to be compatible with modcolle linting rules - use babel to deal with browser js compatibility when build js - lint kc-maintainance to comply with linting rules - ignore file type *.min.js from linting * support countdown before maintenance starts * message notification before and during maintenance message shown on the right before maintenance: begins in during maintenance: ends in * disable launcher button during Kancolle maintenance - grayscale button - remove #login link - shake effect when hover or click Once maintenance is over, launcher button will return to normal * delete unused kc-maintenace.js left over from rebasing
makemek
added a commit
that referenced
this pull request
Apr 26, 2017
Notable Changes: * Maintenance Countdown Timer #16 appear when `Maintenance.IsDoing` in [Kancolle's config](http://203.104.209.7/gadget/js/kcs_const.js) set to `1` and `Maintenance.EndDateTime` is greater than client's machine time. * `kancolle` folder removed #24 Modding content by redirecting url has been suspended. If implement, they will be moved to a dedicated microservice. * Use Node Alpine docker image #25 Smaller image size PR-URL: #34
makemek
added a commit
that referenced
this pull request
Apr 26, 2017
Notable Changes: * Maintenance Countdown Timer #16 appear when `Maintenance.IsDoing` in [Kancolle's config](http://203.104.209.7/gadget/js/kcs_const.js) set to `1` and `Maintenance.EndDateTime` is greater than client's machine time. * `kancolle` folder removed #24 Modding content by redirecting url has been suspended. If implement, they will be moved to a dedicated microservice. * Use Node Alpine docker image #25 Smaller image size PR-URL: #34
makemek
added a commit
that referenced
this pull request
Apr 26, 2017
* load kcs_const.js from kc server * basic timer layout * uglify js and reload browser on change * countdown timer during maintenance Timer will appear during maintenance calculated by the current client time - Maintenance.EndDateTime from kc server * setup browser-side javascript to be compatible with modcolle linting rules - use babel to deal with browser js compatibility when build js - lint kc-maintainance to comply with linting rules - ignore file type *.min.js from linting * support countdown before maintenance starts * message notification before and during maintenance message shown on the right before maintenance: begins in during maintenance: ends in * disable launcher button during Kancolle maintenance - grayscale button - remove #login link - shake effect when hover or click Once maintenance is over, launcher button will return to normal * delete unused kc-maintenace.js left over from rebasing
makemek
added a commit
that referenced
this pull request
Apr 26, 2017
Notable Changes: * Maintenance Countdown Timer #16 appear when `Maintenance.IsDoing` in [Kancolle's config](http://203.104.209.7/gadget/js/kcs_const.js) set to `1` and `Maintenance.EndDateTime` is greater than client's machine time. * `kancolle` folder removed #24 Modding content by redirecting url has been suspended. If implement, they will be moved to a dedicated microservice. * Use Node Alpine docker image #25 Smaller image size PR-URL: #34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once Kancolle is in maintenance which is indicated by
Maintenance.IsDoing = 1in http://203.104.209.7/gadget/js/kcs_const.js, Dev team will setMaintenanceInfo.StartDateTimeandMaintenanceInfo.EndDateTime.Modcolle use value of
MaintenanceInfo.EndDateTimeto read date and time and compare with client's time to calculate time remaining.Executing in client-side javascript, the timer will appear at the top of the homepage.
During maintenance the launcher button will be locked, gray-out, and can't access login modal page
#loginto prevent accessing the login page.Although there is no harm in leaving it as it is, user should be notified that there is a maintenance going on.
As countdown is over, the launcher will be enabled back and
#loginis accessible.