use node alpine image #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 80dfba4 on alpine-image into ** on dev**. |
makemek
added a commit
that referenced
this pull request
Apr 25, 2017
* use node:6-apine docker image * run as user
Closed
makemek
added a commit
that referenced
this pull request
Apr 26, 2017
* use node:6-apine docker image * run as user
makemek
added a commit
that referenced
this pull request
Apr 26, 2017
Notable Changes: * Maintenance Countdown Timer #16 appear when `Maintenance.IsDoing` in [Kancolle's config](http://203.104.209.7/gadget/js/kcs_const.js) set to `1` and `Maintenance.EndDateTime` is greater than client's machine time. * `kancolle` folder removed #24 Modding content by redirecting url has been suspended. If implement, they will be moved to a dedicated microservice. * Use Node Alpine docker image #25 Smaller image size
makemek
added a commit
that referenced
this pull request
Apr 26, 2017
Notable Changes: * Maintenance Countdown Timer #16 appear when `Maintenance.IsDoing` in [Kancolle's config](http://203.104.209.7/gadget/js/kcs_const.js) set to `1` and `Maintenance.EndDateTime` is greater than client's machine time. * `kancolle` folder removed #24 Modding content by redirecting url has been suspended. If implement, they will be moved to a dedicated microservice. * Use Node Alpine docker image #25 Smaller image size PR-URL: #34
makemek
added a commit
that referenced
this pull request
Apr 26, 2017
* use node:6-apine docker image * run as user
makemek
added a commit
that referenced
this pull request
Apr 26, 2017
Notable Changes: * Maintenance Countdown Timer #16 appear when `Maintenance.IsDoing` in [Kancolle's config](http://203.104.209.7/gadget/js/kcs_const.js) set to `1` and `Maintenance.EndDateTime` is greater than client's machine time. * `kancolle` folder removed #24 Modding content by redirecting url has been suspended. If implement, they will be moved to a dedicated microservice. * Use Node Alpine docker image #25 Smaller image size PR-URL: #34
makemek
added a commit
that referenced
this pull request
Apr 26, 2017
* use node:6-apine docker image * run as user
makemek
added a commit
that referenced
this pull request
Apr 26, 2017
Notable Changes: * Maintenance Countdown Timer #16 appear when `Maintenance.IsDoing` in [Kancolle's config](http://203.104.209.7/gadget/js/kcs_const.js) set to `1` and `Maintenance.EndDateTime` is greater than client's machine time. * `kancolle` folder removed #24 Modding content by redirecting url has been suspended. If implement, they will be moved to a dedicated microservice. * Use Node Alpine docker image #25 Smaller image size PR-URL: #34
makemek
added a commit
that referenced
this pull request
Apr 26, 2017
Notable Changes: * Maintenance Countdown Timer #16 appear when `Maintenance.IsDoing` in [Kancolle's config](http://203.104.209.7/gadget/js/kcs_const.js) set to `1` and `Maintenance.EndDateTime` is greater than client's machine time. * `kancolle` folder removed #24 Modding content by redirecting url has been suspended. If implement, they will be moved to a dedicated microservice. * Use Node Alpine docker image #25 Smaller image size PR-URL: #34
makemek
added a commit
that referenced
this pull request
Apr 26, 2017
* use node:6-apine docker image * run as user
makemek
added a commit
that referenced
this pull request
Apr 26, 2017
Notable Changes: * Maintenance Countdown Timer #16 appear when `Maintenance.IsDoing` in [Kancolle's config](http://203.104.209.7/gadget/js/kcs_const.js) set to `1` and `Maintenance.EndDateTime` is greater than client's machine time. * `kancolle` folder removed #24 Modding content by redirecting url has been suspended. If implement, they will be moved to a dedicated microservice. * Use Node Alpine docker image #25 Smaller image size PR-URL: #34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reduce image size, node alpine is a lot smaller than node image.
It reduce Modcolle's image size from around 800 MB to 300 MB.