-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.3.1 Release Proposal #34
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* load kcs_const.js from kc server * basic timer layout * uglify js and reload browser on change * countdown timer during maintenance Timer will appear during maintenance calculated by the current client time - Maintenance.EndDateTime from kc server * setup browser-side javascript to be compatible with modcolle linting rules - use babel to deal with browser js compatibility when build js - lint kc-maintainance to comply with linting rules - ignore file type *.min.js from linting * support countdown before maintenance starts * message notification before and during maintenance message shown on the right before maintenance: begins in during maintenance: ends in * disable launcher button during Kancolle maintenance - grayscale button - remove #login link - shake effect when hover or click Once maintenance is over, launcher button will return to normal * delete unused kc-maintenace.js left over from rebasing
* use node:6-apine docker image * run as user
* add instructions on how to start the app * change installation header to docker and manual installation PR-URL: #27
makemek
added a commit
that referenced
this pull request
Apr 26, 2017
Notable Changes: * Maintenance Countdown Timer #16 appear when `Maintenance.IsDoing` in [Kancolle's config](http://203.104.209.7/gadget/js/kcs_const.js) set to `1` and `Maintenance.EndDateTime` is greater than client's machine time. * `kancolle` folder removed #24 Modding content by redirecting url has been suspended. If implement, they will be moved to a dedicated microservice. * Use Node Alpine docker image #25 Smaller image size PR-URL: #34
makemek
added a commit
that referenced
this pull request
Apr 26, 2017
Notable Changes: * Maintenance Countdown Timer #16 appear when `Maintenance.IsDoing` in [Kancolle's config](http://203.104.209.7/gadget/js/kcs_const.js) set to `1` and `Maintenance.EndDateTime` is greater than client's machine time. * `kancolle` folder removed #24 Modding content by redirecting url has been suspended. If implement, they will be moved to a dedicated microservice. * Use Node Alpine docker image #25 Smaller image size PR-URL: #34
makemek
added a commit
that referenced
this pull request
Apr 26, 2017
Notable Changes: * Maintenance Countdown Timer #16 appear when `Maintenance.IsDoing` in [Kancolle's config](http://203.104.209.7/gadget/js/kcs_const.js) set to `1` and `Maintenance.EndDateTime` is greater than client's machine time. * `kancolle` folder removed #24 Modding content by redirecting url has been suspended. If implement, they will be moved to a dedicated microservice. * Use Node Alpine docker image #25 Smaller image size PR-URL: #34
makemek
added a commit
that referenced
this pull request
Apr 26, 2017
Notable Changes: * Maintenance Countdown Timer #16 appear when `Maintenance.IsDoing` in [Kancolle's config](http://203.104.209.7/gadget/js/kcs_const.js) set to `1` and `Maintenance.EndDateTime` is greater than client's machine time. * `kancolle` folder removed #24 Modding content by redirecting url has been suspended. If implement, they will be moved to a dedicated microservice. * Use Node Alpine docker image #25 Smaller image size PR-URL: #34
makemek
added a commit
that referenced
this pull request
Apr 26, 2017
Notable Changes: * Maintenance Countdown Timer #16 appear when `Maintenance.IsDoing` in [Kancolle's config](http://203.104.209.7/gadget/js/kcs_const.js) set to `1` and `Maintenance.EndDateTime` is greater than client's machine time. * `kancolle` folder removed #24 Modding content by redirecting url has been suspended. If implement, they will be moved to a dedicated microservice. * Use Node Alpine docker image #25 Smaller image size PR-URL: #34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2017-04-25, Version 0.3.1 (Current)
Notable Changes
Maintenance Countdown Timer Maintenence countdown timer #16
Appear when
Maintenance.IsDoing
in Kancolle's config set to1
andMaintenance.EndDateTime
is greater than client's machine time.kancolle
folder removed remove unused kancolle folder #24Modding content by redirecting url has been suspended.
If implement, they will be moved to a dedicated microservice.
Use Node Alpine docker image use node alpine image #25
Smaller image size
Commits
Semver Minor
162af3f
] Maintenence countdown timer (Maintenence countdown timer #16)Semver Patch
d232c64
] update readme.mdd200265
] use node alpine image (use node alpine image #25)dd909e9
] remove unused Kancolle folder (remove unused kancolle folder #24)48a2cc6
] fix(package): update url-join to version 2.0.1 (fix(package): update url-join to version 2.0.1 #23)03f48eb
] chore(package): update nock to version 9.0.13 (chore(package): update nock to version 9.0.13 #22)2741f42
] chore(package): update babel-preset-env to version 1.4.0 (Update babel-preset-env to the latest version 🚀 #21)f6e4774
] fix(package): update url-join to version 2.0.0 (Update url-join to the latest version 🚀 #20)556a83a
] eslint: fix single quote error