Attempt to deflake a sytest #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was a bit flaky. The trouble was that there were three things that could triger a deice update notification: * Joining the room * Updating the device keys * Changing display name ... but we only checked for two update notifications, and didn't sanity-check that they were matching up. By adding another poll for update notifications, we can avoid getting out of sync. I also don't think we need the display_name update here. We can also tighten up the final check by making sure that the departed user doesn't appear in *any* syncs between the departure and the undeparted user's update arriving.
babolivier
approved these changes
Feb 21, 2020
anoadragon453
added a commit
that referenced
this pull request
Mar 24, 2020
…ease-v1.12.x * origin/release-v1.12.0: Missing bits Use r0 instead of 'unstable' for joined_members|rooms Add test to optionally keep other sessions when modifying a user's password. (#832) Remove tests that call query_auth endpoint. (#827) Add tests for validating alt_aliases of a canonical alias event. (#824) Update the haproxy config to route fallback auth and register to the same worker. (#828) Add tests for a user with sufficient power level removing an alias. (#818) Add a test for an event with an invalid signature (#821) Fix race in self signing key tests. (#822) Use retry_until_success instead of repeat_until_true. Attempt to deflake a test. Fix frontend proxy worker binding to wrong port. (#823) Stop checking for aliases in the public room list. Attempt to deflake a sytest (#816) Fix formatting from review. Support running Dendrite in more than 1 sqlite db file Add tests for moving alt_aliases to an upgraded room. Support running dendrite in sqlite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was a bit flaky. The trouble was that there were three things that could trigger a device update notification:
... but we only checked for two update notifications, and didn't sanity-check that they were matching up. By adding another poll for update notifications, we can avoid getting out of sync.
I also don't think we need the display_name update here.
We can also tighten up the final check by making sure that the departed user doesn't appear in any syncs between the departure and the undeparted user's update arriving.