-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for a user with sufficient power level removing an alias. #818
Conversation
Oh, hmm...this is probably going to fail on Dendrite. How do we deal with features being added to Synapse before they're ported to Dendrite? |
Looks like the dendrite build passed, so never mind. 👍 |
I'm afraid it's quite confusing. Dendrite is currently marked as 'soft fail', so if it fails it doesn't prevent merging. On github you see a tick, but if you go to [buildkite](https://buildkite.com/matrix-dot-org/sytest/builds/608#b6f655d4-6a92-447e-8ef0-483beee7373e you'll see it did in fact fail. |
For reference: each |
44d1eab
to
edaa8ab
Compare
…ease-v1.12.x * origin/release-v1.12.0: Missing bits Use r0 instead of 'unstable' for joined_members|rooms Add test to optionally keep other sessions when modifying a user's password. (#832) Remove tests that call query_auth endpoint. (#827) Add tests for validating alt_aliases of a canonical alias event. (#824) Update the haproxy config to route fallback auth and register to the same worker. (#828) Add tests for a user with sufficient power level removing an alias. (#818) Add a test for an event with an invalid signature (#821) Fix race in self signing key tests. (#822) Use retry_until_success instead of repeat_until_true. Attempt to deflake a test. Fix frontend proxy worker binding to wrong port. (#823) Stop checking for aliases in the public room list. Attempt to deflake a sytest (#816) Fix formatting from review. Support running Dendrite in more than 1 sqlite db file Add tests for moving alt_aliases to an upgraded room. Support running dendrite in sqlite
SyTests for the behavior in matrix-org/synapse#6986.
A user should be able to delete an alias if they have sufficient power level (enough to modify the canonical alias event). There's already a separate test for a user not being able to delete aliases if they don't have power levels.
I verified that against a develop of master (i.e without matrix-org/synapse#6986) the added test here fails.