Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix frontend proxy worker binding to wrong port. #823

Merged
merged 20 commits into from
Mar 3, 2020

Conversation

erikjohnston
Copy link
Member

No description provided.

@clokep
Copy link
Member

clokep commented Mar 2, 2020

Looks like the builds are passing with this!

@erikjohnston
Copy link
Member Author

Thanks Patrick! I've tidied up some related bits and pieces while we're here


# Start the database
su -c 'eatmydata /usr/lib/postgresql/*/bin/pg_ctl -w -D $PGDATA start' postgres

su -c psql postgres <<< "show config_file"
su -c psql postgres <<< "show max_connections"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized we could grep for the expected values here if we wanted to enforce failure if the configuration isn't as expected. Something like su -c grep 500 $(psgl postgres <<< "show max_connections")...not 100% sure that'll work with the su though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, we could, but I think just printing the values for now is Good Enough. If it breaks again at least we will have some debugging info

@clokep
Copy link
Member

clokep commented Mar 3, 2020

@erikjohnston I think the changes look OK, not 100% sure about the worker_replication_http_port changes, but build still passes. 👍

@erikjohnston
Copy link
Member Author

The worker_replication_http_port changes just brings all worker configs into line.

@erikjohnston erikjohnston merged commit f6db39c into develop Mar 3, 2020
@erikjohnston erikjohnston deleted the erikj/fix_frontend_proxy branch March 3, 2020 13:24
anoadragon453 added a commit that referenced this pull request Mar 24, 2020
…ease-v1.12.x

* origin/release-v1.12.0:
  Missing bits
  Use r0 instead of 'unstable' for joined_members|rooms
  Add test to optionally keep other sessions when modifying a user's password. (#832)
  Remove tests that call query_auth endpoint. (#827)
  Add tests for validating alt_aliases of a canonical alias event. (#824)
  Update the haproxy config to route fallback auth and register to the same worker. (#828)
  Add tests for a user with sufficient power level removing an alias. (#818)
  Add a test for an event with an invalid signature (#821)
  Fix race in self signing key tests. (#822)
  Use retry_until_success instead of repeat_until_true.
  Attempt to deflake a test.
  Fix frontend proxy worker binding to wrong port. (#823)
  Stop checking for aliases in the public room list.
  Attempt to deflake a sytest (#816)
  Fix formatting from review.
  Support running Dendrite in more than 1 sqlite db file
  Add tests for moving alt_aliases to an upgraded room.
  Support running dendrite in sqlite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants