Just posting new pull requests #593
Labels
Difficulty/1:Easy
Easy ticket
Good First Issue
Suitable for first-time contributors
Hacktoberfest
Help Wanted
Community help wanted
Tech/Go
Type/Enhancement
New feature or improvement of existing feature
Up For Grabs
Ready for help from the community. Removed when someone volunteers
Comments
|
This would be huge: being able to specify this would help us declutter our channel and reduce notification spam! |
mickmister
added
Help Wanted
|
@simonv3 That is a reasonable idea and also easy to implement 👍 The ticket is open for the community to pick it up. |
|
I can take this. It should be a simple first ticket. |
hanzei
removed
the
Up For Grabs
C-Deck
pushed a commit
to C-Deck/mattermost-plugin-github
that referenced
this issue
Nov 20, 2022
- Add new_pulls feature flag - Add check for the flag in postPullRequestEvent - Add check for conflicting flags and refactor the conflicting checks to a helper function
hanzei
added
Up For Grabs
hanzei
pushed a commit
that referenced
this issue
Dec 4, 2023
* [GH-593] Add feature flag for new pull requests - Add new_pulls feature flag - Add check for the flag in postPullRequestEvent - Add check for conflicting flags and refactor the conflicting checks to a helper function * Add feature to README * new_pulls -> pulls_new * pulls_new -> pulls_merged * Additional changes after code review in #612 * errMsg -> testFailureMessage * Revert unnecessary changes --------- Co-authored-by: Clint Decker <clint@tendosystems.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a great tool for us and it adds a lot of transparency in our project!
I'm wondering if it's possible, or would be a lot of work to add a feature filter flag for just
new_pulls(rather than both new and merged ones, as the current flag does). We want to show that work is getting done, but also don't want to create too many notifications, and for observers the new pull announcement is more useful than that it was merged. It also allows devs to start a thread about the PR, which has been really useful. But once its merged it's not as relevant for this specific channel.The text was updated successfully, but these errors were encountered: