[GH-593] Add feature flag for new pull requests #612

C-Deck · 2022-11-20T21:15:37Z

Summary

This pull request adds a new_pulls feature flag to the subscriptions command to only create notifications for new pull requests. This feature cannot be added if pulls is included. There is also some minor refactoring of the checks for conflicting features.

Ticket Link

Fixes #593

- Add new_pulls feature flag - Add check for the flag in postPullRequestEvent - Add check for conflicting flags and refactor the conflicting checks to a helper function

mattermod · 2022-11-20T21:15:40Z

Hello @C-Deck,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

codecov-commenter · 2022-11-20T21:24:12Z

Codecov Report

Base: 15.63% // Head: 15.91% // Increases project coverage by +0.27% 🎉

Coverage data is based on head (3721df9) compared to base (9f37670).
Patch coverage: 45.83% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #612      +/-   ##
==========================================
+ Coverage   15.63%   15.91%   +0.27%     
==========================================
  Files          15       15              
  Lines        5243     5259      +16     
==========================================
+ Hits          820      837      +17     
+ Misses       4380     4379       -1     
  Partials       43       43

Impacted Files	Coverage Δ
server/plugin/subscriptions.go	`8.93% <0.00%> (-0.08%)`	⬇️
server/plugin/webhook.go	`0.86% <0.00%> (-0.01%)`	⬇️
server/plugin/command.go	`10.57% <61.11%> (+2.42%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

hanzei

Nice one 👍

One request on the naming

hanzei · 2022-11-22T10:31:21Z

server/plugin/command.go

@@ -17,6 +17,7 @@ const (
 	featureIssues        = "issues"
 	featurePulls         = "pulls"
 	featurePullsMerged   = "pulls_merged"
+	featurePullsCreated  = "new_pulls"


Let's follow the existing pattern and use pulls_new

hanzei · 2022-11-22T10:32:03Z

server/plugin/command.go

+		ok, conflictingFs := checkFeatureConflict(fs)
+		if !ok {
+			if len(conflictingFs) == 2 {
+				return fmt.Sprintf("Feature list cannot contain both %s and %s", conflictingFs[0], conflictingFs[1])
+			}
+			return fmt.Sprintf("Conflicting feature(s) provided: %s", strings.Join(conflictingFs, ","))
 		}


mickmister

Thanks for this great feature @C-Deck! LGTM, just one comment for discussion

server/plugin/command.go

mattermod · 2022-12-24T01:01:42Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

hanzei · 2023-02-20T13:26:54Z

/update-branch

hanzei · 2023-02-20T13:27:22Z

@DHaussermann Gentle reminder to review the PR

hanzei · 2023-02-21T18:38:47Z

/update-branch

DHaussermann · 2023-02-23T06:53:57Z

Hi @C-Deck,
Sorry for the delay in testing this. We're now looking to get another GitHub release out and we'd love to include your feture enhancement.

Functionally, this is working a I would expect 👍

The new feature only delivers the event for a new PR
Merged and Closed PRs deliver no event
No change to exiting pulls
Conflict checking is functional

I see that you did update the read-me. But Can you please also update the 2 in-product areas as well for the /help and the auto-complete suggestion help?

mattermost-build · 2023-03-07T01:01:52Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

DHaussermann

This is blocked based on comment above.

hanzei · 2023-11-09T09:07:59Z

Closing due to inactivity

* [GH-593] Add feature flag for new pull requests - Add new_pulls feature flag - Add check for the flag in postPullRequestEvent - Add check for conflicting flags and refactor the conflicting checks to a helper function * Add feature to README * new_pulls -> pulls_new * pulls_new -> pulls_merged * Additional changes after code review in #612 * errMsg -> testFailureMessage * Revert unnecessary changes --------- Co-authored-by: Clint Decker <clint@tendosystems.com>

Clint Decker added 2 commits November 20, 2022 13:05

[mattermostGH-593] Add feature flag for new pull requests

e1b3701

- Add new_pulls feature flag - Add check for the flag in postPullRequestEvent - Add check for conflicting flags and refactor the conflicting checks to a helper function

Add feature to README

0aed68d

C-Deck requested a review from hanzei as a code owner November 20, 2022 21:15

mattermod added the Contributor label Nov 20, 2022

hanzei requested changes Nov 22, 2022

View reviewed changes

hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Nov 22, 2022

new_pulls -> pulls_new

132d4a3

hanzei approved these changes Nov 29, 2022

View reviewed changes

hanzei requested a review from mickmister November 29, 2022 19:20

mickmister approved these changes Dec 1, 2022

View reviewed changes

server/plugin/command.go Outdated Show resolved Hide resolved

Clint Decker added 2 commits December 12, 2022 20:31

Merge branch 'master' into newpulls

fed67e4

pulls_new -> pulls_merged

e87eb07

hanzei approved these changes Dec 13, 2022

View reviewed changes

hanzei requested a review from DHaussermann December 13, 2022 06:10

hanzei removed the 2: Dev Review Requires review by a core committer label Dec 13, 2022

mattermod added the Lifecycle/1:stale label Dec 24, 2022

Merge branch 'master' into feature/NewPulls

fe5568d

hanzei removed the Lifecycle/1:stale label Feb 20, 2023

hanzei added this to the v2.2.0 milestone Feb 20, 2023

Merge branch 'master' into feature/NewPulls

3721df9

hanzei added the Awaiting Submitter Action Blocked on the author label Feb 24, 2023

mattermost-build added the Lifecycle/1:stale label Mar 7, 2023

hanzei added Lifecycle/2:inactive and removed Lifecycle/1:stale labels Jul 6, 2023

hanzei removed the request for review from DHaussermann October 16, 2023 20:28

DHaussermann requested changes Oct 16, 2023

View reviewed changes

avas27JTG modified the milestones: v2.2.0, v2.3.0 Nov 9, 2023

hanzei added Lifecycle/3:orphaned and removed Awaiting Submitter Action Blocked on the author 3: QA Review Requires review by a QA tester Lifecycle/2:inactive labels Nov 9, 2023

hanzei removed this from the v2.3.0 milestone Nov 9, 2023

hanzei closed this Nov 9, 2023

San4es mentioned this pull request Nov 16, 2023

[GH-593] Add feature flag for new pull requests #712

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GH-593] Add feature flag for new pull requests #612

[GH-593] Add feature flag for new pull requests #612

C-Deck commented Nov 20, 2022

mattermod commented Nov 20, 2022

codecov-commenter commented Nov 20, 2022 •

edited

Loading

hanzei left a comment

hanzei Nov 22, 2022

hanzei Nov 22, 2022

mickmister left a comment

mattermod commented Dec 24, 2022

hanzei commented Feb 20, 2023

hanzei commented Feb 20, 2023

hanzei commented Feb 21, 2023

DHaussermann commented Feb 23, 2023

mattermost-build commented Mar 7, 2023

DHaussermann left a comment

hanzei commented Nov 9, 2023

[GH-593] Add feature flag for new pull requests #612

[GH-593] Add feature flag for new pull requests #612

Conversation

C-Deck commented Nov 20, 2022

Summary

Ticket Link

mattermod commented Nov 20, 2022

codecov-commenter commented Nov 20, 2022 • edited Loading

Codecov Report

hanzei left a comment

Choose a reason for hiding this comment

hanzei Nov 22, 2022

Choose a reason for hiding this comment

hanzei Nov 22, 2022

Choose a reason for hiding this comment

mickmister left a comment

Choose a reason for hiding this comment

mattermod commented Dec 24, 2022

hanzei commented Feb 20, 2023

hanzei commented Feb 20, 2023

hanzei commented Feb 21, 2023

DHaussermann commented Feb 23, 2023

mattermost-build commented Mar 7, 2023

DHaussermann left a comment

Choose a reason for hiding this comment

hanzei commented Nov 9, 2023

codecov-commenter commented Nov 20, 2022 •

edited

Loading