-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GH-593] Add feature flag for new pull requests #712
Conversation
Hello @San4es, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project. Please help complete the Mattermost contribution license agreement? This is a standard procedure for many open source projects. Please let us know if you have any questions. We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team. |
/check-cla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks wrapping up this afford 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @San4es! LGTM, just one non-blocking suggestion to improve the test
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #712 +/- ##
==========================================
+ Coverage 15.49% 15.76% +0.26%
==========================================
Files 15 15
Lines 5737 5755 +18
==========================================
+ Hits 889 907 +18
Misses 4806 4806
Partials 42 42 ☔ View full report in Codecov by Sentry. |
@AayushChaudhary0001 The PR is ready for your review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @San4es!
- Add new_pulls feature flag - Add check for the flag in postPullRequestEvent - Add check for conflicting flags and refactor the conflicting checks to a helper function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and approved, LGTM.
This is recreation of @C-Deck's PR #612 with additional changes addressing these code review comments:
#612 (comment)
Closes #593.