Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt MediaKeySession API to new events structure #13527

Merged
merged 2 commits into from
Mar 7, 2022
Merged

Adapt MediaKeySession API to new events structure #13527

merged 2 commits into from
Mar 7, 2022

Conversation

queengooborg
Copy link
Collaborator

@queengooborg queengooborg commented Mar 5, 2022 •
edited
Loading

This PR adapts the events of the MediaKeySession API to conform to the new events structure.

BCD PRs:
mdn/browser-compat-data#15166
mdn/browser-compat-data#15167

@queengooborg
Adapt api.MediaKeySession.onkeystatuseschange to new events structure
3638e12 
This PR adapts the keystatuseschange event of the MediaKeySession API to conform to the new events structure.
@queengooborg queengooborg requested review from a team as code owners March 5, 2022 17:28
@queengooborg queengooborg requested review from jpmedley and Rumyra and removed request for a team March 5, 2022 17:28
@github-actions github-actions bot added the Content:WebAPI Web API docs label Mar 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2022 •
edited
Loading

Preview URLs

Flaws

URL: /en-US/docs/Web/API/MediaKeySession
Title: MediaKeySession
on GitHub
Flaw count: 2

  • bad_bcd_links:
    • no explanation!
    • no explanation!

URL: /en-US/docs/Web/API/MediaKeySession/keystatuseschange_event
Title: MediaKeySession: keystatuseschange event
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.MediaKeySession.keystatuseschange_event

URL: /en-US/docs/Web/API/MediaKeySession/message_event
Title: MediaKeySession: message event
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.MediaKeySession.message_event

External URLs

URL: /en-US/docs/Web/API/MediaKeySession
Title: MediaKeySession
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MediaKeySession/keystatuseschange_event
Title: MediaKeySession: keystatuseschange event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MediaKeySession/message_event
Title: MediaKeySession: message event
on GitHub

No new external URLs

(this comment was updated 2022-03-05 18:38:03.774856)

@queengooborg queengooborg changed the title Adapt api.MediaKeySession.onkeystatuseschange to new events structure Adapt MediaKeySession API to new events structure Mar 5, 2022
@jpmedley jpmedley merged commit 57bd4b5 into mdn:main Mar 7, 2022
@queengooborg queengooborg deleted the api/MediaKeySession/keystatuseschange branch March 7, 2022 16:13
wbamberg added a commit to wbamberg/content that referenced this pull request Mar 8, 2022
@wbamberg
Merge remote-tracking branch 'upstream/main' into js-la-update-webapi-3
c84fc72 
* upstream/main: (237 commits)
  Fixes anchor to browser compatibility table (mdn#13549)
  Fix incorrect casing of getTitlebarAreaRect (mdn#13631)
  Typo (missing s for plural) (mdn#13609)
  Fix a link (mdn#13621)
  Reduce redirects (mdn#13618)
  Adapt api.Window.onappinstalled to new events structure (mdn#13615)
  Add an example on how to list files from a `FileSystemDirectoryHandle` (mdn#13510)
  Fix a llink in the async Learn module (mdn#13623)
  Undo incorrect fix to justify-items syntax (mdn#13622)
  JS Learn: update client-side APIs, part 2 (mdn#13123)
  JS Learn area: async module rewrite (mdn#12930)
  Fix a link (mdn#13619)
  JS Learn: update client-side APIs, part 1 (mdn#13121)
  Adapt api.SharedWorker.onerror to new events structure (mdn#13599)
  Adapt api.OfflineAudioContext.oncomplete to new events structure (mdn#13568)
  Adapt MediaKeySession API to new events structure (mdn#13527)
  Adapt api.Document.onvisibilitychange to new events structure (mdn#13206)
  Change HTML table to a modern list (AudioProcessingEvent) (mdn#13606)
  Adapt api.Performance.onresourcetimingbufferfull to new events structure (mdn#13603)
  Few changes to outline. (mdn#13414)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmedley jpmedley jpmedley approved these changes

@Rumyra Rumyra Awaiting requested review from Rumyra Rumyra is a code owner automatically assigned from mdn/yari-content-mdn

Assignees
No one assigned
Labels
Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@queengooborg @jpmedley