Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect casing of getTitlebarAreaRect #13631

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Fix incorrect casing of getTitlebarAreaRect #13631

merged 1 commit into from
Mar 8, 2022

Conversation

sideshowbarker
Copy link
Member

Fixes #13624

@sideshowbarker sideshowbarker requested a review from a team as a code owner March 8, 2022 02:14
@sideshowbarker sideshowbarker requested a review from wbamberg March 8, 2022 02:14
@github-actions github-actions bot added the Content:WebAPI Web API docs label Mar 8, 2022
@sideshowbarker sideshowbarker mentioned this pull request Mar 8, 2022
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2022

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/API/WindowControlsOverlay/getTitlebarAreaRect
Title: WindowControlsOverlay.getTitlebarAreaRect()
on GitHub

No new external URLs

wbamberg
wbamberg approved these changes Mar 8, 2022
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

@wbamberg wbamberg merged commit 94ee380 into main Mar 8, 2022
@wbamberg wbamberg deleted the sideshowbarker/getTitlebarAreaRect-fix-casing branch March 8, 2022 02:17
wbamberg added a commit to wbamberg/content that referenced this pull request Mar 8, 2022
@wbamberg
Merge remote-tracking branch 'upstream/main' into js-la-update-webapi-3
c84fc72 
* upstream/main: (237 commits)
  Fixes anchor to browser compatibility table (mdn#13549)
  Fix incorrect casing of getTitlebarAreaRect (mdn#13631)
  Typo (missing s for plural) (mdn#13609)
  Fix a link (mdn#13621)
  Reduce redirects (mdn#13618)
  Adapt api.Window.onappinstalled to new events structure (mdn#13615)
  Add an example on how to list files from a `FileSystemDirectoryHandle` (mdn#13510)
  Fix a llink in the async Learn module (mdn#13623)
  Undo incorrect fix to justify-items syntax (mdn#13622)
  JS Learn: update client-side APIs, part 2 (mdn#13123)
  JS Learn area: async module rewrite (mdn#12930)
  Fix a link (mdn#13619)
  JS Learn: update client-side APIs, part 1 (mdn#13121)
  Adapt api.SharedWorker.onerror to new events structure (mdn#13599)
  Adapt api.OfflineAudioContext.oncomplete to new events structure (mdn#13568)
  Adapt MediaKeySession API to new events structure (mdn#13527)
  Adapt api.Document.onvisibilitychange to new events structure (mdn#13206)
  Change HTML table to a modern list (AudioProcessingEvent) (mdn#13606)
  Adapt api.Performance.onresourcetimingbufferfull to new events structure (mdn#13603)
  Few changes to outline. (mdn#13414)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbamberg wbamberg wbamberg approved these changes

Assignees
No one assigned
Labels
Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with "WindowControlsOverlay.getTitleBarAreaRect()": bar should be lowercase
2 participants
@sideshowbarker @wbamberg