Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt api.Window.onappinstalled to new events structure #13615

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Adapt api.Window.onappinstalled to new events structure #13615

merged 1 commit into from
Mar 7, 2022

Conversation

queengooborg
Copy link
Collaborator

This PR adapts the appinstalled event of the Window API to conform to the new events structure.

BCD PR: mdn/browser-compat-data#15233

@queengooborg
Adapt api.Window.onappinstalled to new events structure
24bfaf6 
This PR adapts the appinstalled event of the Window API to conform to the new events structure.
@queengooborg queengooborg requested review from a team as code owners March 7, 2022 16:34
@queengooborg queengooborg requested review from jpmedley and Rumyra and removed request for a team March 7, 2022 16:34
@github-actions github-actions bot added Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs labels Mar 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2022

Preview URLs

Flaws

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Firefox/Releases/52
Title: Firefox 52 for developers
on GitHub
Flaw count: 14

  • macros:
    • /en-US/docs/Web/HTML/Element/svg does not exist
    • wrong xref macro used (consider changing which macro you use)
  • broken_links:
    • Is currently http:// but can become https://
    • Can't resolve /en-US/docs/Archive/B2G_OS/API/MozVoicemail
    • Can't resolve /en-US/docs/Archive/B2G_OS/API/MozVoicemailEvent
    • Can't resolve /en-US/docs/Archive/B2G_OS/API/MozVoicemailStatus
    • Can't resolve /en-US/docs/Archive/B2G_OS/API/Navigator/mozVoicemail
    • and 7 more flaws omitted

URL: /en-US/docs/Mozilla/Firefox/Releases/49
Title: Firefox 49 for developers
on GitHub
Flaw count: 7

  • macros:
    • /en-US/docs/Web/CSS/align does not exist
    • /en-US/docs/Web/API/ChildNode/before redirects to /en-US/docs/Web/API/Element/before
    • /en-US/docs/Web/API/ChildNode/after redirects to /en-US/docs/Web/API/Element/after
    • /en-US/docs/Web/API/ChildNode/replaceWith redirects to /en-US/docs/Web/API/Element/replaceWith
    • /en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/EventListenerOptions does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Archive/Firefox_OS/API/Data_Store_API
    • Can't resolve /en-US/docs/Mozilla/Projects/Necko/Proxy_Auto-Configuration_(PAC)_file

URL: /en-US/docs/Web/API/Window
Title: Window
on GitHub
Flaw count: 38

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • /en-US/docs/Web/API/Window/DOMMatrix does not exist
    • /en-US/docs/Web/API/Window/DOMMatrixReadOnly does not exist
    • /en-US/docs/Web/API/Window/DOMPoint does not exist
    • /en-US/docs/Web/API/Window/DOMPointReadOnly does not exist
    • and 22 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/The_message_manager
    • Can't resolve /en-US/docs/Mozilla/Tech/XUL/Attribute/onpagehide
    • Can't resolve /en-US/docs/Mozilla/Tech/XUL/Attribute/onpageshow
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 3 more flaws omitted

External URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/52
Title: Firefox 52 for developers
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/49
Title: Firefox 49 for developers
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/76
Title: Firefox 76 for developers
on GitHub

URL: /en-US/docs/Web/API/Window
Title: Window
on GitHub

URL: /en-US/docs/Web/API/Window/appinstalled_event
Title: Window: appinstalled event
on GitHub

No new external URLs

@jpmedley jpmedley merged commit 4649b42 into mdn:main Mar 7, 2022
@queengooborg queengooborg deleted the api/Window/appinstalled branch March 7, 2022 20:34
wbamberg added a commit to wbamberg/content that referenced this pull request Mar 8, 2022
@wbamberg
Merge remote-tracking branch 'upstream/main' into js-la-update-webapi-3
c84fc72 
* upstream/main: (237 commits)
  Fixes anchor to browser compatibility table (mdn#13549)
  Fix incorrect casing of getTitlebarAreaRect (mdn#13631)
  Typo (missing s for plural) (mdn#13609)
  Fix a link (mdn#13621)
  Reduce redirects (mdn#13618)
  Adapt api.Window.onappinstalled to new events structure (mdn#13615)
  Add an example on how to list files from a `FileSystemDirectoryHandle` (mdn#13510)
  Fix a llink in the async Learn module (mdn#13623)
  Undo incorrect fix to justify-items syntax (mdn#13622)
  JS Learn: update client-side APIs, part 2 (mdn#13123)
  JS Learn area: async module rewrite (mdn#12930)
  Fix a link (mdn#13619)
  JS Learn: update client-side APIs, part 1 (mdn#13121)
  Adapt api.SharedWorker.onerror to new events structure (mdn#13599)
  Adapt api.OfflineAudioContext.oncomplete to new events structure (mdn#13568)
  Adapt MediaKeySession API to new events structure (mdn#13527)
  Adapt api.Document.onvisibilitychange to new events structure (mdn#13206)
  Change HTML table to a modern list (AudioProcessingEvent) (mdn#13606)
  Adapt api.Performance.onresourcetimingbufferfull to new events structure (mdn#13603)
  Few changes to outline. (mdn#13414)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmedley jpmedley jpmedley approved these changes

@Rumyra Rumyra Awaiting requested review from Rumyra Rumyra is a code owner automatically assigned from mdn/yari-content-mdn

Assignees
No one assigned
Labels
Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@queengooborg @jpmedley