Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] Work done for 'Using the Web Audio API' article. #1535

Merged
merged 19 commits into from
Jul 18, 2021
Merged

[ko] Work done for 'Using the Web Audio API' article. #1535

merged 19 commits into from
Jul 18, 2021

Conversation

logic-finder
Copy link
Contributor

@logic-finder logic-finder commented Jul 14, 2021

원문: https://developer.mozilla.org/en-US/docs/Web/API/Web_Audio_API/Using_Web_Audio_API
한국어: https://developer.mozilla.org/ko/docs/Web/API/Web_Audio_API/Using_Web_Audio_API

한 단락이 번역되어 있었으나 원문과 비교해보았을 때 번역이 조금 어색한 것 같아서 처음부터 다 번역했습니다.

전체적으로 번역이 많이 미숙합니다.
특히, 아래 부분이 좀 어려웠는데 자세히 봐 주시면 대단히 감사드리겠습니다.
The values of node objects (e.g. GainNode.gain) are not simple values; they are actually objects of type AudioParam — these called parameters. This is why we have to set GainNode.gain's value property, rather than just setting the value on gain directly. This enables them to be much more flexible, allowing for passing the parameter a specific set of values to change between over a set period of time, for example.

@logic-finder logic-finder requested a review from a team as a code owner July 14, 2021 14:47
@logic-finder logic-finder requested review from hochan222 and removed request for a team July 14, 2021 14:47
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Jul 14, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2021

Preview URLs

Flaws

URL: /ko/docs/Web/API/Web_Audio_API/Using_Web_Audio_API
Title: Web Audio API 사용하기
on GitHub
Flaw count: 7

  • macros:
    • /ko/docs/Web/API/BaseAudioContext does not exist but fallbacked on /en-US/docs/Web/API/BaseAudioContext
    • /ko/docs/Web/API/OfflineAudioContext does not exist but fallbacked on /en-US/docs/Web/API/OfflineAudioContext
    • /ko/docs/Web/API/AudioContext/createMediaElementSource does not exist but fallbacked on /en-US/docs/Web/API/AudioContext/createMediaElementSource
    • /ko/docs/Web/API/BaseAudioContext/destination does not exist but fallbacked on /en-US/docs/Web/API/BaseAudioContext/destination
    • /ko/docs/Web/API/GainNode does not exist but fallbacked on /en-US/docs/Web/API/GainNode
    • and 2 more flaws omitted

External URLs

URL: /ko/docs/Web/API/Web_Audio_API/Using_Web_Audio_API
Title: Web Audio API 사용하기
on GitHub

(this comment was updated 2021-07-18 13:49:07.806182)

Copy link
Member

@hochan222 hochan222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@logic-finder 님 안녕하세요. 리뷰 드립니다.

몇가지 번역사항에 대해서 의견을 남겼습니다. 검토하신다음에 괜찮다고 생각하신점들은 반영해주세요!

기여해주셔서 감사합니다. 좋은 하루 보내세요 :)

logic-finder and others added 18 commits July 18, 2021 22:27
Co-authored-by: hochan Lee <hochan049@gmail.com>
Co-authored-by: hochan Lee <hochan049@gmail.com>
Co-authored-by: hochan Lee <hochan049@gmail.com>
Co-authored-by: hochan Lee <hochan049@gmail.com>
Co-authored-by: hochan Lee <hochan049@gmail.com>
Co-authored-by: hochan Lee <hochan049@gmail.com>
Co-authored-by: hochan Lee <hochan049@gmail.com>
Co-authored-by: hochan Lee <hochan049@gmail.com>
translation modified

Co-authored-by: hochan Lee <hochan049@gmail.com>
Co-authored-by: hochan Lee <hochan049@gmail.com>
translation modified

Co-authored-by: hochan Lee <hochan049@gmail.com>
Co-authored-by: hochan Lee <hochan049@gmail.com>
Co-authored-by: hochan Lee <hochan049@gmail.com>
Co-authored-by: hochan Lee <hochan049@gmail.com>
Co-authored-by: hochan Lee <hochan049@gmail.com>
Co-authored-by: hochan Lee <hochan049@gmail.com>
Co-authored-by: hochan Lee <hochan049@gmail.com>
@logic-finder
Copy link
Contributor Author

6315d5f 변경사항)
몇가지 -> 몇 가지
예를들어 -> 예를 들어
노트 -> 참고

Copy link
Member

@hochan222 hochan222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tags 와 slug에 대해서는 해당 댓글에 답변드렸습니다.

고생하셨습니다. 좋은 하루보내세요 :)

@hochan222 hochan222 merged commit 53fb7c6 into mdn:main Jul 18, 2021
@logic-finder logic-finder deleted the ko_using_web_audio_api branch July 18, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants