Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ko] translation modified and additional modification #3133

Merged
merged 2 commits into from
Nov 18, 2021
Merged

[ko] translation modified and additional modification #3133

merged 2 commits into from
Nov 18, 2021

Conversation

logic-finder
Copy link
Contributor

지금까지 번역했던 Web Audio API 문서 중 parameter 번역이 올바르게 되지 않았던 문서들을 수정한 pr입니다.
This is a pr that modifies some documents which have a wrongly translated term for 'parameter' among Web Audio API documents I have translated until now.

● 적절치 못한 맥락에서 사용되었던 'parameter'의 번역 수정 (단, 맥락 상 매개변수가 옳아 보이는 곳에서는 사용을 유지했습니다.)

● 추가적인 수정 (additional modification)

  • Using the Web Audio API: 주석 번역, 기존 번역 조금 수정
  • Web Audio API: 기존 번역 조금 수정 (처음 번역 당시 'falls back' 을 뭐라고 번역해야 할 지 모르겠어서 여쭤본 후 '대안을 제시하는' 을 추천받아 그렇게 번역하였으나 지금 다시 보니 맥락 상 '대비책으로 가지는' 이 적절해 보여 수정하였습니다)
  • AnalyserNode.getByteFrequencyData(): 중복되는 parameter 단락 삭제 (관련 content 레포지토리 pr: Remove a duplicated header content#10615)
  • AnalyserNode.getFloatTimeDomainData(): 중복되는 parameter 단락 삭제 (관련 content 레포지토리 pr: 상동)
  • AudioWorkletNode(): 사용시 참고할 점 → 사용 일람 (변경근거: docs/ko/translation-guide.md)

@logic-finder logic-finder requested a review from a team as a code owner November 18, 2021 07:49
@logic-finder logic-finder requested review from hochan222 and removed request for a team November 18, 2021 07:49
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Nov 18, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2021 •
edited
Loading

Preview URLs

Flaws

URL: /ko/docs/Web/API/AudioParam/value
Title: AudioParam.value
on GitHub
Flaw count: 11

  • macros:
    • /ko/docs/Web/API/AudioParam does not exist but fallbacked on /en-US/docs/Web/API/AudioParam
    • /ko/docs/Web/API/AudioParam does not exist but fallbacked on /en-US/docs/Web/API/AudioParam
    • /ko/docs/Web/API/BaseAudioContext/currentTime does not exist but fallbacked on /en-US/docs/Web/API/BaseAudioContext/currentTime
    • /ko/docs/Web/API/AudioParam/setValueAtTime does not exist but fallbacked on /en-US/docs/Web/API/AudioParam/setValueAtTime
    • /ko/docs/Web/API/AudioParam/minValue does not exist but fallbacked on /en-US/docs/Web/API/AudioParam/minValue
    • and 6 more flaws omitted

URL: /ko/docs/Web/API/AudioParam/setTargetAtTime
Title: AudioParam.setTargetAtTime()
on GitHub
Flaw count: 3

  • macros:
    • /ko/docs/Web/API/AudioParam does not exist but fallbacked on /en-US/docs/Web/API/AudioParam
    • /ko/docs/Web/API/BaseAudioContext/currentTime does not exist but fallbacked on /en-US/docs/Web/API/BaseAudioContext/currentTime
    • /ko/docs/Web/API/AudioParam/exponentialRampToValueAtTime does not exist but fallbacked on /en-US/docs/Web/API/AudioParam/exponentialRampToValueAtTime

URL: /ko/docs/Web/API/AnalyserNode/getFloatTimeDomainData
Title: AnalyserNode.getFloatTimeDomainData()
on GitHub
Flaw count: 2

  • macros:
    • /ko/docs/Web/API/Float32Array does not exist but fallbacked on /en-US/docs/Web/JavaScript/Reference/Global_Objects/Float32Array
    • /ko/docs/Web/API/Float32Array does not exist but fallbacked on /en-US/docs/Web/JavaScript/Reference/Global_Objects/Float32Array

URL: /ko/docs/Web/API/AnalyserNode/getByteFrequencyData
Title: AnalyserNode.getByteFrequencyData()
on GitHub
Flaw count: 2

  • macros:
    • /ko/docs/Web/API/Uint8Array does not exist but fallbacked on /en-US/docs/Web/JavaScript/Reference/Global_Objects/Uint8Array
    • /ko/docs/Web/API/Uint8Array does not exist but fallbacked on /en-US/docs/Web/JavaScript/Reference/Global_Objects/Uint8Array

URL: /ko/docs/Web/API/AudioWorkletProcessor/AudioWorkletProcessor
Title: AudioWorkletProcessor()
on GitHub
Flaw count: 8

  • macros:
    • /ko/docs/Web/API/AudioWorkletProcessor does not exist but fallbacked on /en-US/docs/Web/API/AudioWorkletProcessor
    • /ko/docs/Web/API/AudioNode/numberOfInputs does not exist but fallbacked on /en-US/docs/Web/API/AudioNode/numberOfInputs
    • /ko/docs/Web/API/AudioNode/numberOfOutputs does not exist but fallbacked on /en-US/docs/Web/API/AudioNode/numberOfOutputs
    • /ko/docs/Web/API/AudioParam does not exist but fallbacked on /en-US/docs/Web/API/AudioParam
    • /ko/docs/Web/API/AudioWorkletProcessor does not exist but fallbacked on /en-US/docs/Web/API/AudioWorkletProcessor
    • and 3 more flaws omitted

URL: /ko/docs/Web/API/Web_Audio_API
Title: Web Audio API
on GitHub
Flaw count: 43

  • macros:
    • /ko/docs/Web/API/OscillatorNode does not exist but fallbacked on /en-US/docs/Web/API/OscillatorNode
    • /ko/docs/Web/API/MediaElementAudioSourceNode does not exist but fallbacked on /en-US/docs/Web/API/MediaElementAudioSourceNode
    • /ko/docs/Web/API/MediaStreamAudioSourceNode does not exist but fallbacked on /en-US/docs/Web/API/MediaStreamAudioSourceNode
    • /ko/docs/Web/API/GainNode does not exist but fallbacked on /en-US/docs/Web/API/GainNode
    • /ko/docs/Web/API/AudioContext/destination does not exist but fallbacked on /en-US/docs/Web/API/BaseAudioContext/destination
    • and 38 more flaws omitted

URL: /ko/docs/Web/API/Web_Audio_API/Advanced_techniques
Title: 고급 기법: 오디오 생성 및 시퀸싱
on GitHub
Flaw count: 14

  • macros:
    • /ko/docs/Web/API/OscillatorNode does not exist but fallbacked on /en-US/docs/Web/API/OscillatorNode
    • /ko/docs/Web/API/OscillatorNode does not exist but fallbacked on /en-US/docs/Web/API/OscillatorNode
    • /ko/docs/Web/API/BaseAudioContext/decodeAudioData does not exist but fallbacked on /en-US/docs/Web/API/BaseAudioContext/decodeAudioData
    • /ko/docs/Web/API/OscillatorNode does not exist but fallbacked on /en-US/docs/Web/API/OscillatorNode
    • /ko/docs/Web/API/OscillatorNode does not exist but fallbacked on /en-US/docs/Web/API/OscillatorNode
    • and 7 more flaws omitted
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback

URL: /ko/docs/Web/API/Web_Audio_API/Using_Web_Audio_API
Title: Web Audio API 사용하기
on GitHub
Flaw count: 6

  • macros:
    • /ko/docs/Web/API/AudioContext/createMediaElementSource does not exist but fallbacked on /en-US/docs/Web/API/AudioContext/createMediaElementSource
    • /ko/docs/Web/API/BaseAudioContext/destination does not exist but fallbacked on /en-US/docs/Web/API/BaseAudioContext/destination
    • /ko/docs/Web/API/GainNode does not exist but fallbacked on /en-US/docs/Web/API/GainNode
    • /ko/docs/Web/API/AudioParam does not exist but fallbacked on /en-US/docs/Web/API/AudioParam
    • /ko/docs/Web/API/StereoPannerNode does not exist but fallbacked on /en-US/docs/Web/API/StereoPannerNode
    • and 1 more flaws omitted

URL: /ko/docs/Web/API/Web_Audio_API/Controlling_multiple_parameters_with_ConstantSourceNode
Title: ConstantSourceNode로 다수의 파라미터 제어하기
on GitHub
Flaw count: 34

  • macros:
    • /ko/docs/Web/API/ConstantSourceNode does not exist but fallbacked on /en-US/docs/Web/API/ConstantSourceNode
    • /ko/docs/Web/API/ConstantSourceNode/offset does not exist but fallbacked on /en-US/docs/Web/API/ConstantSourceNode/offset
    • /ko/docs/Web/API/AudioParam does not exist but fallbacked on /en-US/docs/Web/API/AudioParam
    • /ko/docs/Web/API/ConstantSourceNode does not exist but fallbacked on /en-US/docs/Web/API/ConstantSourceNode
    • /ko/docs/Web/API/ConstantSourceNode does not exist but fallbacked on /en-US/docs/Web/API/ConstantSourceNode
    • and 29 more flaws omitted

URL: /ko/docs/Web/API/Web_Audio_API/Migrating_from_webkitAudioContext
Title: webkitAudioContext에서 이주하기
on GitHub
Flaw count: 25

  • macros:
    • /ko/docs/Web/API/CreateGain does not exist
    • /ko/docs/Web/API/CreateDelay does not exist
    • /ko/docs/Web/API/CreateScriptProcessor does not exist
    • /ko/docs/Web/API/OscillatorNode does not exist but fallbacked on /en-US/docs/Web/API/OscillatorNode
    • /ko/docs/Web/API/AudioBufferSourceNode_ does not exist
    • and 20 more flaws omitted

URL: /ko/docs/Web/API/AudioWorkletNode/parameters
Title: AudioWorkletNode.parameters
on GitHub
Flaw count: 11

  • macros:
    • /ko/docs/Web/API/AudioParamMap does not exist but fallbacked on /en-US/docs/Web/API/AudioParamMap
    • /ko/docs/Web/API/AudioParam does not exist but fallbacked on /en-US/docs/Web/API/AudioParam
    • /ko/docs/Web/API/AudioWorkletProcessor does not exist but fallbacked on /en-US/docs/Web/API/AudioWorkletProcessor
    • /ko/docs/Web/API/AudioWorkletProcessor/parameterDescriptors does not exist but fallbacked on /en-US/docs/Web/API/AudioWorkletProcessor/parameterDescriptors
    • /ko/docs/Web/API/AudioWorkletProcessor does not exist but fallbacked on /en-US/docs/Web/API/AudioWorkletProcessor
    • and 6 more flaws omitted

URL: /ko/docs/Web/API/AudioWorkletNode/AudioWorkletNode
Title: AudioWorkletNode()
on GitHub
Flaw count: 11

  • macros:
    • /ko/docs/Web/API/AudioWorkletProcessor does not exist but fallbacked on /en-US/docs/Web/API/AudioWorkletProcessor
    • /ko/docs/Web/API/AudioWorkletGlobalScope/registerProcessor does not exist but fallbacked on /en-US/docs/Web/API/AudioWorkletGlobalScope/registerProcessor
    • /ko/docs/Web/API/AudioWorkletProcessor does not exist but fallbacked on /en-US/docs/Web/API/AudioWorkletProcessor
    • /ko/docs/Web/API/AudioNode/numberOfInputs does not exist but fallbacked on /en-US/docs/Web/API/AudioNode/numberOfInputs
    • /ko/docs/Web/API/AudioNode/numberOfOutputs does not exist but fallbacked on /en-US/docs/Web/API/AudioNode/numberOfOutputs
    • and 6 more flaws omitted

External URLs

URL: /ko/docs/Web/API/AudioParam/value
Title: AudioParam.value
on GitHub

No new external URLs

URL: /ko/docs/Web/API/AudioParam/setTargetAtTime
Title: AudioParam.setTargetAtTime()
on GitHub

No new external URLs

URL: /ko/docs/Web/API/AnalyserNode/getFloatTimeDomainData
Title: AnalyserNode.getFloatTimeDomainData()
on GitHub

URL: /ko/docs/Web/API/AnalyserNode/getByteFrequencyData
Title: AnalyserNode.getByteFrequencyData()
on GitHub

URL: /ko/docs/Web/API/AudioWorkletProcessor/AudioWorkletProcessor
Title: AudioWorkletProcessor()
on GitHub

No new external URLs

URL: /ko/docs/Web/API/Web_Audio_API
Title: Web Audio API
on GitHub

URL: /ko/docs/Web/API/Web_Audio_API/Advanced_techniques
Title: 고급 기법: 오디오 생성 및 시퀸싱
on GitHub

No new external URLs

URL: /ko/docs/Web/API/Web_Audio_API/Using_Web_Audio_API
Title: Web Audio API 사용하기
on GitHub

No new external URLs

URL: /ko/docs/Web/API/Web_Audio_API/Controlling_multiple_parameters_with_ConstantSourceNode
Title: ConstantSourceNode로 다수의 파라미터 제어하기
on GitHub

No new external URLs

URL: /ko/docs/Web/API/Web_Audio_API/Migrating_from_webkitAudioContext
Title: webkitAudioContext에서 이주하기
on GitHub

No new external URLs

URL: /ko/docs/Web/API/AudioWorkletNode/parameters
Title: AudioWorkletNode.parameters
on GitHub

No new external URLs

URL: /ko/docs/Web/API/AudioWorkletNode/AudioWorkletNode
Title: AudioWorkletNode()
on GitHub

No new external URLs

(this comment was updated 2021-11-18 07:55:53.876084)

hochan222
hochan222 approved these changes Nov 18, 2021
View reviewed changes
Copy link
Member

@hochan222 hochan222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

hochan222
hochan222 requested changes Nov 18, 2021
View reviewed changes
Copy link
Member

@hochan222 hochan222 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요. @logic-finder 님 기여해주셔서 감사합니다!

하기 리뷰 내용만 확인해주시면 바로 머지하겠습니다.

좋은 하루 보내세요 :)

files/ko/web/api/analysernode/getbytefrequencydata/index.html
<dt>array</dt>
<dd>주파수 영역 데이터가 복사될 {{domxref("Uint8Array")}}.</dd>
</dl>

Copy link
Member

@hochan222 hochan222 Nov 18, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parameter가 삭제되었는데 원문에는 존재해서 의도하신게 맞는지 궁금합니다.

https://developer.mozilla.org/en-US/docs/web/api/analysernode/getbytefrequencydata

files/ko/web/api/analysernode/getfloattimedomaindata/index.html
<dt>array</dt>
<dd>시간 영역 데이터가 복사될 {{domxref("Float32Array")}}.</dd>
</dl>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(2)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분은 원문에서도 잘못 올라와 있는 것으로 판단되어 content 레포지토리에 수정 pr을 올렸고 머지되었습니다.

@hochan222 hochan222 merged commit 1c9d01e into mdn:main Nov 18, 2021
@hochan222
Copy link
Member

hochan222 commented Nov 18, 2021 •
edited
Loading

위에 목록에 적어주셨었군요! 확인했습니다. 좋은 하루 보내세요 :)

@logic-finder logic-finder deleted the modifications branch December 29, 2021 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hochan222 hochan222 hochan222 approved these changes

Assignees
No one assigned
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@logic-finder @hochan222