Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ko] 가이드라인 추가 #1588

Merged
merged 4 commits into from
Jul 19, 2021
Merged

[ko] 가이드라인 추가 #1588

merged 4 commits into from
Jul 19, 2021

Conversation

hochan222
Copy link
Member

@hochan222 hochan222 commented Jul 18, 2021 •
edited
Loading

관련 이슈

변경 사항

  • JS 관련 용어집
  • 역자주

hochan222 and others added 2 commits July 18, 2021 18:52
@hochan222 @cos18
@pje1740 @yujo11 @alattalatta @gidongkwon @wisedog
docs: add JS word list (#1081)
29fb650 
Co-authored-by: cos18 <codest99@gmail.com>
Co-authored-by: pje1740 <stitch.coding@gmail.com>
Co-authored-by: yujo11 <yujo.dev@gmail.com>
Co-authored-by: alattalatta <urty5656@gmail.com>
Co-authored-by: gidongkwon <lucidfext@gmail.com>
Co-authored-by: wisedog <kim.jongha@gmail.com>
@hochan222 @wisedog @alattalatta
docs: 역자주 번역 가이드 추가 (#1385)
60bb6e5 
Co-authored-by: wisedog <kim.jongha@gmail.com>
Co-authored-by: alattalatta <urty5656@gmail.com>
@hochan222 hochan222 marked this pull request as ready for review July 18, 2021 09:57
@hochan222 hochan222 requested review from a team and Gregoor and removed request for a team and Gregoor July 18, 2021 09:57
@hochan222 hochan222 added the l10n-ko Issues related to Korean content. label Jul 18, 2021
@hochan222
Copy link
Member Author

@alattalatta @wisedog @gidongkwon @yujo11 @pje1740 @cos18

@hochan222
docs: add contact us
98f5b87 
Co-authored-by: logic-finder <>
@github-actions github-actions bot removed the l10n-ko Issues related to Korean content. label Jul 18, 2021
@hochan222 hochan222 added the l10n-ko Issues related to Korean content. label Jul 18, 2021
@github-actions github-actions bot removed the l10n-ko Issues related to Korean content. label Jul 18, 2021
@hochan222 hochan222 added the l10n-ko Issues related to Korean content. label Jul 18, 2021
pje1740
pje1740 approved these changes Jul 19, 2021
View reviewed changes
Copy link
Collaborator

@pje1740 pje1740 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다! 좋은 거 같네요! 정리해주셔서 감사합니다 :)

yujo11
yujo11 approved these changes Jul 19, 2021
View reviewed changes
Copy link
Member

@yujo11 yujo11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인 했습니다!

정리 하느라 고생하셨습니다!! 👍👍👍

docs/ko/translation-guide.md
| Parameter | 매개변수 | | |
| Pending | 대기 | | |
| Prototype | 프로토타입 | | |
| Prerequisites | 필요한 사전 지식 | | |
| Promise | 프로미스 | | [해당 링크 참고](https://github.com/mdn/translated-content/pull/1081#issuecomment-878333558) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

결국 프로미스가 됐군요ㅋㅋㅋㅋ

@hochan222 hochan222 merged commit af76135 into main Jul 19, 2021
@hochan222 hochan222 deleted the ko-guideline branch July 19, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yujo11 yujo11 yujo11 approved these changes

@pje1740 pje1740 pje1740 approved these changes

@cos18 cos18 Awaiting requested review from cos18

Assignees
No one assigned
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hochan222 @pje1740 @yujo11