Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move logic from report templates to report helper and reduce report template code #2887

Closed
de-jcup opened this issue Feb 6, 2024 · 0 comments · Fixed by #2873
Closed

Move logic from report templates to report helper and reduce report template code #2887

de-jcup opened this issue Feb 6, 2024 · 0 comments · Fixed by #2873
Assignees
@de-jcup
Milestone
Server 1.5.0

Comments

@de-jcup
Copy link
Member

de-jcup commented Feb 6, 2024

Situation

Inside the HTML report templates are repetitive parts which contain also much logic inside.
Means difficult to read and also to maintain. Also it is not easy to test.

Wanted

  • Logic shall be testable inside unit tests easily
  • Templates shall become smaller and easier to read and maintain

Solution

Inspect parts inside templates which are very similar and reduce them by
usage of (new introduced) report helper methods
@de-jcup de-jcup self-assigned this Feb 6, 2024
@de-jcup de-jcup mentioned this issue Feb 6, 2024
Merged
15 tasks
de-jcup added a commit that referenced this issue Feb 9, 2024
@de-jcup
Reduce template code by new report helper methods #2887
e9b3bc3
de-jcup added a commit that referenced this issue Feb 9, 2024
@de-jcup
Renamings, template changes and documentation #2887,
e7f49cc 
- documented report model as class plantuml
- renamed some classes to make their meaning clearer
- changed templates: introduced and used more fragements
  to reduce redundant parts - easier for debugging
de-jcup added a commit that referenced this issue Feb 16, 2024
@de-jcup @zigfridus @Jeeppler
Summary in reports, Address typo, multiple refactorings, documentatio…
1a3a3c1 
…n and more (#2873)

- Summary in Reports #345
- Fix Email address typos #2874
- Example domain names now only example.com or example.org #2876
- Build artifact sechub-integrationtest-test-reports name issues resolved #2878
- Fixed report issue #2882
- Moved logic from report templates to java classes #2887
- HTML Report summary data grouped now by severity #2893
- Improved TrafficLight /Severity implemenation/handling #2894
- Moved scan report creation logic to own class #2897
- Changes on new HTML report #2898
- Rename main HTML report template #2903
- Removed web development mode and css file #2902
- Added traffic light anker links to HTML report #2904
- Removed unnecessary report summary meta data from json #2889
- Meta data summary in JSON contains severity totals #2906

---------

Co-authored-by: Valentyn Grygoriev <zigfridus@gmail.com>
Co-authored-by: Jeeppler <Jeeppler@users.noreply.github.com>
@de-jcup de-jcup added this to the Server 1.5.0 milestone Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@de-jcup de-jcup

Labels
None yet
Projects
None yet
Milestone
Server 1.5.0
Development

Successfully merging a pull request may close this issue.

Summary in reports, Address typo, refactorings, example domains mercedes-benz/sechub
1 participant
@de-jcup