Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Summary in reports, Address typo, refactorings, example domains #2873

Merged
merged 109 commits into from
Feb 16, 2024
Merged

Summary in reports, Address typo, refactorings, example domains #2873

merged 109 commits into from
Feb 16, 2024

Conversation

de-jcup
Copy link
Member

@de-jcup de-jcup commented Jan 30, 2024 •
edited
Loading

This PR

zigfridus and others added 30 commits April 10, 2023 14:28
@zigfridus
Add summary table #345
5100a67
@zigfridus
Add possibility to click on results in the summary table #345
1899d25
@zigfridus
The draft summary table in a HTML report #345
d4d1a83
@zigfridus
Merge branch 'mercedes-benz:develop' into feature-345-summary-in-reports
e120a14
@zigfridus
Merge branch 'feature-345-summary-in-reports' of https://github.com/z…
6b4f0a3 
…igfridus/sechub into feature-345-summary-in-reports
@zigfridus
Merge branch 'mercedes-benz:develop' into feature-345-summary-in-reports
8d6f949
@zigfridus
Some improvements and fixes #345:
8c8badd 
- changed model's scanTypeCount List to Set in the HTMLScanResultReportModelBuilder;
- added tests in the HTMLScanResultReportModelBuilderTest;
- cleaned and added improvements in the ScanTypeCount;
- created tests for the ScanTypeCount;
- modified scanresult.html because of new set from the HTMLScanResultReportModelBuilder.
@zigfridus
Added summary section into report #345
3b7d863
@zigfridus
Merge branch 'mercedes-benz:develop' into feature-345-summary-in-reports
8e73dc2
@zigfridus
Added a details section the child of summary section into report #345
70ea329
@zigfridus
Merge branch 'mercedes-benz:develop' into feature-345-summary-in-reports
be03972
@zigfridus
Improvement of html and json reports #345
6446141
@zigfridus
Merge branch 'mercedes-benz:develop' into feature-345-summary-in-reports
15e3bbf
@zigfridus
Minor fixes and improvements #345
0fe8d85
@zigfridus
Enabled github's workflow test #345
d57c6ee
@zigfridus
Merge branch 'mercedes-benz:develop' into feature-345-summary-in-reports
07bf0ee
@zigfridus
Fixed some tests and html templates #345
a039d35
@zigfridus
Merge branch 'mercedes-benz:develop' into feature-345-summary-in-reports
a445501
@zigfridus
Merge branch 'mercedes-benz:develop' into feature-345-summary-in-reports
e22c483
@zigfridus
Merge branch 'mercedes-benz:develop' into feature-345-summary-in-reports
690dbad
@zigfridus
Merge branch 'mercedes-benz:develop' into feature-345-summary-in-reports
4595649
@zigfridus
Modified tests for the new report from #345
3efa782
@zigfridus
Merge branch 'mercedes-benz:develop' into feature-345-summary-in-reports
ee84a7c
@zigfridus
Merge branch 'feature-345-temp' into feature-345-summary-in-reports
9a933f9
@zigfridus
Merge branch 'mercedes-benz:develop' into feature-345-summary-in-reports
3b618b3
@zigfridus
Merge remote-tracking branch 'refs/remotes/origin/feature-345-summary…
228dc45 
…-in-reports' into feature-345-summary-in-reports
@zigfridus
Fixed some tests and html templates #345
983f58d
@zigfridus
Merge branch 'mercedes-benz:develop' into feature-345-summary-in-reports
f5406f8
@zigfridus
Merge remote-tracking branch 'refs/remotes/origin/feature-345-summary…
8883070 
…-in-reports' into feature-345-summary-in-reports
@zigfridus @Jeeppler
Update sechub-commons-model/src/test/java/com/mercedesbenz/sechub/com…
560b6d4 
…mons/model/SecHubReportMetaDataSummaryDetailsTest.java

Co-authored-by: Jeeppler <Jeeppler@users.noreply.github.com>
@de-jcup de-jcup changed the title Summary in reports, Address typo, contributor doc, example domains Summary in reports, Address typo, refactorings, example domains Feb 9, 2024
de-jcup added 19 commits February 9, 2024 18:34
@de-jcup
Refactoring scan report logic to transformer class #2897
c2033ec
@de-jcup
Appplied spotless ...
9f6901b
@de-jcup
comments, some enamings etc.
3ecfb40
@de-jcup
Intoducing dedicated model classes, renaming +refactoring #2898 #2903
d0dc76b
@de-jcup
Removed webdeveloper debug mode #2902
4546130
@de-jcup
Generated HTML contains less empty lines
d56ec06
@de-jcup
Introcue traffic light hyperlinks to top, red, yellow and green #2904
dffc937
@de-jcup
Sort scan type finding data by sechub id
b71256c
@de-jcup
Fixed failing unit tests, added unit tests
682b6b7 
- Changed from "Name" to "Type" in overview - means same
as in findings
- some refactorings
- applied spotless formatter
@de-jcup
Fixed failing integration test
f45790b
@de-jcup
Removed unnecessary scan type meta information #2889
cc17ad9
@de-jcup
Fixed broken integrationtest #2889
ce6c44a
@de-jcup
Renamed getter
a530000
@de-jcup
Improved hasScanType implemenatation on sechub finding
c9d8e08
@de-jcup
Json scan type data now severity based #2906
b62c098
@de-jcup
Minor changes
008f7af 
- fixed typos
- fixed plantuml
- dropped unnecessary code
@de-jcup
Added removed label checks + fixed problem
328a56a
@de-jcup
Drop unused class
10b3bdc
@de-jcup
Minor changes
ac701a6
@de-jcup de-jcup requested a review from winzj February 16, 2024 07:32
@de-jcup de-jcup marked this pull request as ready for review February 16, 2024 07:33
@de-jcup
Minor changes
fde2e5a 
- dropped unnecessary code
- changed Type to Name in hmtl reports
- changed .name to .text for enums
@de-jcup
Minor changes
a3df456
@de-jcup
Minor changes
0a212dc 
- fixed typos
- added unit test
@de-jcup
Spotless applied
e7337ef
winzj
winzj approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@winzj winzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 🚀

@de-jcup de-jcup merged commit 1a3a3c1 into develop Feb 16, 2024
2 checks passed
@de-jcup de-jcup deleted the feature-345-summary-in-reports branch February 16, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winzj winzj winzj approved these changes

Assignees

@de-jcup de-jcup

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@de-jcup @winzj @zigfridus @Jeeppler