Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve TrafficLight /Severity implemenation/handling #2894

Closed
de-jcup opened this issue Feb 9, 2024 · 0 comments · Fixed by #2873
Closed

Improve TrafficLight /Severity implemenation/handling #2894

de-jcup opened this issue Feb 9, 2024 · 0 comments · Fixed by #2873
Assignees
@de-jcup
Milestone
Server 1.5.0

Comments

@de-jcup
Copy link
Member

de-jcup commented Feb 9, 2024 •
edited
Loading

Situation

Currently the TrafficlightCalculator knows which Severity is mapped to a traffic light.

But not the other way.

Wanted

Inside code

  • it shall be possible to get all severities for a traffic light
  • it shall be impossible that one traffic light has a severity crossover with another
  • it shall be impossible that a severity is forgotten
  • only traffic light off has no severity, all other have at least one
  • the traffic light grouping of severities is as before

Solution

We change the implementation - the data (severities) will be hold inside TrafficLight enum and the calculator just uses the information for the calculation.

After the change it is possible to simply get all severities for a trafficlight.
@de-jcup de-jcup self-assigned this Feb 9, 2024
@de-jcup de-jcup mentioned this issue Feb 9, 2024
Merged
15 tasks
de-jcup added a commit that referenced this issue Feb 9, 2024
@de-jcup
Improve traffic light severity handling #2894
8aea08e
de-jcup added a commit that referenced this issue Feb 16, 2024
@de-jcup @zigfridus @Jeeppler
Summary in reports, Address typo, multiple refactorings, documentatio…
1a3a3c1 
…n and more (#2873)

- Summary in Reports #345
- Fix Email address typos #2874
- Example domain names now only example.com or example.org #2876
- Build artifact sechub-integrationtest-test-reports name issues resolved #2878
- Fixed report issue #2882
- Moved logic from report templates to java classes #2887
- HTML Report summary data grouped now by severity #2893
- Improved TrafficLight /Severity implemenation/handling #2894
- Moved scan report creation logic to own class #2897
- Changes on new HTML report #2898
- Rename main HTML report template #2903
- Removed web development mode and css file #2902
- Added traffic light anker links to HTML report #2904
- Removed unnecessary report summary meta data from json #2889
- Meta data summary in JSON contains severity totals #2906

---------

Co-authored-by: Valentyn Grygoriev <zigfridus@gmail.com>
Co-authored-by: Jeeppler <Jeeppler@users.noreply.github.com>
@de-jcup de-jcup added this to the Server 1.5.0 milestone Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@de-jcup de-jcup

Labels
None yet
Projects
None yet
Milestone
Server 1.5.0
Development

Successfully merging a pull request may close this issue.

Summary in reports, Address typo, refactorings, example domains mercedes-benz/sechub
1 participant
@de-jcup