chore: refactor lg page route & url

[zhixzhan]

Description

URL design:

/language-generation/[fileId]/edit?t=[template]#L=[line]
                    \   1   / \ 2 / \    3    / \  4  /

1. lg(dialog) file id, if empty, redirect to /common.
2. edit mark, if exist, go to editor, if not, go to list view.
3. template in current lg file, go to inline editor   
4. go to editor at specify line

URL examples:

• All up list view
  /language-generation/common

• Edit common.lg
  /language-generation/common/edit

• Main.lg list view
  /language-generation/Main

• Edit Main.lg
  /language-generation/Main/edit

• Edit Main.lg on #template-name
  /language-generation/Main/edit?t=template-name

• Edit common.lg#line 25
  /language-generation/common/edit#L=25

• Edit Main.lg#line 5
  /language-generation/Main/edit#L=5

Task Item

Close #1681

Type of change

Please delete options that are not relevant.

• Code refactor (non-breaking change which improve code quality, clean up, add tests, etc)

Checklist

• I have added tests that prove my fix is effective or that my feature works
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have functionally tested my change

Screenshots

Forward & backward inside page:

[boydc2014]

It's good to encode state into URL, so that we can to deep link & jump.

A few suggestions, not sure all valid, just my preferences

1. I prefer more explicit url than "if something not present then default to xx", which means
   • I would like to see common in lg url, if we want to encode fileid in url, no default to common behavior
   • I would prefer to use /language-generation/fileid/view to distinguish from "/edit", no default to view.

Make the url strict at first would help us at this stage when we are not stable enough to design for "shortcuts". We can have a catch all fallback at high-level, but better not have fallback treatment at too many levels.

2. What happened if i both specific t=templateName and #L34?

[zhixzhan]

2. What happened if i both specific t=templateName and #L34?

@boydc2014 according to URL schema, ?search parameters have more weight than #fragment， so it will go to inline template editing page, then this page do not take #L34, then it would be ignored.

[zhixzhan]

It's good to encode state into URL, so that we can to deep link & jump.

A few suggestions, not sure all valid, just my preferences

1. I prefer more explicit url than "if something not present then default to xx", which means

   • I would like to see common in lg url, if we want to encode fileid in url, no default to common behavior

Make sense, now / would redirect to /common

• I would prefer to use /language-generation/fileid/view to distinguish from "/edit", no default to view.

I prefer /fileid as default page rather than /fileid/view, cause / already expressed the meaning of view, it can also be thought as the parent route of /fileid/edit

Make the url strict at first would help us at this stage when we are not stable enough to design for "shortcuts". We can have a catch all fallback at high-level, but better not have fallback treatment at too many levels.

1. What happened if i both specific t=templateName and #L34?

thought again, i think allow ?t=xx and #L both exist also make sense.
e.g
?t=Hello#L3 can explain as open Hello with inline editor, then go to L3 .
if Hello max-line< 3, go to last line.

[a-b-r-o-w-n]

Only real request is to use a fragment that can be parsed using query-string.

[zhixzhan]

Only real request is to use a fragment that can be parsed using query-string.

Updated, now use #L=5 insteadof #L5 for parsing consideration

[boydc2014]

Looks good to me now, #L=5 is a little bit different than GitHub style, but it's OK, it's explicit enough and friendly to parsing.

Anyway, seems that other comments are also resolved, @a-b-r-o-w-n can you confirm again?