Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add React hooks for customization (part 5) #2544

Merged
merged 1 commit into from
Nov 14, 2019
Merged

Add React hooks for customization (part 5) #2544

merged 1 commit into from
Nov 14, 2019

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Nov 3, 2019

Related to #2539.

Please merge #2540, #2541, #2542 and #2543 before reviewing this one.

Changelog Entry

  • Resolves #2539, added React hooks for customization, by @compulim and @corinagum, in the following PRs:
    • PR #2540: useActivities, useReferenceGrammarID, useSendBoxDictationStarted
    • PR #2541: useStyleOptions, useStyleSet
    • PR #2542: useLanguage, useLocalize
    • PR #2543: useAdaptiveCardsHostConfig, useAdaptiveCardsPackage, useRenderMarkdownAsHTML
    • PR #2544: useAvatarForBot, useAvatarForUser
  • Bring your own Adaptive Cards package by specifying adaptiveCardsPackage prop, by @compulim in PR #2543

Description

Add useAvatarForBot and useAvataForUser

Specific Changes

  • Added the following hooks:
    • useAvatarForBot
    • useAvatarForUser
  • Updated components to use aforementioned hooks
  • Testing Added

@compulim compulim force-pushed the feat-redux-hooks-5 branch 6 times, most recently from 384955b to 9fb2bfd Compare November 3, 2019 23:38
This was referenced Nov 4, 2019
Merged
Merged
Merged
@coveralls
Copy link

coveralls commented Nov 4, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 64.052% when pulling c4af18f on compulim:feat-redux-hooks-5 into db2a1bb on microsoft:master.

This was referenced Nov 4, 2019
Merged
Merged
Merged
Merged
Merged
tdurnford
tdurnford approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@tdurnford tdurnford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@compulim compulim merged commit d9c09a4 into microsoft:master Nov 14, 2019
@compulim compulim deleted the feat-redux-hooks-5 branch November 14, 2019 11:17
@corinagum corinagum added the R7 label Dec 3, 2019
@compulim compulim mentioned this pull request Dec 10, 2019
Closed
73 tasks
@corinagum corinagum mentioned this pull request Dec 13, 2019
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdurnford tdurnford tdurnford approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move to Redux Hooks
4 participants
@compulim @coveralls @tdurnford @corinagum