Add React Hooks for customization (part 12) #2553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
requested review from
a-b-r-o-w-n,
corinagum,
cwhitten,
tdurnford and
tonyanziano
as code owners
1 task
compulim
force-pushed
the
feat-redux-hooks-12
branch
4 times, most recently
from
d99b817 to
f64f300
Compare
compulim
force-pushed
the
feat-redux-hooks-12
branch
from
f592ff8 to
63eef63
Compare
compulim
force-pushed
the
feat-redux-hooks-12
branch
from
63eef63 to
aac9c49
Compare
tdurnford
reviewed
Nov 25, 2019
| @@ -50,7 +50,7 @@ const Dictation = ({ emitTypingIndicator, onError }) => { | |||
| if (transcript) { | |||
| setSendBox(transcript); | |||
| submitSendBox('speech'); | |||
| setShouldSpeakIncomingActivity(); | |||
| setShouldSpeakIncomingActivity(true); | |||
There was a problem hiding this comment.
Why is this change necessary?
There was a problem hiding this comment.
It was called startSpeakActivity and stopSpeakActivity. And now shouldSpeakIncomingActivity. We should always call it with true/false.
And I found test failed when I forget to set it to true.
tdurnford
approved these changes
Nov 25, 2019
73 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please merge #2540, #2541, #2542, #2543, #2544, #2547, #2548, #2549, #2550, #2551, #2552 before reviewing this one.
Changelog Entry
useActivities,useReferenceGrammarID,useSendBoxDictationStarteduseStyleOptions,useStyleSetuseLanguage,useLocalize,useLocalizeDateuseAdaptiveCardsHostConfig,useAdaptiveCardsPackage,useRenderMarkdownAsHTMLuseAvatarForBot,useAvatarForUseruseEmitTypingIndicator,usePeformCardAction,usePostActivity,useSendEvent,useSendFiles,useSendMessage,useSendMessageBack,useSendPostBackuseDisableduseSuggestedActionsuseConnectivityStatus,useGroupTimestamp,useTimeoutForSend,useUserID,useUsernameuseLastTypingAt,useSendTypingIndicator,useTypingIndicatoruseFocusSendBox,useScrollToEnd,useSendBoxValue,useSubmitSendBox,useTextBoxSubmit,useTextBoxValueuseDictateInterims,useDictateState,useGrammars,useMarkActivityAsSpoken,useMicrophoneButton,useShouldSpeakIncomingActivity,useStartDictate,useStopDictate,useVoiceSelector,useWebSpeechPonyfillDescription
Add several post message related hooks:
useDictateInterimsuseDictateStateuseGrammarsuseMarkActivityAsSpokenuseMicrophoneButtonuseShouldSpeakIncomingActivityuseStartDictateuseStopDictateuseVoiceSelectoruseWebSpeechPonyfillSpecific Changes
useDictateInterimsuseDictateStateuseGrammarsuseMarkActivityAsSpokenuseMicrophoneButtonuseShouldSpeakIncomingActivityuseStartDictateuseStopDictateuseVoiceSelectoruseWebSpeechPonyfill