This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 144
Plotting heatmap and thumbnails for test PANDA slides #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshita-s
changed the title
Plotting Heatmap and Thumbnails for test PANDA slides
Plotting heatmap and thumbnails for test PANDA slides
Jan 13, 2022
ant0nsc
reviewed
Jan 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
You can simplify setting up the callbacks. Also, I would find it prudent to add a small set of tests to ensure that your plotting really does what you think it does.
InnerEye/ML/configs/histo_configs/classification/DeepSMILECrck.py
Outdated
Show resolved
Hide resolved
InnerEye/ML/configs/histo_configs/classification/DeepSMILEPanda.py
Outdated
Show resolved
Hide resolved
InnerEye/ML/configs/histo_configs/classification/DeepSMILEPanda.py
Outdated
Show resolved
Hide resolved
Reviewed. Major comment: I think we can reduce the number of parameters we pass around by making get_slide_dataset a method implemented in each child class. Agreed with Anton that some tests would help |
ant0nsc
reviewed
Jan 17, 2022
InnerEye/ML/configs/histo_configs/classification/DeepSMILEPanda.py
Outdated
Show resolved
Hide resolved
ant0nsc
previously approved these changes
Jan 17, 2022
InnerEye/ML/configs/histo_configs/classification/DeepSMILEPanda.py
Outdated
Show resolved
Hide resolved
dccastro
reviewed
Jan 18, 2022
dccastro
approved these changes
Jan 18, 2022
ant0nsc
approved these changes
Jan 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
_thumbnail
and_heatmap
suffixes, respectively.