Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression]: Failure to capture console-logs from a third party extension #32762

Closed
shairoth12 opened this issue Sep 23, 2024 · 1 comment · Fixed by #32771
Closed

[Regression]: Failure to capture console-logs from a third party extension #32762

shairoth12 opened this issue Sep 23, 2024 · 1 comment · Fixed by #32771
Assignees
Labels

Comments

@shairoth12
Copy link

Last Good Version

1.46.0

First Bad Version

1.47.0

Steps to reproduce

  1. Clone my repo - git@github.com:shairoth12/repro-playwright-3p-context-regression.git
  2. Run pip install -r requirements.txt && playwright install chromium
  3. Add a breakpoint in Line 42 of in tests/test_extension_console_log.py.
  4. Run the test_extension_console_log in debug mode.
  5. When reaching the breakpoint:
    In the browser's dev-tools, go to the console and see that the log "Test console log from a third-party execution context" appears.
  6. Continue the test run - playwright doesn't catch the aforementioned log and the test fails.

Expected behavior

I expect that playwright will capture the console log "Test console log from a third-party execution context", triggered by the example extension

Actual behavior

The log isn't captured, even though it appear in the dev-tools's console window.

Additional context

I'm not sure whether this regression issue belongs here, since it's a result of this microsoft/playwright commit.
I verified that the test passes with playwright-python 1.47.0 and a manually reverted version of the files changed in the commit above.

Environment

- Operating System: [Ubuntu 22.04]
- CPU: [amd64]
- Browser: [Chromium]
- Python Version: [3.10]
- Other info:
@mxschmitt mxschmitt transferred this issue from microsoft/playwright-python Sep 23, 2024
@yury-s yury-s self-assigned this Sep 23, 2024
@yury-s yury-s added the v1.47 label Sep 23, 2024
@yury-s yury-s closed this as completed in 11320d3 Sep 23, 2024
yury-s added a commit to yury-s/playwright that referenced this issue Sep 23, 2024
…ion contexts (microsoft#32437)

Partially revert microsoft#32437 and add a test that console.log() messages from
content scripts are properly reported

Fixes microsoft#32762
yury-s added a commit that referenced this issue Sep 24, 2024
#32773)

…xts (#32437)

Partially revert #32437 and add a test that console.log() messages from
content scripts are properly reported

Fixes #32762
@shairoth12
Copy link
Author

@yury-s Thank you for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants