Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: ignore third-party execution contexts #32437

Merged
merged 1 commit into from
Sep 4, 2024
Merged

chore: ignore third-party execution contexts #32437

merged 1 commit into from
Sep 4, 2024

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Sep 4, 2024

  • Only track main and utility world contexts
  • Properly update click metadata

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

Test results for "tests 1"

1 failed
❌ [playwright-test] › babel.spec.ts:135:5 › should not transform external

7 flaky ⚠️ [playwright-test] › ui-mode-test-progress.spec.ts:22:5 › should update trace live
⚠️ [playwright-test] › ui-mode-test-setup.spec.ts:98:5 › should show errors in config
⚠️ [chromium-library] › library/trace-viewer.spec.ts:248:1 › should have network requests
⚠️ [playwright-test] › ui-mode-test-source.spec.ts:68:5 › should show top-level errors in file
⚠️ [playwright-test] › ui-mode-test-source.spec.ts:104:5 › should show syntax errors in file
⚠️ [playwright-test] › ui-mode-test-setup.spec.ts:261:5 › should restart webserver on reload
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:184:5 › should watch new file

30132 passed, 865 skipped
✔️✔️✔️

Merge workflow run.

@yury-s yury-s merged commit d7b9cf2 into microsoft:main Sep 4, 2024
29 of 30 checks passed
@yury-s yury-s deleted the chore-exec-cont-name branch September 4, 2024 06:01
yury-s added a commit to yury-s/playwright that referenced this pull request Sep 23, 2024
@yury-s
Revert "chore: ignore third-party execution contexts (microsoft#32437)"
813c01c 
This reverts commit d7b9cf2.
@yury-s yury-s mentioned this pull request Sep 23, 2024
Merged
yury-s added a commit to yury-s/playwright that referenced this pull request Sep 23, 2024
@yury-s
Revert "chore: ignore third-party execution contexts (microsoft#32437)"
3c73bc3 
This reverts commit d7b9cf2.
yury-s added a commit that referenced this pull request Sep 23, 2024
@yury-s
Revert chore: ignore third-party execution contexts (#32437) (#32771)
11320d3 
Partially revert #32437 and add a test that console.log() messages from
content scripts are properly reported

Fixes #32762
yury-s added a commit to yury-s/playwright that referenced this pull request Sep 23, 2024
@yury-s
cherry-pick(microsoft#32771): Revert chore: ignore third-party execut…
6de257d 
…ion contexts (microsoft#32437)

Partially revert microsoft#32437 and add a test that console.log() messages from
content scripts are properly reported

Fixes microsoft#32762
@yury-s yury-s mentioned this pull request Sep 23, 2024
Merged
yury-s added a commit that referenced this pull request Sep 24, 2024
@yury-s
cherry-pick(#32771): Revert chore: ignore third-party execution conte… (
8b3ba3f 
#32773)

…xts (#32437)

Partially revert #32437 and add a test that console.log() messages from
content scripts are properly reported

Fixes #32762
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yury-s @pavelfeldman