Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert chore: ignore third-party execution contexts (#32437) #32771

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Sep 23, 2024

Partially revert #32437 and add a test that console.log() messages from content scripts are properly reported

Fixes #32762

@yury-s yury-s merged commit 11320d3 into microsoft:main Sep 23, 2024
28 of 29 checks passed
@yury-s yury-s deleted the 204-resp-error branch September 23, 2024 22:48
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [webkit-codegen-mode-trace] › library/inspector/cli-codegen-2.spec.ts:408:7 › cli codegen › click should emit events in order

3 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:415:7 › cli codegen › should update selected element after pressing Tab
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:408:7 › cli codegen › click should emit events in order
⚠️ [firefox-codegen-mode-trace] › library/inspector/cli-codegen-2.spec.ts:408:7 › cli codegen › click should emit events in order

36329 passed, 747 skipped
✔️✔️✔️

Merge workflow run.

yury-s added a commit to yury-s/playwright that referenced this pull request Sep 23, 2024
…ion contexts (microsoft#32437)

Partially revert microsoft#32437 and add a test that console.log() messages from
content scripts are properly reported

Fixes microsoft#32762
yury-s added a commit that referenced this pull request Sep 24, 2024
#32773)

…xts (#32437)

Partially revert #32437 and add a test that console.log() messages from
content scripts are properly reported

Fixes #32762
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Regression]: Failure to capture console-logs from a third party extension
2 participants