Horizontal scrolling broken in 0.32.0-rc.0 #561
Comments
|
Confirmed this is also an issue for 0.31.0. |
|
@rigdern, it looks like if you call CalculateLayout() on the horizontal scrolling content, it works okay, but I'm not sure the right infrastructure for that. In the meantime, I'm going to revert 104aa49 and we can work on integrating it in a future release. Probably there is something very simple that we can do to signal to the CSSLayout engine that the width measurement mode should be undefined for horizontal scrolls, thoughts? |
|
@rozele I can take a look at this later today. Just to double check, are you using the same UIExplorer code used in the iOS and Android versions of 0.31.0? After updating the layout engine, Facebook had to make some tweaks to the UIExplorer app to fix bugs due to differences in the layout engine implementation. For example, facebook/react-native#8248 was introduced and was fixed by facebook/react-native@dc5b490. |
|
@rozele What's the latest news on this? I saw that this bug got closed without a corresponding bug being opened for upgrading the layout engine. Should I still look into this or did you figure it out? If I need to look into it, are there instructions somewhere for running the UIExplorer app? Also, I'm still curious to hear an answer to the question in my earlier comment. |
|
I didn't open a new bug yet, but, yes, this still needs to be investigated. I think there's a README in the Examples folder for how to run the UIExplorer (or it may be the main README). Sent from my Windows Phone From: Adam Comellamailto:notifications@github.com @rozele What's the latest news on this? I saw that this bug got closed without a corresponding bug being opened for upgrading the layout engine. Should I still look into this or did you figure it out? If I need to look into it, are there instructions somewhere for running the UIExplorer app? Also, I'm still curious to hear an answer to the question in my earlier comment. You are receiving this because you were mentioned. |
A second attempt at updating the css-layout dependency. This commit includes the changes from these 2 commits: - 104aa49: Update css-layout dependency - 4501096: Clean up warnings due to project.json It also includes a fix for microsoft#561 (horizontal scrolling broken) which was introduced by the previous attempt at upgrading the layout engine. Facebook already found and fixed this bug in their repo so I imported their fix: facebook/react-native@6603cef The updated version of css-layout includes significant changes which make the layout engine conform closer to the W3C spec. For details, see facebook/yoga#185 The inline view implementation had to be modified slightly due to a change in the layout engine. In the updated layout engine, nodes with a measure function are treated as leaves. Consequently, nodes with a mesaure function (e.g. Text) do not have their children laid out automatically. To fix this, Text nodes now manually invoke the layout engine on each of their inline views.
|
I got UIExplorer running, diagnosed, and fixed the isse (PR #565). The reason I was confused about how to run UIExplorer was I didn't see it in my local repo so I assumed it lived somewhere else. GitHub's file search also turned up 0 results for "UIExplorer". I didn't realize there was a git submodule I had to initialize to get UIExplorer. |
A second attempt at updating the css-layout dependency. This commit includes the changes from these 2 commits: - 104aa49: Update css-layout dependency - 4501096: Clean up warnings due to project.json It also includes a fix for microsoft#561 (horizontal scrolling broken) which was introduced by the previous attempt at upgrading the layout engine. Facebook already found and fixed this bug in their repo so I imported their fix: facebook/react-native@6603cef The updated version of css-layout includes significant changes which make the layout engine conform closer to the W3C spec. For details, see facebook/yoga#185 The inline view implementation had to be modified slightly due to a change in the layout engine. In the updated layout engine, nodes with a measure function are treated as leaves. Consequently, nodes with a mesaure function (e.g. Text) do not have their children laid out automatically. To fix this, Text nodes now manually invoke the layout engine on each of their inline views.
A second attempt at updating the css-layout dependency. This commit includes the changes from these 2 commits: - 104aa49: Update css-layout dependency - 4501096: Clean up warnings due to project.json It also includes a fix for #561 (horizontal scrolling broken) which was introduced by the previous attempt at upgrading the layout engine. Facebook already found and fixed this bug in their repo so I imported their fix: facebook/react-native@6603cef The updated version of css-layout includes significant changes which make the layout engine conform closer to the W3C spec. For details, see facebook/yoga#185 The inline view implementation had to be modified slightly due to a change in the layout engine. In the updated layout engine, nodes with a measure function are treated as leaves. Consequently, nodes with a mesaure function (e.g. Text) do not have their children laid out automatically. To fix this, Text nodes now manually invoke the layout engine on each of their inline views.
A second attempt at updating the css-layout dependency. This commit includes the changes from these 2 commits: - 104aa49: Update css-layout dependency - 4501096: Clean up warnings due to project.json It also includes a fix for #561 (horizontal scrolling broken) which was introduced by the previous attempt at upgrading the layout engine. Facebook already found and fixed this bug in their repo so I imported their fix: facebook/react-native@6603cef The updated version of css-layout includes significant changes which make the layout engine conform closer to the W3C spec. For details, see facebook/yoga#185 The inline view implementation had to be modified slightly due to a change in the layout engine. In the updated layout engine, nodes with a measure function are treated as leaves. Consequently, nodes with a mesaure function (e.g. Text) do not have their children laid out automatically. To fix this, Text nodes now manually invoke the layout engine on each of their inline views.
A second attempt at updating the css-layout dependency. This commit includes the changes from these 2 commits: - 104aa49: Update css-layout dependency - 4501096: Clean up warnings due to project.json It also includes a fix for microsoft#561 (horizontal scrolling broken) which was introduced by the previous attempt at upgrading the layout engine. Facebook already found and fixed this bug in their repo so I imported their fix: facebook/react-native@6603cef The updated version of css-layout includes significant changes which make the layout engine conform closer to the W3C spec. For details, see facebook/yoga#185 The inline view implementation had to be modified slightly due to a change in the layout engine. In the updated layout engine, nodes with a measure function are treated as leaves. Consequently, nodes with a mesaure function (e.g. Text) do not have their children laid out automatically. To fix this, Text nodes now manually invoke the layout engine on each of their inline views.
Horizontal scrolling example is broken in UIExplorer.
The text was updated successfully, but these errors were encountered: