Update css-layout dependency #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Run flexbox on the children which are inline views. | ||
| foreach (var child in this.Children) | ||
| { | ||
| if (!(child is ReactRunShadowNode) && !(child is ReactSpanShadowNode)) |
There was a problem hiding this comment.
if (!(child is ReactInlineShadowNode))
|
Other than the minor comments, LGTM. |
A second attempt at updating the css-layout dependency. This commit includes the changes from these 2 commits: - 104aa49: Update css-layout dependency - 4501096: Clean up warnings due to project.json It also includes a fix for microsoft#561 (horizontal scrolling broken) which was introduced by the previous attempt at upgrading the layout engine. Facebook already found and fixed this bug in their repo so I imported their fix: facebook/react-native@6603cef The updated version of css-layout includes significant changes which make the layout engine conform closer to the W3C spec. For details, see facebook/yoga#185 The inline view implementation had to be modified slightly due to a change in the layout engine. In the updated layout engine, nodes with a measure function are treated as leaves. Consequently, nodes with a mesaure function (e.g. Text) do not have their children laid out automatically. To fix this, Text nodes now manually invoke the layout engine on each of their inline views.
rigdern
force-pushed
the
rigdern/updateCssLayout
branch
from
208504f
to
ce98cd1
Compare
rozele
pushed a commit
that referenced
this pull request
Aug 25, 2016
A second attempt at updating the css-layout dependency. This commit includes the changes from these 2 commits: - 104aa49: Update css-layout dependency - 4501096: Clean up warnings due to project.json It also includes a fix for #561 (horizontal scrolling broken) which was introduced by the previous attempt at upgrading the layout engine. Facebook already found and fixed this bug in their repo so I imported their fix: facebook/react-native@6603cef The updated version of css-layout includes significant changes which make the layout engine conform closer to the W3C spec. For details, see facebook/yoga#185 The inline view implementation had to be modified slightly due to a change in the layout engine. In the updated layout engine, nodes with a measure function are treated as leaves. Consequently, nodes with a mesaure function (e.g. Text) do not have their children laid out automatically. To fix this, Text nodes now manually invoke the layout engine on each of their inline views.
GantMan
pushed a commit
to infinitered/react-native-windows
that referenced
this pull request
Sep 29, 2016
A second attempt at updating the css-layout dependency. This commit includes the changes from these 2 commits: - 104aa49: Update css-layout dependency - 4501096: Clean up warnings due to project.json It also includes a fix for microsoft#561 (horizontal scrolling broken) which was introduced by the previous attempt at upgrading the layout engine. Facebook already found and fixed this bug in their repo so I imported their fix: facebook/react-native@6603cef The updated version of css-layout includes significant changes which make the layout engine conform closer to the W3C spec. For details, see facebook/yoga#185 The inline view implementation had to be modified slightly due to a change in the layout engine. In the updated layout engine, nodes with a measure function are treated as leaves. Consequently, nodes with a mesaure function (e.g. Text) do not have their children laid out automatically. To fix this, Text nodes now manually invoke the layout engine on each of their inline views.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
The only new changes are the ones in
ScrollView.windows.jswhich I ported from facebook/react-native@6603cef.Commit Message
A second attempt at updating the css-layout dependency. This commit
includes the changes from these 2 commits:
It also includes a fix for #561 (horizontal scrolling broken) which was
introduced by the previous attempt at upgrading the layout engine.
Facebook already found and fixed this bug in their repo so I imported
their fix: facebook/react-native@6603cef
The updated version of css-layout includes significant
changes which make the layout engine conform closer to
the W3C spec. For details, see facebook/yoga#185
The inline view implementation had to be modified slightly
due to a change in the layout engine. In the updated layout
engine, nodes with a measure function are treated as leaves.
Consequently, nodes with a mesaure function (e.g. Text) do
not have their children laid out automatically.
To fix this, Text nodes now manually invoke the layout engine
on each of their inline views.