Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrl+Shift+Scrollwheel can no longer fully disable transparency when using Acrylic #12880

Closed
kevinmyexp opened this issue Apr 10, 2022 · 4 comments · Fixed by #14193
Closed

Ctrl+Shift+Scrollwheel can no longer fully disable transparency when using Acrylic #12880

kevinmyexp opened this issue Apr 10, 2022 · 4 comments · Fixed by #14193
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@kevinmyexp
Copy link

Windows Terminal version

1.12.10733.0

Windows build number

10.0.22000.593

Other Software

No response

Steps to reproduce

"useAcrylic": true
"opacity": 100 / "acrylicOpacity": 1.0

Expected Behavior

Terminal window with fully opaque, solid color background

Actual Behavior

image

Terminal window still presents minor Acrylic effect,
thus making switch between Acrylic% and Opaque with C+S+Wheel impossible.
@kevinmyexp kevinmyexp added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Apr 10, 2022
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 10, 2022
@tjhowse tjhowse mentioned this issue Apr 13, 2022
Closed
@zadjii-msft zadjii-msft mentioned this issue Sep 14, 2022
Closed
@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Product-Terminal The new Windows Terminal. Priority-3 A description (P3) labels Sep 14, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Sep 14, 2022
@zadjii-msft
Copy link
Member

we discussed this some weeks back but never noted it down: I did this intentionally so people could have fully opaque acrylic. Turns out though, no one really likes that, and wants 100% opacity to always mean "acrylic off". That's fine by me. We just need to revert that bit of logic.

@ofek
Copy link
Contributor

ofek commented Oct 4, 2022

We just need to revert that bit of logic.

Would that be easy enough to include in the next release?

@JerBast JerBast mentioned this issue Oct 12, 2022
Merged
@ghost ghost added the In-PR This issue has a related PR label Oct 12, 2022
@ghost ghost closed this as completed in #14193 Oct 26, 2022
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Oct 26, 2022
ghost pushed a commit that referenced this issue Oct 26, 2022
@JerBast
Disable acrylic material (temporarily) when opacity is set to 100% (#…
8ea3cb9 
…14193)

If the opacity is set to 100%, the background becomes solid instead of 'fully opaque acrylic'. If the opacity is below 100% the acrylic material is re-enabled (depending on the user's settings).

## Validation Steps Performed

I updated two unit tests to reflect the change in behavior and manually tested the transition from <100% opacity to 100% opacity (and vice versa) on win11.

Steps:
1. Start with 100% opacity and acrylic material enabled.
2. Decrease opacity and observe acrylic effect.
3. Increase opacity back to 100% and disable the acrylic effect.
4. Decrease opacity and notice that acrylic effect is no longer there.

Closes #12880
@zadjii-msft zadjii-msft mentioned this issue Nov 4, 2022
Closed
DHowett pushed a commit that referenced this issue Dec 1, 2022
@JerBast @DHowett
Disable acrylic material (temporarily) when opacity is set to 100% (#…
2449f27 
…14193)

If the opacity is set to 100%, the background becomes solid instead of 'fully opaque acrylic'. If the opacity is below 100% the acrylic material is re-enabled (depending on the user's settings).

## Validation Steps Performed

I updated two unit tests to reflect the change in behavior and manually tested the transition from <100% opacity to 100% opacity (and vice versa) on win11.

Steps:
1. Start with 100% opacity and acrylic material enabled.
2. Decrease opacity and observe acrylic effect.
3. Increase opacity back to 100% and disable the acrylic effect.
4. Decrease opacity and notice that acrylic effect is no longer there.

Closes #12880

(cherry picked from commit 8ea3cb9)
Service-Card-Id: 86444093
Service-Version: 1.16
DHowett pushed a commit that referenced this issue Dec 12, 2022
@JerBast @DHowett
Disable acrylic material (temporarily) when opacity is set to 100% (#…
949ea5b 
…14193)

If the opacity is set to 100%, the background becomes solid instead of 'fully opaque acrylic'. If the opacity is below 100% the acrylic material is re-enabled (depending on the user's settings).

## Validation Steps Performed

I updated two unit tests to reflect the change in behavior and manually tested the transition from <100% opacity to 100% opacity (and vice versa) on win11.

Steps:
1. Start with 100% opacity and acrylic material enabled.
2. Decrease opacity and observe acrylic effect.
3. Increase opacity back to 100% and disable the acrylic effect.
4. Decrease opacity and notice that acrylic effect is no longer there.

Closes #12880

(cherry picked from commit 8ea3cb9)
Service-Card-Id: 87207675
Service-Version: 1.15
@ghost
Copy link

ghost commented Dec 14, 2022

🎉This issue was addressed in #14193, which has now been successfully released as Windows Terminal v1.15.3465.0 and v1.15.3466.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Dec 14, 2022

🎉This issue was addressed in #14193, which has now been successfully released as Windows Terminal Preview v1.16.3463.0 and v1.16.3464.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable acrylic material (temporarily) when opacity is set to 100% JerBast/terminal
3 participants
@ofek @kevinmyexp @zadjii-msft