Disable acrylic material (temporarily) when opacity is set to 100% #14193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-TerminalControl
JerBast
changed the title
lhecker
approved these changes
Oct 12, 2022
carlos-zamora
approved these changes
Oct 17, 2022
Extracted from commit message
(Apologies for the poor quality of the gif...) |
carlos-zamora
added
the
AutoMerge
|
Hello @carlos-zamora! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
DHowett
reviewed
Oct 17, 2022
ghost
added
Needs-Author-Feedback
ghost
removed
the
AutoMerge
DHowett
added
the
AutoMerge
ghost
merged commit
DHowett
pushed a commit
that referenced
this pull request
Dec 1, 2022
…14193) If the opacity is set to 100%, the background becomes solid instead of 'fully opaque acrylic'. If the opacity is below 100% the acrylic material is re-enabled (depending on the user's settings). ## Validation Steps Performed I updated two unit tests to reflect the change in behavior and manually tested the transition from <100% opacity to 100% opacity (and vice versa) on win11. Steps: 1. Start with 100% opacity and acrylic material enabled. 2. Decrease opacity and observe acrylic effect. 3. Increase opacity back to 100% and disable the acrylic effect. 4. Decrease opacity and notice that acrylic effect is no longer there. Closes #12880 (cherry picked from commit 8ea3cb9) Service-Card-Id: 86444093 Service-Version: 1.16
DHowett
pushed a commit
that referenced
this pull request
Dec 12, 2022
…14193) If the opacity is set to 100%, the background becomes solid instead of 'fully opaque acrylic'. If the opacity is below 100% the acrylic material is re-enabled (depending on the user's settings). ## Validation Steps Performed I updated two unit tests to reflect the change in behavior and manually tested the transition from <100% opacity to 100% opacity (and vice versa) on win11. Steps: 1. Start with 100% opacity and acrylic material enabled. 2. Decrease opacity and observe acrylic effect. 3. Increase opacity back to 100% and disable the acrylic effect. 4. Decrease opacity and notice that acrylic effect is no longer there. Closes #12880 (cherry picked from commit 8ea3cb9) Service-Card-Id: 87207675 Service-Version: 1.15
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the opacity is set to 100%, the background becomes solid instead of 'fully opaque acrylic'. If the opacity is below 100% the acrylic material is re-enabled (depending on the user's settings).
Validation Steps Performed
I updated two unit tests to reflect the change in behavior and manually tested the transition from <100% opacity to 100% opacity (and vice versa) on win11.
Steps:
Closes #12880