-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Settings UI] Represent Cursor Height as a slider #9386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me!
@msftbot make sure @carlos-zamora signs off on this |
Hello @zadjii-msft! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The UI looks perfect! Nice work! Only thing I'm worried about is changing the min value to be less than 25. So I tagged some team members with more experience there.
Thanks for updating the schema. I bet we specifically mention a minimum of 25 in the docs too. Mind making a PR over there and updating that too (then linking it here)?
Other than that, this is perfect! Thank you so much!
src/renderer/dx/CustomTextRenderer.h
Outdated
constexpr const ULONG MinCursorHeightPercent = 25; | ||
constexpr const ULONG MinCursorHeightPercent = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(oops, the comment didn't save)
Only thing I'm concerned about is some kind of side effect here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I bet we specifically mention a minimum of 25 in the docs too. Mind making a PR over there and updating that too (then linking it here)?
Sure! But I could not found any mention of the minimum cursor height value in docs. Do you mean documentation in the doc
folder or there is a separate repo for that?
The cursor becomes smaller on values less than 25, but if I set the value to less than 6, the cursor disappears.
I probably found why the minimum value was set to 25:
terminal/src/buffer/out/cursor.h
Lines 28 to 30 in ae550e0
// the following values are used to create the textmode cursor. | |
static constexpr unsigned int CURSOR_SMALL_SIZE = 25; // large enough to be one pixel on a six pixel font | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! But I could not found any mention of the minimum cursor height value in docs. Do you mean documentation in the doc folder or there is a separate repo for that?
Ah, yes. My bad. I'm thinking about this section of the docs site, in particular. That's generated by our docs repo here.
The cursor becomes smaller on values less than 25, but if I set the value to less than 6, the cursor disappears.
I probably found why the minimum value was set to 25:
Hmm. That "large enough to be one pixel on a six pixel font" comment seems like a reason keep the minimum size to 25 imo. I think we should revert the changes to the schema and renderer, and change the minimum value on the slider to 25 then.
But I definitely want Michael or Dustin to check on this one to be safe (along with what you found in the GdiEngine
).
Sorry for blocking on such an annoying little thing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed the minimum cursor height value in terminal/src/renderer/gdi/gdirenderer.hpp Lines 153 to 154 in 4c53c59
terminal/src/renderer/gdi/paint.cpp Lines 588 to 590 in 4c53c59
|
@carlos-zamora or @miniksa: This is the one we talked about in team sync today - I'll follow up with the clamp-to-1px thing we mentioned |
Please don't update the GdiEngine for this. Update only the DxEngine one. |
@@ -310,6 +310,8 @@ try | |||
// Enforce min/max cursor height | |||
ULONG ulHeight = std::clamp(options.ulCursorHeightPercent, MinCursorHeightPercent, MaxCursorHeightPercent); | |||
ulHeight = (glyphSize.height<ULONG>() * ulHeight) / 100; | |||
ulHeight = std::max(ulHeight, MinCursorHeightPixels); // No smaller than 1px |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carlos-zamora, @zadjii-msft what if we restrict the minimum cursor height value to 1px? On values less than 25 the cursor is getting smaller until it reaches the 1px height. If one decreases the value further, it won't change anything.
If you think it's ok, I'll also update the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with that. 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
Hello @carlos-zamora! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Documentation update for microsoft/terminal#9386
Sorry for commenting in closed PR, but I don't think it worth creating a new issue.
@miniksa could you please explain a little more about the GdiEngine and why one shouldn't update it along with the DxEngine? I've read the How are the Windows graphics/messaging stack assembled? doc's section (great explanation, by the way!) but still can't find an answer. |
The GdiEngine is the one that's used for drawing the vintage console host (conhost.exe). The DxEngine is only used by the Terminal. He was just asking to make sure that this change was only scoped to the DxEngine, so that the vintage console host didn't change behavior. We can't change the console as easily as we can the Terminal |
Couple things:
|
Thanks! Now it became clear to me 😊 |
🎉 Handy links: |
Documentation update for microsoft/terminal#9386
* command-line-arguments.md: Tag the Command Prompt code blocks For some reason they were tagged as bash, which broke highlighting in at least one of them. * fixed typo (#220) in line 98 it's `C:\\path\\to\\icon.png` while in line 115 it was `C:\\path\\to\\icon` so I've added the missing `.png` * Add note about escaping characters with backslash (#230) Originally filed by Andrewery https://github.com/MicrosoftDocs/terminal/pull/134/files * Add icon example and folder location (#231) From #135 * Add icon example and folder location As originally submitted by @aloneguid in #135 * Remove code brackets for readability * Add spacing * Fix default value by escaping characters (#232) Original submission: https://github.com/MicrosoftDocs/terminal/pull/134/files * Add info about the command palette (#180) * Add info about the command palette 1. Add info about the command palette. 2. Typo fixes (e.g. "quick-start guide" instead of "quickstart") 3. Style fix, e.g. we don't have a keyboard key whose full name is "alt+shift+plus". * revert description Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> * Add backslash escape note (#233) ...from PR #181 * Add a note about hiding dynamic profiles (#186) * Add a note about hiding dynamic profiles * Minor writing updates Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> * Clarify adding profile in ssh tutorial. Fixes #183 (#193) * Clarify adding profile in ssh tutorial. Fixes: #183 * Remove from docs link * Add guid command for powershell (#234) migrated from PR https://github.com/MicrosoftDocs/terminal/pull/199/files * Change "i.e." to "e.g." (#207) This seems to be the intended meaning: There are Linux distributions that are not Ubuntu, but Ubuntu is an example of a Linux distribution for which the behavior is the given. * Old Ubuntu: Use up-to-date version of golang (#216) Currently, the install recommends using an out-of-date version of golang, which in turn causes issues while installing powerline-go. * Add startingDirectory example (#237) * Add startingDirectory example * Format startingDirectory entry * remove icon file type Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * Change icon description to example * Change false to true Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * Remove unnecessary sentence Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * Typo fixes Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * link fix Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * Capitalization fixes Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * shortcut fixes Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * page_title_updates_terminal (#243) * Add docs for `newWindow` action (#259) * refactor(powerline): update for oh-my-posh V3 (#263) * Improved title setting procedure on bash/Ubuntu so that it doesn't destroy `PS1` (#123) Improved title setting procedure on bash/Ubuntu so that it doesn't destroy `PS1` * Update powerline-setup.md (#240) * Update powerline-setup.md * Update powerline-setup.md * Update powerline-setup.md * fix typo * Merge release 1.7 into master (#264) Co-authored-by: Mike Griese <migrie@microsoft.com> Co-authored-by: Don-Vito <khvitaly@gmail.com> * Update powerline-setup.md (#175) * Update powerline-setup.md Updated Tips to include setting the Integrated terminal within Visual Studio to use the Cascadia Code Powerlines font. Also added an additional resource which shows step by step how to do this * Combine VS Code & VS tips for setting up powerline * Remove external blog link Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> * Fix a monor typo with the default keybinding for new tab (#287) closes #270 * Add a note that --window is only available in 1.7+ (#288) * Add a note that --window is only available in 1.7+ closes #282 * Whoops, those can't go on one line * Fix a typo in this doc (#289) * Fix a typo in this doc Closes #280 * I bet the docs build is gonna complain about this one * Add a FAQ entry for folks who are confused when Settings does nothing (#290) * Add a note that you can't set the tab color from the commandline (#291) Closes #249 * Add UUID generator option * Add online guid generator * Add instructions to open defaults.json file * Update panes.md * Add note about using settings.json... ..not defaults.json for applying color schemes across profiles. * fix link * Merge release-1.8 into master (#309) Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> Co-authored-by: Don-Vito <khvitaly@gmail.com> Co-authored-by: Mike Griese <migrie@microsoft.com> * Fix placement of unfocused appearance section (#312) * Update TerminalDocs/command-line-arguments.md * Update TerminalDocs/command-line-arguments.md * Add mouse interaction section (#297) Addresses issue #6 * document how to start windows terminal and have it execute a command (#298) * document how to start windows terminal and have it execute a command #296 * Separated the argument examples and included explanations of what they accomplish * fix typo * remove version from url Co-authored-by: Mark Iannucci <mark.iannucci@dhha.org> Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> * FIX syntax error in json configuration example (#308) FIX syntax error in json configuration example * Document trimBlockSelection setting (#313) * Document trimBlockSelection setting * Add preview disclaimer * Minor edit + note re how to select rectangular txt * Add preview to h2 Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> * Updated openSettings default bindings. (#317) * Updated openSettings default bindings. * Updated the openSettings description. * minor edits Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> * Update powerline-setup.md (#319) Fix a typo 'optonal' replaced by 'optional' * Updates for 1.9 release (#328) * Fix links * Typo "Windows terminal"→"Windows Terminal" (#326) https://docs.microsoft.com/en-us/windows/terminal/custom-terminal-gallery/custom-schemes #PingMSFTDocs * Add link to alternative install options (#321) Resolves #286 * Update `cursorHeight` minimum value (#278) Documentation update for microsoft/terminal#9386 * Add link to install preview (#342) * Add link to install preview * Update wording Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * Update default settings, add UI screenshots (#343) * Update default settings, add UI screenshots * update screenshot * fix numbering * Fix screenshot steps * Correct title verbage, update screenshot * Add preview tags * Fix typos Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> Co-authored-by: Samuel Bronson <naesten@gmail.com> Co-authored-by: LSC <schad.lucas@gmail.com> Co-authored-by: skycommand <jadangerbrooks@hotmail.com> Co-authored-by: Mike Griese <migrie@microsoft.com> Co-authored-by: Cameron Durham <cdurham@usc.edu> Co-authored-by: Søren Fuglede Jørgensen <github@fuglede.dk> Co-authored-by: Janne Mareike Koschinski <janne@kuschku.de> Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> Co-authored-by: Meenal Patel <42360097+v-mepa@users.noreply.github.com> Co-authored-by: Jan De Dobbeleer <2492783+JanDeDobbeleer@users.noreply.github.com> Co-authored-by: Dakkaron <dak1st@gmx.at> Co-authored-by: Ibrahim Rouis <73853380+rouisibra@users.noreply.github.com> Co-authored-by: Don-Vito <khvitaly@gmail.com> Co-authored-by: Michael James <mike@mjjames.co.uk> Co-authored-by: Mark Iannucci <mark.iannucci@gmail.com> Co-authored-by: Mark Iannucci <mark.iannucci@dhha.org> Co-authored-by: lpotherat <l.potherat@planetb.fr> Co-authored-by: Sean Jacobs <Sophismata@users.noreply.github.com> Co-authored-by: superfaz <16510828+superfaz@users.noreply.github.com> Co-authored-by: Hiroshi Yoshioka <40815708+hyoshioka0128@users.noreply.github.com> Co-authored-by: Eugene Samoylov <eugenesmlv@gmail.com>
* command-line-arguments.md: Tag the Command Prompt code blocks For some reason they were tagged as bash, which broke highlighting in at least one of them. * fixed typo (#220) in line 98 it's `C:\\path\\to\\icon.png` while in line 115 it was `C:\\path\\to\\icon` so I've added the missing `.png` * Add note about escaping characters with backslash (#230) Originally filed by Andrewery https://github.com/MicrosoftDocs/terminal/pull/134/files * Add icon example and folder location (#231) From #135 * Add icon example and folder location As originally submitted by @aloneguid in #135 * Remove code brackets for readability * Add spacing * Fix default value by escaping characters (#232) Original submission: https://github.com/MicrosoftDocs/terminal/pull/134/files * Add info about the command palette (#180) * Add info about the command palette 1. Add info about the command palette. 2. Typo fixes (e.g. "quick-start guide" instead of "quickstart") 3. Style fix, e.g. we don't have a keyboard key whose full name is "alt+shift+plus". * revert description Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> * Add backslash escape note (#233) ...from PR #181 * Add a note about hiding dynamic profiles (#186) * Add a note about hiding dynamic profiles * Minor writing updates Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> * Clarify adding profile in ssh tutorial. Fixes #183 (#193) * Clarify adding profile in ssh tutorial. Fixes: #183 * Remove from docs link * Add guid command for powershell (#234) migrated from PR https://github.com/MicrosoftDocs/terminal/pull/199/files * Change "i.e." to "e.g." (#207) This seems to be the intended meaning: There are Linux distributions that are not Ubuntu, but Ubuntu is an example of a Linux distribution for which the behavior is the given. * Old Ubuntu: Use up-to-date version of golang (#216) Currently, the install recommends using an out-of-date version of golang, which in turn causes issues while installing powerline-go. * Add startingDirectory example (#237) * Add startingDirectory example * Format startingDirectory entry * remove icon file type Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * Change icon description to example * Change false to true Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * Remove unnecessary sentence Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * Typo fixes Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * link fix Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * Capitalization fixes Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * shortcut fixes Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * page_title_updates_terminal (#243) * Add docs for `newWindow` action (#259) * refactor(powerline): update for oh-my-posh V3 (#263) * Improved title setting procedure on bash/Ubuntu so that it doesn't destroy `PS1` (#123) Improved title setting procedure on bash/Ubuntu so that it doesn't destroy `PS1` * Update powerline-setup.md (#240) * Update powerline-setup.md * Update powerline-setup.md * Update powerline-setup.md * fix typo * Merge release 1.7 into master (#264) Co-authored-by: Mike Griese <migrie@microsoft.com> Co-authored-by: Don-Vito <khvitaly@gmail.com> * Update powerline-setup.md (#175) * Update powerline-setup.md Updated Tips to include setting the Integrated terminal within Visual Studio to use the Cascadia Code Powerlines font. Also added an additional resource which shows step by step how to do this * Combine VS Code & VS tips for setting up powerline * Remove external blog link Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> * Fix a monor typo with the default keybinding for new tab (#287) closes #270 * Add a note that --window is only available in 1.7+ (#288) * Add a note that --window is only available in 1.7+ closes #282 * Whoops, those can't go on one line * Fix a typo in this doc (#289) * Fix a typo in this doc Closes #280 * I bet the docs build is gonna complain about this one * Add a FAQ entry for folks who are confused when Settings does nothing (#290) * Add a note that you can't set the tab color from the commandline (#291) Closes #249 * Add UUID generator option * Add online guid generator * Add instructions to open defaults.json file * Update panes.md * Add note about using settings.json... ..not defaults.json for applying color schemes across profiles. * fix link * Merge release-1.8 into master (#309) Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> Co-authored-by: Don-Vito <khvitaly@gmail.com> Co-authored-by: Mike Griese <migrie@microsoft.com> * Fix placement of unfocused appearance section (#312) * Update TerminalDocs/command-line-arguments.md * Update TerminalDocs/command-line-arguments.md * Add mouse interaction section (#297) Addresses issue #6 * document how to start windows terminal and have it execute a command (#298) * document how to start windows terminal and have it execute a command #296 * Separated the argument examples and included explanations of what they accomplish * fix typo * remove version from url Co-authored-by: Mark Iannucci <mark.iannucci@dhha.org> Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> * FIX syntax error in json configuration example (#308) FIX syntax error in json configuration example * Document trimBlockSelection setting (#313) * Document trimBlockSelection setting * Add preview disclaimer * Minor edit + note re how to select rectangular txt * Add preview to h2 Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> * Updated openSettings default bindings. (#317) * Updated openSettings default bindings. * Updated the openSettings description. * minor edits Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> * Update powerline-setup.md (#319) Fix a typo 'optonal' replaced by 'optional' * Updates for 1.9 release (#328) * Fix links * Typo "Windows terminal"→"Windows Terminal" (#326) https://docs.microsoft.com/en-us/windows/terminal/custom-terminal-gallery/custom-schemes #PingMSFTDocs * Add link to alternative install options (#321) Resolves #286 * Update `cursorHeight` minimum value (#278) Documentation update for microsoft/terminal#9386 * Add link to install preview (#342) * Add link to install preview * Update wording Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * Update default settings, add UI screenshots (#343) * Update default settings, add UI screenshots * update screenshot * fix numbering * Fix screenshot steps * Correct title verbage, update screenshot * Add preview tags * Fix typos Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * Add required version for OMP2 Oh-my-posh has updated to version 3, so adding a note to designate version 2 on this uninstall until we can return to this tutorial and update to version 3. In the meantime, there are other tutorials available on the web that walkthrough how to install OMP v3 and set it up with git status, etc. * Update quakemode monitor setting Based on #333 * Added link to Cascadia Code font * Add troubleshooting section on git bash flashing (#356) * font struct (#355) Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> * documentation for minimzeToTray (#352) * Add documentation for closing tabs by index (#347) As implemented in microsoft/terminal#10447 * Update configuration section of get-start (#345) Select Settings in the dropdown menu will open the Settings UI instead of open file since the release version v1.6.10571.0 But this page is not up to date, so I edit it. * Add note about opening command palette via dropdown menu (#335) * Make link relative Co-authored-by: Samuel Bronson <naesten@gmail.com> Co-authored-by: LSC <schad.lucas@gmail.com> Co-authored-by: skycommand <jadangerbrooks@hotmail.com> Co-authored-by: Mike Griese <migrie@microsoft.com> Co-authored-by: Cameron Durham <cdurham@usc.edu> Co-authored-by: Søren Fuglede Jørgensen <github@fuglede.dk> Co-authored-by: Janne Mareike Koschinski <janne@kuschku.de> Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> Co-authored-by: Meenal Patel <42360097+v-mepa@users.noreply.github.com> Co-authored-by: Jan De Dobbeleer <2492783+JanDeDobbeleer@users.noreply.github.com> Co-authored-by: Dakkaron <dak1st@gmx.at> Co-authored-by: Ibrahim Rouis <73853380+rouisibra@users.noreply.github.com> Co-authored-by: Don-Vito <khvitaly@gmail.com> Co-authored-by: Michael James <mike@mjjames.co.uk> Co-authored-by: Mark Iannucci <mark.iannucci@gmail.com> Co-authored-by: Mark Iannucci <mark.iannucci@dhha.org> Co-authored-by: lpotherat <l.potherat@planetb.fr> Co-authored-by: Sean Jacobs <Sophismata@users.noreply.github.com> Co-authored-by: superfaz <16510828+superfaz@users.noreply.github.com> Co-authored-by: Hiroshi Yoshioka <40815708+hyoshioka0128@users.noreply.github.com> Co-authored-by: Eugene Samoylov <eugenesmlv@gmail.com> Co-authored-by: PankajBhojwani <pankaj.d.bhoj@gmail.com> Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> Co-authored-by: Leon Liang <lelian@microsoft.com> Co-authored-by: Ian O'Neill <ianjoneill@users.noreply.github.com> Co-authored-by: Gaein_nidb <36162655+nidbCN@users.noreply.github.com> Co-authored-by: Casper Verhaar <casper.verhaar@gmail.com>
* command-line-arguments.md: Tag the Command Prompt code blocks For some reason they were tagged as bash, which broke highlighting in at least one of them. * fixed typo (#220) in line 98 it's `C:\\path\\to\\icon.png` while in line 115 it was `C:\\path\\to\\icon` so I've added the missing `.png` * Add note about escaping characters with backslash (#230) Originally filed by Andrewery https://github.com/MicrosoftDocs/terminal/pull/134/files * Add icon example and folder location (#231) From #135 * Add icon example and folder location As originally submitted by @aloneguid in #135 * Remove code brackets for readability * Add spacing * Fix default value by escaping characters (#232) Original submission: https://github.com/MicrosoftDocs/terminal/pull/134/files * Add info about the command palette (#180) * Add info about the command palette 1. Add info about the command palette. 2. Typo fixes (e.g. "quick-start guide" instead of "quickstart") 3. Style fix, e.g. we don't have a keyboard key whose full name is "alt+shift+plus". * revert description Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> * Add backslash escape note (#233) ...from PR #181 * Add a note about hiding dynamic profiles (#186) * Add a note about hiding dynamic profiles * Minor writing updates Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> * Clarify adding profile in ssh tutorial. Fixes #183 (#193) * Clarify adding profile in ssh tutorial. Fixes: #183 * Remove from docs link * Add guid command for powershell (#234) migrated from PR https://github.com/MicrosoftDocs/terminal/pull/199/files * Change "i.e." to "e.g." (#207) This seems to be the intended meaning: There are Linux distributions that are not Ubuntu, but Ubuntu is an example of a Linux distribution for which the behavior is the given. * Old Ubuntu: Use up-to-date version of golang (#216) Currently, the install recommends using an out-of-date version of golang, which in turn causes issues while installing powerline-go. * Add startingDirectory example (#237) * Add startingDirectory example * Format startingDirectory entry * remove icon file type Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * Change icon description to example * Change false to true Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * Remove unnecessary sentence Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * Typo fixes Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * link fix Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * Capitalization fixes Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * shortcut fixes Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * page_title_updates_terminal (#243) * Add docs for `newWindow` action (#259) * refactor(powerline): update for oh-my-posh V3 (#263) * Improved title setting procedure on bash/Ubuntu so that it doesn't destroy `PS1` (#123) Improved title setting procedure on bash/Ubuntu so that it doesn't destroy `PS1` * Update powerline-setup.md (#240) * Update powerline-setup.md * Update powerline-setup.md * Update powerline-setup.md * fix typo * Merge release 1.7 into master (#264) Co-authored-by: Mike Griese <migrie@microsoft.com> Co-authored-by: Don-Vito <khvitaly@gmail.com> * Update powerline-setup.md (#175) * Update powerline-setup.md Updated Tips to include setting the Integrated terminal within Visual Studio to use the Cascadia Code Powerlines font. Also added an additional resource which shows step by step how to do this * Combine VS Code & VS tips for setting up powerline * Remove external blog link Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> * Fix a monor typo with the default keybinding for new tab (#287) closes #270 * Add a note that --window is only available in 1.7+ (#288) * Add a note that --window is only available in 1.7+ closes #282 * Whoops, those can't go on one line * Fix a typo in this doc (#289) * Fix a typo in this doc Closes #280 * I bet the docs build is gonna complain about this one * Add a FAQ entry for folks who are confused when Settings does nothing (#290) * Add a note that you can't set the tab color from the commandline (#291) Closes #249 * Add UUID generator option * Add online guid generator * Add instructions to open defaults.json file * Update panes.md * Add note about using settings.json... ..not defaults.json for applying color schemes across profiles. * fix link * Merge release-1.8 into master (#309) Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> Co-authored-by: Don-Vito <khvitaly@gmail.com> Co-authored-by: Mike Griese <migrie@microsoft.com> * Fix placement of unfocused appearance section (#312) * Update TerminalDocs/command-line-arguments.md * Update TerminalDocs/command-line-arguments.md * Add mouse interaction section (#297) Addresses issue #6 * document how to start windows terminal and have it execute a command (#298) * document how to start windows terminal and have it execute a command #296 * Separated the argument examples and included explanations of what they accomplish * fix typo * remove version from url Co-authored-by: Mark Iannucci <mark.iannucci@dhha.org> Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> * FIX syntax error in json configuration example (#308) FIX syntax error in json configuration example * Document trimBlockSelection setting (#313) * Document trimBlockSelection setting * Add preview disclaimer * Minor edit + note re how to select rectangular txt * Add preview to h2 Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> * Updated openSettings default bindings. (#317) * Updated openSettings default bindings. * Updated the openSettings description. * minor edits Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> * Update powerline-setup.md (#319) Fix a typo 'optonal' replaced by 'optional' * Updates for 1.9 release (#328) * Fix links * Typo "Windows terminal"→"Windows Terminal" (#326) https://docs.microsoft.com/en-us/windows/terminal/custom-terminal-gallery/custom-schemes #PingMSFTDocs * Add link to alternative install options (#321) Resolves #286 * Update `cursorHeight` minimum value (#278) Documentation update for microsoft/terminal#9386 * Add link to install preview (#342) * Add link to install preview * Update wording Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * Update default settings, add UI screenshots (#343) * Update default settings, add UI screenshots * update screenshot * fix numbering * Fix screenshot steps * Correct title verbage, update screenshot * Add preview tags * Fix typos Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * Add required version for OMP2 Oh-my-posh has updated to version 3, so adding a note to designate version 2 on this uninstall until we can return to this tutorial and update to version 3. In the meantime, there are other tutorials available on the web that walkthrough how to install OMP v3 and set it up with git status, etc. * Update quakemode monitor setting Based on #333 * Added link to Cascadia Code font * Add troubleshooting section on git bash flashing (#356) * font struct (#355) Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> * documentation for minimzeToTray (#352) * Add documentation for closing tabs by index (#347) As implemented in microsoft/terminal#10447 * Update configuration section of get-start (#345) Select Settings in the dropdown menu will open the Settings UI instead of open file since the release version v1.6.10571.0 But this page is not up to date, so I edit it. * Add note about opening command palette via dropdown menu (#335) * Make link relative * Add updates for 1.10 release (#361) * Add reset settings to troubleshooting section Resolves #91 * Add 3rd party examples to dynamic profiles (#366) * Add experimental.input.forceVT setting to the interaction page (#367) * Add input.forceVT setting * Update wording * Replace screenshot with overview video * Add note about json vs UI settings for WSL starting directory Resolves #373 Co-authored-by: Samuel Bronson <naesten@gmail.com> Co-authored-by: LSC <schad.lucas@gmail.com> Co-authored-by: skycommand <jadangerbrooks@hotmail.com> Co-authored-by: Mike Griese <migrie@microsoft.com> Co-authored-by: Cameron Durham <cdurham@usc.edu> Co-authored-by: Søren Fuglede Jørgensen <github@fuglede.dk> Co-authored-by: Janne Mareike Koschinski <janne@kuschku.de> Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> Co-authored-by: Meenal Patel <42360097+v-mepa@users.noreply.github.com> Co-authored-by: Jan De Dobbeleer <2492783+JanDeDobbeleer@users.noreply.github.com> Co-authored-by: Dakkaron <dak1st@gmx.at> Co-authored-by: Ibrahim Rouis <73853380+rouisibra@users.noreply.github.com> Co-authored-by: Don-Vito <khvitaly@gmail.com> Co-authored-by: Michael James <mike@mjjames.co.uk> Co-authored-by: Mark Iannucci <mark.iannucci@gmail.com> Co-authored-by: Mark Iannucci <mark.iannucci@dhha.org> Co-authored-by: lpotherat <l.potherat@planetb.fr> Co-authored-by: Sean Jacobs <Sophismata@users.noreply.github.com> Co-authored-by: superfaz <16510828+superfaz@users.noreply.github.com> Co-authored-by: Hiroshi Yoshioka <40815708+hyoshioka0128@users.noreply.github.com> Co-authored-by: Eugene Samoylov <eugenesmlv@gmail.com> Co-authored-by: PankajBhojwani <pankaj.d.bhoj@gmail.com> Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> Co-authored-by: Leon Liang <lelian@microsoft.com> Co-authored-by: Ian O'Neill <ianjoneill@users.noreply.github.com> Co-authored-by: Gaein_nidb <36162655+nidbCN@users.noreply.github.com> Co-authored-by: Casper Verhaar <casper.verhaar@gmail.com>
Change the vintage cursor height number box to a slider.
References
Related: #9370
PR Checklist
cursorHeight
minimum value MicrosoftDocs/terminal#278Detailed Description of the Pull Request / Additional comments
It seems like the cursor height couldn't be lower than 25 percent regardless of the given value, so I've changed the
MinCursorHeightPercent
in CustomTextRenderer header file.Validation Steps Performed
Manual validation