Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update debug icon for action bar #101824

Closed
wants to merge 9 commits into from
Closed

Conversation

miguelsolorio
Copy link
Contributor

For #101026, this makes it so that we create a single debug icon for the action bar without having to change it in the future. Since this is pulling in a commit from master there is an additional icon being added which is part of the icon font (there should be no harm having it added).

You should be able to use debug-alt-small next to play now:

image

Miguel Solorio and others added 9 commits July 3, 2020 08:37
Ignore less cached data when more is available
As the same instance of the object widget could be used for different
settings, it is necessary to make sure to reset the model state (edit
key and selection index) when an instance is reused.
@miguelsolorio miguelsolorio added candidate Issue identified as probable candidate for fixing in the next release icons-product Issues for in-product icons labels Jul 6, 2020
@miguelsolorio miguelsolorio added this to the June 2020 milestone Jul 6, 2020
@miguelsolorio miguelsolorio requested a review from weinand July 6, 2020 23:36
@miguelsolorio
Copy link
Contributor Author

miguelsolorio commented Jul 6, 2020

Hit create too fast, this needs to go against the release branch.

@miguelsolorio miguelsolorio deleted the misolori/debug-icon branch July 7, 2020 15:58
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
candidate Issue identified as probable candidate for fixing in the next release icons-product Issues for in-product icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants