-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1932322 - Implement the new collection-enabled
API
#3006
base: main
Are you sure you want to change the base?
Conversation
92c1809
to
bcff07a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lot's of little cleanup things, nothing major. I'd say this fits really well with my mental model of what this would look like from our discussions.
glean-core/android/src/test/java/mozilla/telemetry/glean/private/EventMetricTypeTest.kt
Outdated
Show resolved
Hide resolved
Also, docs/changelog/etc. ofc |
79cc41c
to
d843f3e
Compare
This effectively deprecates `set_upload_enabled`.
d843f3e
to
a85c48b
Compare
No data is recorded for unknown or disabled pings.
a85c48b
to
e2a05ff
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3006 +/- ##
=======================================
Coverage 29.54% 29.54%
=======================================
Files 1 1
Lines 44 44
=======================================
Hits 13 13
Misses 31 31 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
This is the mega PR changing the inner workings of Glean to support
collection-enabled
andfollows-collection-enabled
on pings, to independently control a subset of pings and whether they can get submitted.BREAKING CHANGE: This is definitely a huge breaking change.
2024-11-21: This is not yet fully ready for review
follows_collection_enabled
for pings glean_parser#776 (and release and update glean-parser)