Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow JMPR op only if outside of FDEF and IF #4446

Merged
merged 1 commit into from
Mar 13, 2014
Merged

Follow JMPR op only if outside of FDEF and IF #4446

merged 1 commit into from
Mar 13, 2014

Conversation

benbro
Copy link
Contributor

@benbro benbro commented Mar 13, 2014

JMPR usually comes after a push op.
Push ops only change the stack if outside of FDEF and IF so JMPR need to do the same.

This PR fixes the following issues:
#4002
#4091
#4411
#3482
#3851
#4280
#4115 (not sure, don't speak Russian)
https://bugzilla.mozilla.org/show_bug.cgi?id=926462
https://bugzilla.mozilla.org/show_bug.cgi?id=982861

@Snuffleupagus
Copy link
Collaborator

Impressive! This also fixes: https://bugzilla.mozilla.org/show_bug.cgi?id=982861.

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/8a589344d75390b/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/040f9addd48dea7/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/8a589344d75390b/output.txt

Total script time: 26.16 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/040f9addd48dea7/output.txt

Total script time: 36.69 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/040f9addd48dea7/reftest-analyzer.html#web=eq.log

yurydelendik added a commit that referenced this pull request Mar 13, 2014
Follow JMPR op only if outside of FDEF and IF
@yurydelendik yurydelendik merged commit 1cd52ca into mozilla:master Mar 13, 2014
@yurydelendik
Copy link
Contributor

Thank you for the patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants