-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Improve Base component demos #30884
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks!
I see I need to add focus-visible support for the listbox. Will do it in a separate PR. |
I had |
👋 The migration PR has been merged. Please follow these steps to make sure that the contents are all updated. (Sorry for the inconvenience)
If you are struggle with the steps above, feel free to tag @siriwatknp |
@michaldudak Not sure where to leave this feedback. Unstyled select regressed on #8191. @danilo-leal I don't think that we will ever need the outline here: the active item already show where the keyboard focus is. I'm confused when I interact with this demo. |
Yes, I'm aware of that. I haven't implemented this bit yet and I stated it in the description of #30113. |
FYI: By removing the |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks much better than before, thanks!
Mostly focused on the Select with a few light touches on the Input and Switch.
Closes #30806.
Deploy previews: