Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Improve Base component demos #30884

Merged
merged 23 commits into from
Feb 10, 2022
Merged

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Feb 2, 2022

@danilo-leal danilo-leal added the docs Improvements or additions to the documentation label Feb 2, 2022
@mui-bot
Copy link

mui-bot commented Feb 2, 2022

No bundle size changes

Generated by 🚫 dangerJS against 132a538

Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@mnajdova
Copy link
Member

mnajdova commented Feb 3, 2022

Can we improve the focus on the listbox? It looks cut of

image

@michaldudak
Copy link
Member

I see I need to add focus-visible support for the listbox. Will do it in a separate PR.

@danilo-leal
Copy link
Contributor Author

danilo-leal commented Feb 3, 2022

Can we improve the focus on the listbox? It looks cut of

I had &.${selectUnstyledClasses.focusVisible} going for the list box but as @michaldudak said, I guess it didn't support it. In the meanwhile, swapped to a plain &:focus so it works someway. Whenever we get to implement, we can switch back to that class.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 4, 2022
@siriwatknp
Copy link
Member

👋 The migration PR has been merged.

Please follow these steps to make sure that the contents are all updated. (Sorry for the inconvenience)

  1. pull latest master from upstream to your branch
  2. if your PR has changes on the *.md or demo files, you are likely to encounter conflict because all of them have been moved to the new folder.
    2.1 revert the change on those markdown files you did
    2.2 pull latest master from upstream (you should not see conflict)
    2.3 make the changes again at docs/data/material/*
  3. run yarn docs:api
    • you might see the changes in docs/pages/material/api/* if your PR touches some of the components
    • it is okay if there is no changes

If you are struggle with the steps above, feel free to tag @siriwatknp

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 4, 2022
@oliviertassinari
Copy link
Member

oliviertassinari commented Feb 7, 2022

@michaldudak Not sure where to leave this feedback. Unstyled select regressed on #8191.

@danilo-leal I don't think that we will ever need the outline here:

Screenshot 2022-02-07 at 01 41 45

the active item already show where the keyboard focus is. I'm confused when I interact with this demo.

@michaldudak
Copy link
Member

@michaldudak Not sure where to leave this feedback. Unstyled select regressed on #8191.

Yes, I'm aware of that. I haven't implemented this bit yet and I stated it in the description of #30113.

@danilo-leal
Copy link
Contributor Author

FYI: By removing the &:focus from the list box, as suggested by @oliviertassinari, the focus remains as @mnajdova had reported. I guess we'll resolve this in a better way once focus-visible is supported.

Screen Shot 2022-02-07 at 14 41 12

@oliviertassinari
Copy link
Member

oliviertassinari commented Feb 7, 2022

outline: 0 will solve this problem.

Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks much better than before, thanks!

@danilo-leal danilo-leal merged commit b59ea3e into mui:master Feb 10, 2022
@danilo-leal danilo-leal deleted the unstyled-demos branch February 10, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Adjust Base demos for dark mode
6 participants