[ISSUE #2199]💫Implement MappedFile append_message_bytes and append_message_with_offset🍻

[mxsm]

Which Issue(s) This PR Fixes(Closes)

Fixes #2199

Brief Description

How Did You Test This Change?

Summary by CodeRabbit

• Refactor

  • Updated method signatures to use more generic byte array types
  • Removed several methods from MappedFile and MappedFileRefactor traits
  • Modified memory ordering semantics for atomic operations

• Bug Fixes

  • Improved flexibility in handling byte data appending and retrieval

[coderabbitai]

Walkthrough

The pull request modifies the MappedFile and MappedFileRefactor traits in the RocketMQ store module. The key changes include removing the get_bytes method, updating method signatures to use &[u8] instead of &Bytes, and removing is_full and is_available methods from the MappedFileRefactor trait. These modifications aim to provide more flexibility in handling byte arrays and simplify the trait interfaces for mapped file operations.

Changes

File	Change Summary
rocketmq-store/src/log_file/mapped_file.rs	- Removed get_bytes method - Updated append_message_bytes to use &[u8] - Updated append_message_offset_length to use &[u8] - Removed is_full and is_available methods from MappedFileRefactor trait
rocketmq-store/src/log_file/mapped_file/default_mapped_file_impl.rs	- Changed append_message_offset_length parameter type from &Bytes to &[u8] - Modified atomic load operation from Ordering::Relaxed to Ordering::Acquire

Assessment against linked issues

Objective	Addressed	Explanation
Implement append_message_bytes [#2199]	✅
Implement append_message_with_offset [#2199]	✅

Possibly related PRs

• [ISSUE #2101]♻️Refactor DefaultMappedFile💫 #2102: Modifies shutdown method in MappedFile trait
• [ISSUE #2190]💫Add MappedFileRefactor trait🍻 #2191: Introduces MappedFileRefactor trait
• [ISSUE #2197]💫Replace MappedFile#is_full Ordering::Relaxed with Ordering::Acquire🍻 #2198: Updates memory ordering in is_full method

Suggested labels

feature🚀, auto merge, ready to review, waiting-review, AI review first, rocketmq-store crate

Suggested reviewers

• TeslaRustor
• SpaceXCN
• rocketmq-rust-bot

Poem

🐰 Mapped files dance with bytes so light,
Traits refactored, code shining bright
Flexibility springs, methods take flight
In RocketMQ's store, a coder's delight!
Bytes slice and sail with newfound might 🚀

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 142075a and 2e51043.

📒 Files selected for processing (2)

• rocketmq-store/src/log_file/mapped_file.rs (2 hunks)
• rocketmq-store/src/log_file/mapped_file/default_mapped_file_impl.rs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (9)

• GitHub Check: build (windows-latest, nightly)
• GitHub Check: build (windows-latest, stable)
• GitHub Check: build (macos-latest, nightly)
• GitHub Check: build (macos-latest, stable)
• GitHub Check: build
• GitHub Check: build (ubuntu-latest, nightly)
• GitHub Check: auto-approve
• GitHub Check: build (ubuntu-latest, stable)
• GitHub Check: test

🔇 Additional comments (4)

rocketmq-store/src/log_file/mapped_file/default_mapped_file_impl.rs (1)

342-343: LGTM! Memory ordering ensures consistency.

The implementation correctly uses Ordering::Acquire for loading current_pos and Ordering::AcqRel for updating wrote_position, ensuring proper memory synchronization between threads.

rocketmq-store/src/log_file/mapped_file.rs (3)

160-161: LGTM! Efficient implementation with improved type flexibility.

The implementation correctly delegates to append_message_offset_length with appropriate parameters, and the use of &[u8] instead of &Bytes provides better flexibility for callers.

---

177-177: LGTM! Consistent signature change.

The method signature change to use &[u8] aligns with the implementation in DefaultMappedFile and provides better flexibility.

---

179-192: LGTM! Well-documented method.

The documentation clearly explains the purpose, arguments, and return type of the get_bytes method, making it easy for users to understand its usage.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[rocketmq-rust-bot]

🔊@mxsm 🚀Thanks for your contribution🎉！

💡CodeRabbit(AI) will review your code first🔥！

Note

🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 28.74%. Comparing base (142075a) to head (2e51043).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...c/log_file/mapped_file/default_mapped_file_impl.rs	0.00%	2 Missing ⚠️
rocketmq-store/src/log_file/mapped_file.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2200   +/-   ##
=======================================
  Coverage   28.74%   28.74%           
=======================================
  Files         498      498           
  Lines       71069    71069           
=======================================
  Hits        20430    20430           
  Misses      50639    50639           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rocketmq-rust-bot]

LGTM