fix(core): Add an option to enable postgres ssl with default certs #6889

netroy · 2023-08-09T10:31:19Z

CP-809

github-actions · 2023-08-09T10:31:46Z

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

If fixing bug, added test to cover scenario.
If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

krynble

Naming is confusing, I'd expect the other ssl related flags to only work if I enable this one, but it's actually the other way around. Maybe rename to usePubliclyVerifiableSslCertificate

It's a bit too long but you get the idea.

packages/cli/src/Db.ts

packages/cli/src/config/schema.ts

codecov · 2023-08-09T10:55:15Z

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (77643e5) 33.48% compared to head (3a5a61e) 33.48%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #6889   +/-   ##
=======================================
  Coverage   33.48%   33.48%           
=======================================
  Files        3388     3388           
  Lines      206342   206343    +1     
  Branches    22279    22277    -2     
=======================================
+ Hits        69090    69092    +2     
+ Misses     136133   136132    -1     
  Partials     1119     1119

Files	Coverage Δ
packages/cli/src/config/schema.ts	`81.81% <ø> (ø)`
packages/cli/src/Db.ts	`57.95% <0.00%> (-0.67%)`	⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

krynble

LGTM - just left a question.

packages/cli/src/Db.ts

github-actions · 2023-10-09T11:16:43Z

⚠️ Some Cypress E2E specs are failing, please fix them before merging

cypress · 2023-10-09T11:16:48Z

Passing run #2433 ↗︎

0	250	0	0	0

Details:

🌳 fix-postgres-ssl 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project: n8n	Commit: `3a5a61e924`
Status: Passed	Duration: 08:48 💡
Started: Oct 9, 2023 11:39 AM	Ended: Oct 9, 2023 11:48 AM

Review all test suite changes for PR #6889 ↗︎

github-actions · 2023-10-09T11:48:38Z

✅ All Cypress E2E specs passed

…6889) CP-809

@Version

## [1.9.2](https://github.com/n8n-io/n8n/compare/n8n@1.9.1...n8n@1.9.2) (2023-10-09) ### Bug Fixes * **core:** Add an option to enable postgres ssl with default certs ([#6889](#6889)) ([0de6d7d](0de6d7d)) * **editor:** Fix disappearing NDV header in code nodes ([#7290](#7290)) ([7d87392](7d87392)) * **editor:** Remove excess margin below run data editor ([#7372](#7372)) ([8c38984](8c38984)) * **editor:** Use display option's @Version specifier ([#7351](#7351)) ([73a98cb](73a98cb)) * **Google BigQuery Node:** Location default to jobReference ([#7354](#7354)) ([489a12d](489a12d)) * **Google Drive Trigger Node:** Add Shared Drives support ([#7369](#7369)) ([138d26c](138d26c)) * **Google Sheets Node:** Fix "Maximum call stack size exceeded" error on too many rows ([#7384](#7384)) ([200fb54](200fb54)) * **HTML Node:** Update property fields to not use expressions on drag ([#7379](#7379)) ([4517001](4517001)) Co-authored-by: netroy <netroy@users.noreply.github.com>

janober · 2023-10-10T11:41:05Z

Got released with n8n@1.9.3

* master: (42 commits) fix(editor): Make workflow history button available only for dev builds (#7392) refactor: Upgrade to pnpm 8.9 (no-changelog) (#7393) ci: Identify NPM releases as `stable` (no-changelog) fix(editor): Implement canvas zoom UX improvements (#7376) feat(core): Switch binary filesystem mode to nested path structure (#7307) fix(editor): Fix completions for `.json` on quoted node name in Code node (#7382) fix(Notion Node): Handle empty values correctly for Notion selects + multi selects (#7383) feat(editor): Make PDF and Audio binary-data viewable in the UI (#7367) fix(Google Sheets Node): Fix "Maximum call stack size exceeded" error on too many rows (#7384) refactor(core): Refactor nodes loading (no-changelog) (#7283) fix(core): Add an option to enable postgres ssl with default certs (#6889) feat(editor): Workflow history [WIP]- Add restore and clone into new workflow actions (no-changelog) (#7359) fix(HTML Node): Update property fields to not use expressions on drag (#7379) fix: Add role check for upgrade path (#7374) fix(editor): Remove excess margin below run data editor (#7372) fix(Google Drive Trigger Node): Add Shared Drives support (#7369) feat(core): Add Job Summary to Worker response (#7360) feat(Execute Workflow Node): Run once for each item mode (#7289) refactor(core): Move `copyInputItems` to node helpers (no-changelog) (#7299) refactor(core): Create controller for binary data (no-changelog) (#7363) ... # Conflicts: # cypress/e2e/5-ndv.cy.ts

@Version

# [1.11.0](https://github.com/n8n-io/n8n/compare/n8n@1.10.0...n8n@1.11.0) (2023-10-11) ### Bug Fixes * **core:** Add an option to enable postgres ssl with default certs ([#6889](#6889)) ([789e1e7](789e1e7)) * **core:** Fix error on missing paired item data ([#7399](#7399)) ([47e8953](47e8953)) * **core:** Missing pairing info ([#7326](#7326)) ([e2c3c7a](e2c3c7a)) * **core:** Prevent object deletion request on no prefix match ([#7366](#7366)) ([63e11e4](63e11e4)) * **editor:** Fix completions for `.json` on quoted node name in Code node ([#7382](#7382)) ([86e7ec7](86e7ec7)) * **editor:** Implement canvas zoom UX improvements ([#7376](#7376)) ([7e06b31](7e06b31)) * **editor:** Make workflow history button available only for dev builds ([#7392](#7392)) ([7ed466d](7ed466d)) * **editor:** Remove excess margin below run data editor ([#7372](#7372)) ([3fa2764](3fa2764)) * **editor:** Sanitize HTML binary-data before rendering in the UI ([#7400](#7400)) ([2b075bf](2b075bf)) * **editor:** Use display option's @Version specifier ([#7351](#7351)) ([afbf0c3](afbf0c3)) * **Google BigQuery Node:** Location default to jobReference ([#7354](#7354)) ([97bb703](97bb703)) * **Google Drive Trigger Node:** Add Shared Drives support ([#7369](#7369)) ([3e7a4d3](3e7a4d3)) * **Google Sheets Node:** Fix "Maximum call stack size exceeded" error on too many rows ([#7384](#7384)) ([732b15a](732b15a)) * **HTML Node:** Update property fields to not use expressions on drag ([#7379](#7379)) ([77643e5](77643e5)) * **Notion Node:** Handle empty values correctly for Notion selects + multi selects ([#7383](#7383)) ([fbcd1d4](fbcd1d4)) * **Set Node:** Increase search priority ([#7358](#7358)) ([e5ad1e7](e5ad1e7)) * **Webhook Node:** Backward compatible form-data parsing for non-array files ([#7385](#7385)) ([6479eb1](6479eb1)) ### Features * **core:** Add Job Summary to Worker response ([#7360](#7360)) ([b8608ce](b8608ce)) * **core:** Integrate object store as binary data manager ([#7253](#7253)) ([1a661e6](1a661e6)) * **core:** Switch binary filesystem mode to nested path structure ([#7307](#7307)) ([0847623](0847623)) * **editor:** Make PDF and Audio binary-data viewable in the UI ([#7367](#7367)) ([8187be1](8187be1)) * **editor:** Support autologin for upgrade path ([#7316](#7316)) ([1dfa052](1dfa052)) * **Execute Workflow Node:** Run once for each item mode ([#7289](#7289)) ([c8c14ca](c8c14ca)) * **Item Lists Node:** Split merge binary data ([#7297](#7297)) ([965db8f](965db8f)) * **Loop Over Items (Split in Batches) Node:** Automatically add a loop + rename ([#7228](#7228)) ([7b773cc](7b773cc)) * **Notion Node:** Fetch child blocks recursively ([#7304](#7304)) ([193181a](193181a)) Co-authored-by: netroy <netroy@users.noreply.github.com>

…6889) CP-809

@Version

# [1.11.0](https://github.com/n8n-io/n8n/compare/n8n@1.10.0...n8n@1.11.0) (2023-10-11) ### Bug Fixes * **core:** Add an option to enable postgres ssl with default certs ([#6889](#6889)) ([789e1e7](789e1e7)) * **core:** Fix error on missing paired item data ([#7399](#7399)) ([47e8953](47e8953)) * **core:** Missing pairing info ([#7326](#7326)) ([e2c3c7a](e2c3c7a)) * **core:** Prevent object deletion request on no prefix match ([#7366](#7366)) ([63e11e4](63e11e4)) * **editor:** Fix completions for `.json` on quoted node name in Code node ([#7382](#7382)) ([86e7ec7](86e7ec7)) * **editor:** Implement canvas zoom UX improvements ([#7376](#7376)) ([7e06b31](7e06b31)) * **editor:** Make workflow history button available only for dev builds ([#7392](#7392)) ([7ed466d](7ed466d)) * **editor:** Remove excess margin below run data editor ([#7372](#7372)) ([3fa2764](3fa2764)) * **editor:** Sanitize HTML binary-data before rendering in the UI ([#7400](#7400)) ([2b075bf](2b075bf)) * **editor:** Use display option's @Version specifier ([#7351](#7351)) ([afbf0c3](afbf0c3)) * **Google BigQuery Node:** Location default to jobReference ([#7354](#7354)) ([97bb703](97bb703)) * **Google Drive Trigger Node:** Add Shared Drives support ([#7369](#7369)) ([3e7a4d3](3e7a4d3)) * **Google Sheets Node:** Fix "Maximum call stack size exceeded" error on too many rows ([#7384](#7384)) ([732b15a](732b15a)) * **HTML Node:** Update property fields to not use expressions on drag ([#7379](#7379)) ([77643e5](77643e5)) * **Notion Node:** Handle empty values correctly for Notion selects + multi selects ([#7383](#7383)) ([fbcd1d4](fbcd1d4)) * **Set Node:** Increase search priority ([#7358](#7358)) ([e5ad1e7](e5ad1e7)) * **Webhook Node:** Backward compatible form-data parsing for non-array files ([#7385](#7385)) ([6479eb1](6479eb1)) ### Features * **core:** Add Job Summary to Worker response ([#7360](#7360)) ([b8608ce](b8608ce)) * **core:** Integrate object store as binary data manager ([#7253](#7253)) ([1a661e6](1a661e6)) * **core:** Switch binary filesystem mode to nested path structure ([#7307](#7307)) ([0847623](0847623)) * **editor:** Make PDF and Audio binary-data viewable in the UI ([#7367](#7367)) ([8187be1](8187be1)) * **editor:** Support autologin for upgrade path ([#7316](#7316)) ([1dfa052](1dfa052)) * **Execute Workflow Node:** Run once for each item mode ([#7289](#7289)) ([c8c14ca](c8c14ca)) * **Item Lists Node:** Split merge binary data ([#7297](#7297)) ([965db8f](965db8f)) * **Loop Over Items (Split in Batches) Node:** Automatically add a loop + rename ([#7228](#7228)) ([7b773cc](7b773cc)) * **Notion Node:** Fetch child blocks recursively ([#7304](#7304)) ([193181a](193181a)) Co-authored-by: netroy <netroy@users.noreply.github.com>

krynble suggested changes Aug 9, 2023

View reviewed changes

packages/cli/src/Db.ts Outdated Show resolved Hide resolved

packages/cli/src/config/schema.ts Outdated Show resolved Hide resolved

n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Aug 9, 2023

fix(core): Add an option to enable postgres ssl with default certs

f33bb72

netroy force-pushed the fix-postgres-ssl branch from 2af6bf0 to f33bb72 Compare October 9, 2023 10:03

krynble previously approved these changes Oct 9, 2023

View reviewed changes

packages/cli/src/Db.ts Outdated Show resolved Hide resolved

update ssl type

3a5a61e

netroy dismissed krynble’s stale review via 3a5a61e October 9, 2023 11:22

netroy requested a review from krynble October 9, 2023 11:29

krynble approved these changes Oct 9, 2023

View reviewed changes

netroy merged commit 789e1e7 into master Oct 9, 2023
56 checks passed

netroy deleted the fix-postgres-ssl branch October 9, 2023 11:55

netroy added a commit that referenced this pull request Oct 9, 2023

fix(core): Add an option to enable postgres ssl with default certs (#…

0de6d7d

…6889) CP-809

github-actions bot mentioned this pull request Oct 9, 2023

🚀 Release 1.9.2 #7387

Merged

janober added the Released label Oct 10, 2023

github-actions bot mentioned this pull request Oct 11, 2023

🚀 Release 1.11.0 #7402

Merged

netroy mentioned this pull request Oct 11, 2023

Crash loop upgrading from 1.8.2 to 1.9.3 #7413

Closed

netroy added a commit that referenced this pull request Oct 17, 2023

fix(core): Add an option to enable postgres ssl with default certs (#…

0b4df79

…6889) CP-809

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(core): Add an option to enable postgres ssl with default certs #6889

fix(core): Add an option to enable postgres ssl with default certs #6889

netroy commented Aug 9, 2023 •

edited

Loading

github-actions bot commented Aug 9, 2023

krynble left a comment

codecov bot commented Aug 9, 2023 •

edited

Loading

krynble left a comment

github-actions bot commented Oct 9, 2023

cypress bot commented Oct 9, 2023 •

edited

Loading

github-actions bot commented Oct 9, 2023

janober commented Oct 10, 2023

fix(core): Add an option to enable postgres ssl with default certs #6889

fix(core): Add an option to enable postgres ssl with default certs #6889

Conversation

netroy commented Aug 9, 2023 • edited Loading

github-actions bot commented Aug 9, 2023

krynble left a comment

Choose a reason for hiding this comment

codecov bot commented Aug 9, 2023 • edited Loading

Codecov Report

krynble left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 9, 2023

cypress bot commented Oct 9, 2023 • edited Loading

Passing run #2433 ↗︎

Review all test suite changes for PR #6889 ↗︎

github-actions bot commented Oct 9, 2023

janober commented Oct 10, 2023

netroy commented Aug 9, 2023 •

edited

Loading

codecov bot commented Aug 9, 2023 •

edited

Loading

cypress bot commented Oct 9, 2023 •

edited

Loading