feat(editor): Workflow history [WIP]- Add restore and clone into new workflow actions (no-changelog) #7359

cstuncsik · 2023-10-05T13:58:26Z

No description provided.

github-actions · 2023-10-05T13:58:45Z

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

If fixing bug, added test to cover scenario.
If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

Added unit tests to cover new or updated functionality.

Files matching **/*.vue:

Used composition API for all new components.
Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

Added E2E if adding new features.
Used design system tokens (colors, spacings...) where possible.

Make sure to check off this list before asking for review.

…-and-clone-into-new-workflow-actions # Conflicts: # packages/editor-ui/src/stores/workflowHistory.store.ts

codecov · 2023-10-05T14:23:39Z

Codecov Report

Attention: 241 lines in your changes are missing coverage. Please review.

Comparison is base (3fa2764) 33.48% compared to head (8f965c3) 33.46%.
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7359      +/-   ##
==========================================
- Coverage   33.48%   33.46%   -0.03%     
==========================================
  Files        3388     3389       +1     
  Lines      206340   206596     +256     
  Branches    22283    22284       +1     
==========================================
+ Hits        69092    69128      +36     
- Misses     136129   136349     +220     
  Partials     1119     1119

Files	Coverage Δ
...components/WorkflowHistory/WorkflowHistoryList.vue	`96.41% <100.00%> (+0.11%)`	⬆️
packages/editor-ui/src/constants.ts	`99.68% <100.00%> (+<0.01%)`	⬆️
packages/editor-ui/src/stores/ui.store.ts	`59.15% <100.00%> (+0.26%)`	⬆️
...onents/WorkflowHistory/WorkflowHistoryListItem.vue	`97.84% <92.30%> (+0.09%)`	⬆️
packages/editor-ui/src/components/Modals.vue	`0.00% <0.00%> (ø)`
...ages/editor-ui/src/stores/workflowHistory.store.ts	`42.72% <26.56%> (-24.62%)`	⬇️
packages/editor-ui/src/views/WorkflowHistory.vue	`66.66% <14.42%> (-15.90%)`	⬇️
...flowHistory/WorkflowHistoryVersionRestoreModal.vue	`0.00% <0.00%> (ø)`

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…-and-clone-into-new-workflow-actions # Conflicts: # packages/editor-ui/src/stores/ui.store.ts

krynble

Tested and it's working fine - just to make sure, testing more thoroughly is coming in the next PR right?

cypress · 2023-10-09T10:35:41Z

Passing run #2434 ↗︎

0	250	0	0	0

Details:

🌳 pay-870-add-restore-and-clone-into-new-workflow-actions 🖥️ browsers:node18.1...
Project: n8n	Commit: `8f965c30dc`
Status: Passed	Duration: 08:29 💡
Started: Oct 9, 2023 11:40 AM	Ended: Oct 9, 2023 11:48 AM

Review all test suite changes for PR #7359 ↗︎

github-actions · 2023-10-09T10:35:43Z

✅ All Cypress E2E specs passed

ivov

Cloning does not offer a link to go to the new workflow in the toast? Or inform the name of the new workflow in the modal? I feel we are leaving the user to "go find it" rather than making it easy for them to locate it.
Cloning twice doesn't work? Getting There is already an entry with this name
Restoring a workflow to the latest version shouldn't work? I'd expect The workflow is already at the latest version
Restoring does not display the new topmost version? The topmost version remains the same until refreshing.
A workflow saved only once shows no versions instead of one version?
Saving an activated workflow fails to reflect the new version on the column?
Any answer about these?

packages/editor-ui/src/stores/workflowHistory.store.ts

packages/editor-ui/src/views/WorkflowHistory.vue

…ing and downloading

cstuncsik · 2023-10-09T11:18:31Z

Cloning does not offer a link to go to the new workflow in the toast? Or inform the name of the new workflow in the modal? I feel we are leaving the user to "go find it" rather than making it easy for them to locate it.

Cloning twice doesn't work? Getting There is already an entry with this name

Restoring a workflow to the latest version shouldn't work? I'd expect The workflow is already at the latest version

Restoring does not display the new topmost version? The topmost version remains the same until refreshing.

A workflow saved only once shows no versions instead of one version?

Saving an activated workflow fails to reflect the new version on the column?

Any answer about these?

These should be addressed in another PR, forwarded them to UI/UX

github-actions · 2023-10-09T11:49:04Z

✅ All Cypress E2E specs passed

* master: (42 commits) fix(editor): Make workflow history button available only for dev builds (#7392) refactor: Upgrade to pnpm 8.9 (no-changelog) (#7393) ci: Identify NPM releases as `stable` (no-changelog) fix(editor): Implement canvas zoom UX improvements (#7376) feat(core): Switch binary filesystem mode to nested path structure (#7307) fix(editor): Fix completions for `.json` on quoted node name in Code node (#7382) fix(Notion Node): Handle empty values correctly for Notion selects + multi selects (#7383) feat(editor): Make PDF and Audio binary-data viewable in the UI (#7367) fix(Google Sheets Node): Fix "Maximum call stack size exceeded" error on too many rows (#7384) refactor(core): Refactor nodes loading (no-changelog) (#7283) fix(core): Add an option to enable postgres ssl with default certs (#6889) feat(editor): Workflow history [WIP]- Add restore and clone into new workflow actions (no-changelog) (#7359) fix(HTML Node): Update property fields to not use expressions on drag (#7379) fix: Add role check for upgrade path (#7374) fix(editor): Remove excess margin below run data editor (#7372) fix(Google Drive Trigger Node): Add Shared Drives support (#7369) feat(core): Add Job Summary to Worker response (#7360) feat(Execute Workflow Node): Run once for each item mode (#7289) refactor(core): Move `copyInputItems` to node helpers (no-changelog) (#7299) refactor(core): Create controller for binary data (no-changelog) (#7363) ... # Conflicts: # cypress/e2e/5-ndv.cy.ts

janober · 2023-10-11T13:57:06Z

Got released with n8n@1.11.0

feat(editor): Add workflow version cloning

3f03698

Merge remote-tracking branch 'origin/master' into pay-870-add-restore…

2153107

…-and-clone-into-new-workflow-actions # Conflicts: # packages/editor-ui/src/stores/workflowHistory.store.ts

n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Oct 5, 2023

cstuncsik added 12 commits October 5, 2023 18:22

feat(editor): Creating clone from a workflow history version

dbf5105

feat(editor): Add restoring action

860105b

fix(editor): Date formatting

94e3d1e

fix(editor): Move download action to store

dd4a4c9

fix(editor): Update download action

c774f0d

fix(editor): Show error toast when action is failed

f4f9860

fix(editor): Lint fix

2897ee4

fix(editor): Add restoration confirmation

7927079

fix(editor): Fix restoration confirmation

2827616

fix(editor): Add workflow history clone and restore success toast

7c40af2

fix(editor): Rename version restore modal action

b63d592

Merge remote-tracking branch 'origin/master' into pay-870-add-restore…

e8e6414

…-and-clone-into-new-workflow-actions # Conflicts: # packages/editor-ui/src/stores/ui.store.ts

krynble previously approved these changes Oct 9, 2023

View reviewed changes

ivov reviewed Oct 9, 2023

View reviewed changes

packages/editor-ui/src/stores/workflowHistory.store.ts Outdated Show resolved Hide resolved

packages/editor-ui/src/stores/workflowHistory.store.ts Outdated Show resolved Hide resolved

packages/editor-ui/src/views/WorkflowHistory.vue Show resolved Hide resolved

fix(editor): Remove unnecessary conditions from workflow history clon…

8f965c3

…ing and downloading

cstuncsik dismissed krynble’s stale review via 8f965c3 October 9, 2023 11:08

cstuncsik requested review from krynble and ivov October 9, 2023 11:18

krynble approved these changes Oct 9, 2023

View reviewed changes

cstuncsik merged commit b3247e5 into master Oct 9, 2023
61 checks passed

cstuncsik deleted the pay-870-add-restore-and-clone-into-new-workflow-actions branch October 9, 2023 11:50

janober added the Released label Oct 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(editor): Workflow history [WIP]- Add restore and clone into new workflow actions (no-changelog) #7359

feat(editor): Workflow history [WIP]- Add restore and clone into new workflow actions (no-changelog) #7359

cstuncsik commented Oct 5, 2023

github-actions bot commented Oct 5, 2023

codecov bot commented Oct 5, 2023 •

edited

Loading

krynble left a comment

cypress bot commented Oct 9, 2023 •

edited

Loading

github-actions bot commented Oct 9, 2023

ivov left a comment

cstuncsik commented Oct 9, 2023

github-actions bot commented Oct 9, 2023

janober commented Oct 11, 2023

feat(editor): Workflow history [WIP]- Add restore and clone into new workflow actions (no-changelog) #7359

feat(editor): Workflow history [WIP]- Add restore and clone into new workflow actions (no-changelog) #7359

Conversation

cstuncsik commented Oct 5, 2023

github-actions bot commented Oct 5, 2023

codecov bot commented Oct 5, 2023 • edited Loading

Codecov Report

krynble left a comment

Choose a reason for hiding this comment

cypress bot commented Oct 9, 2023 • edited Loading

Passing run #2434 ↗︎

Review all test suite changes for PR #7359 ↗︎

github-actions bot commented Oct 9, 2023

ivov left a comment

Choose a reason for hiding this comment

cstuncsik commented Oct 9, 2023

github-actions bot commented Oct 9, 2023

janober commented Oct 11, 2023

codecov bot commented Oct 5, 2023 •

edited

Loading

cypress bot commented Oct 9, 2023 •

edited

Loading