feat(core): Add Job Summary to Worker response #7360

flipswitchingmonkey · 2023-10-05T15:24:32Z

No description provided.

github-actions · 2023-10-05T15:24:47Z

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

If fixing bug, added test to cover scenario.
If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

ivov

Minor things only

packages/cli/src/commands/worker.ts

ivov · 2023-10-05T15:27:42Z

packages/cli/src/commands/worker.ts

+			name: fullExecutionData.workflowData.name,
+			mode: fullExecutionData.mode,
+			startedAt: fullExecutionData.startedAt,
+			workflowId: fullExecutionData.workflowId ?? '',


Can there be an execution without a workflow ID?

ivov · 2023-10-05T15:28:08Z

packages/cli/src/commands/worker.ts

+			mode: fullExecutionData.mode,
+			startedAt: fullExecutionData.startedAt,
+			workflowId: fullExecutionData.workflowId ?? '',
+			retryOf: fullExecutionData.retryOf ?? '',


Suggested change

retryOf: fullExecutionData.retryOf ?? '',

retryOf: fullExecutionData.retryOf ?? null,

ivov · 2023-10-05T15:29:14Z

packages/cli/src/commands/worker.ts

@@ -311,6 +325,7 @@ export class Worker extends BaseCommand {
 				instanceId: this.instanceId,
 				redisPublisher: this.redisPublisher,
 				getRunningJobIds: () => Object.keys(Worker.runningJobs),
+				getRunningJobSummary: () => Object.values(Worker.runningJobsSummary),


Suggested change

getRunningJobSummary: () => Object.values(Worker.runningJobsSummary),

getRunningJobsSummary: () => Object.values(Worker.runningJobsSummary),

codecov · 2023-10-05T15:54:44Z

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (afa683a) 33.43% compared to head (379cb8f) 33.42%.
Report is 5 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7360      +/-   ##
==========================================
- Coverage   33.43%   33.42%   -0.01%     
==========================================
  Files        3385     3385              
  Lines      206214   206222       +8     
  Branches    22261    22258       -3     
==========================================
- Hits        68946    68936      -10     
- Misses     136151   136169      +18     
  Partials     1117     1117

Files	Coverage Δ
...src/services/orchestration.handler.base.service.ts	`80.00% <ø> (ø)`
...hestration/main/handleWorkerResponseMessageMain.ts	`100.00% <100.00%> (ø)`
...orchestration/worker/handleCommandMessageWorker.ts	`18.75% <100.00%> (+0.38%)`	⬆️
...ion/worker/orchestration.handler.worker.service.ts	`50.00% <ø> (ø)`
packages/cli/src/commands/worker.ts	`26.72% <25.00%> (-0.04%)`	⬇️
packages/cli/src/services/orchestration/helpers.ts	`72.72% <40.00%> (-9.63%)`	⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Conflicts: # packages/cli/src/commands/worker.ts # packages/cli/src/services/orchestration/worker/handleCommandMessageWorker.ts

cypress · 2023-10-06T15:51:59Z

2 flaky tests on run #2421 ↗︎

0	248	0	0	2

Details:

🌳 noissue-add-job-summary-to-worker-response 🖥️ browsers:node18.12.0-chrome107...
Project: n8n	Commit: `379cb8f874`
Status: Passed	Duration: 07:24 💡
Started: Oct 6, 2023 3:44 PM	Ended: Oct 6, 2023 3:51 PM

2-credentials.cy.ts • 1 flaky test

View Output Video

Test		Artifacts
Credentials > should create a new credential using Add Credential button		`Output` `Screenshots` `Video`

29-sql-editor.cy.ts • 1 flaky test

View Output Video

Test		Artifacts
SQL editors > should preserve changes when opening-closing Postgres node		`Output` `Screenshots` `Video`

Review all test suite changes for PR #7360 ↗︎

github-actions · 2023-10-06T15:52:05Z

✅ All Cypress E2E specs passed

* master: (42 commits) fix(editor): Make workflow history button available only for dev builds (#7392) refactor: Upgrade to pnpm 8.9 (no-changelog) (#7393) ci: Identify NPM releases as `stable` (no-changelog) fix(editor): Implement canvas zoom UX improvements (#7376) feat(core): Switch binary filesystem mode to nested path structure (#7307) fix(editor): Fix completions for `.json` on quoted node name in Code node (#7382) fix(Notion Node): Handle empty values correctly for Notion selects + multi selects (#7383) feat(editor): Make PDF and Audio binary-data viewable in the UI (#7367) fix(Google Sheets Node): Fix "Maximum call stack size exceeded" error on too many rows (#7384) refactor(core): Refactor nodes loading (no-changelog) (#7283) fix(core): Add an option to enable postgres ssl with default certs (#6889) feat(editor): Workflow history [WIP]- Add restore and clone into new workflow actions (no-changelog) (#7359) fix(HTML Node): Update property fields to not use expressions on drag (#7379) fix: Add role check for upgrade path (#7374) fix(editor): Remove excess margin below run data editor (#7372) fix(Google Drive Trigger Node): Add Shared Drives support (#7369) feat(core): Add Job Summary to Worker response (#7360) feat(Execute Workflow Node): Run once for each item mode (#7289) refactor(core): Move `copyInputItems` to node helpers (no-changelog) (#7299) refactor(core): Create controller for binary data (no-changelog) (#7363) ... # Conflicts: # cypress/e2e/5-ndv.cy.ts

@Version

# [1.11.0](https://github.com/n8n-io/n8n/compare/n8n@1.10.0...n8n@1.11.0) (2023-10-11) ### Bug Fixes * **core:** Add an option to enable postgres ssl with default certs ([#6889](#6889)) ([789e1e7](789e1e7)) * **core:** Fix error on missing paired item data ([#7399](#7399)) ([47e8953](47e8953)) * **core:** Missing pairing info ([#7326](#7326)) ([e2c3c7a](e2c3c7a)) * **core:** Prevent object deletion request on no prefix match ([#7366](#7366)) ([63e11e4](63e11e4)) * **editor:** Fix completions for `.json` on quoted node name in Code node ([#7382](#7382)) ([86e7ec7](86e7ec7)) * **editor:** Implement canvas zoom UX improvements ([#7376](#7376)) ([7e06b31](7e06b31)) * **editor:** Make workflow history button available only for dev builds ([#7392](#7392)) ([7ed466d](7ed466d)) * **editor:** Remove excess margin below run data editor ([#7372](#7372)) ([3fa2764](3fa2764)) * **editor:** Sanitize HTML binary-data before rendering in the UI ([#7400](#7400)) ([2b075bf](2b075bf)) * **editor:** Use display option's @Version specifier ([#7351](#7351)) ([afbf0c3](afbf0c3)) * **Google BigQuery Node:** Location default to jobReference ([#7354](#7354)) ([97bb703](97bb703)) * **Google Drive Trigger Node:** Add Shared Drives support ([#7369](#7369)) ([3e7a4d3](3e7a4d3)) * **Google Sheets Node:** Fix "Maximum call stack size exceeded" error on too many rows ([#7384](#7384)) ([732b15a](732b15a)) * **HTML Node:** Update property fields to not use expressions on drag ([#7379](#7379)) ([77643e5](77643e5)) * **Notion Node:** Handle empty values correctly for Notion selects + multi selects ([#7383](#7383)) ([fbcd1d4](fbcd1d4)) * **Set Node:** Increase search priority ([#7358](#7358)) ([e5ad1e7](e5ad1e7)) * **Webhook Node:** Backward compatible form-data parsing for non-array files ([#7385](#7385)) ([6479eb1](6479eb1)) ### Features * **core:** Add Job Summary to Worker response ([#7360](#7360)) ([b8608ce](b8608ce)) * **core:** Integrate object store as binary data manager ([#7253](#7253)) ([1a661e6](1a661e6)) * **core:** Switch binary filesystem mode to nested path structure ([#7307](#7307)) ([0847623](0847623)) * **editor:** Make PDF and Audio binary-data viewable in the UI ([#7367](#7367)) ([8187be1](8187be1)) * **editor:** Support autologin for upgrade path ([#7316](#7316)) ([1dfa052](1dfa052)) * **Execute Workflow Node:** Run once for each item mode ([#7289](#7289)) ([c8c14ca](c8c14ca)) * **Item Lists Node:** Split merge binary data ([#7297](#7297)) ([965db8f](965db8f)) * **Loop Over Items (Split in Batches) Node:** Automatically add a loop + rename ([#7228](#7228)) ([7b773cc](7b773cc)) * **Notion Node:** Fetch child blocks recursively ([#7304](#7304)) ([193181a](193181a)) Co-authored-by: netroy <netroy@users.noreply.github.com>

janober · 2023-10-11T13:57:04Z

Got released with n8n@1.11.0

@Version

# [1.11.0](https://github.com/n8n-io/n8n/compare/n8n@1.10.0...n8n@1.11.0) (2023-10-11) ### Bug Fixes * **core:** Add an option to enable postgres ssl with default certs ([#6889](#6889)) ([789e1e7](789e1e7)) * **core:** Fix error on missing paired item data ([#7399](#7399)) ([47e8953](47e8953)) * **core:** Missing pairing info ([#7326](#7326)) ([e2c3c7a](e2c3c7a)) * **core:** Prevent object deletion request on no prefix match ([#7366](#7366)) ([63e11e4](63e11e4)) * **editor:** Fix completions for `.json` on quoted node name in Code node ([#7382](#7382)) ([86e7ec7](86e7ec7)) * **editor:** Implement canvas zoom UX improvements ([#7376](#7376)) ([7e06b31](7e06b31)) * **editor:** Make workflow history button available only for dev builds ([#7392](#7392)) ([7ed466d](7ed466d)) * **editor:** Remove excess margin below run data editor ([#7372](#7372)) ([3fa2764](3fa2764)) * **editor:** Sanitize HTML binary-data before rendering in the UI ([#7400](#7400)) ([2b075bf](2b075bf)) * **editor:** Use display option's @Version specifier ([#7351](#7351)) ([afbf0c3](afbf0c3)) * **Google BigQuery Node:** Location default to jobReference ([#7354](#7354)) ([97bb703](97bb703)) * **Google Drive Trigger Node:** Add Shared Drives support ([#7369](#7369)) ([3e7a4d3](3e7a4d3)) * **Google Sheets Node:** Fix "Maximum call stack size exceeded" error on too many rows ([#7384](#7384)) ([732b15a](732b15a)) * **HTML Node:** Update property fields to not use expressions on drag ([#7379](#7379)) ([77643e5](77643e5)) * **Notion Node:** Handle empty values correctly for Notion selects + multi selects ([#7383](#7383)) ([fbcd1d4](fbcd1d4)) * **Set Node:** Increase search priority ([#7358](#7358)) ([e5ad1e7](e5ad1e7)) * **Webhook Node:** Backward compatible form-data parsing for non-array files ([#7385](#7385)) ([6479eb1](6479eb1)) ### Features * **core:** Add Job Summary to Worker response ([#7360](#7360)) ([b8608ce](b8608ce)) * **core:** Integrate object store as binary data manager ([#7253](#7253)) ([1a661e6](1a661e6)) * **core:** Switch binary filesystem mode to nested path structure ([#7307](#7307)) ([0847623](0847623)) * **editor:** Make PDF and Audio binary-data viewable in the UI ([#7367](#7367)) ([8187be1](8187be1)) * **editor:** Support autologin for upgrade path ([#7316](#7316)) ([1dfa052](1dfa052)) * **Execute Workflow Node:** Run once for each item mode ([#7289](#7289)) ([c8c14ca](c8c14ca)) * **Item Lists Node:** Split merge binary data ([#7297](#7297)) ([965db8f](965db8f)) * **Loop Over Items (Split in Batches) Node:** Automatically add a loop + rename ([#7228](#7228)) ([7b773cc](7b773cc)) * **Notion Node:** Fetch child blocks recursively ([#7304](#7304)) ([193181a](193181a)) Co-authored-by: netroy <netroy@users.noreply.github.com>

add-job-summary-to-worker-response

325d6b0

n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Oct 5, 2023

ivov reviewed Oct 5, 2023

View reviewed changes

flipswitchingmonkey added 2 commits October 6, 2023 14:07

Merge branch 'master' into noissue-add-job-summary-to-worker-response

593bfc5

# Conflicts: # packages/cli/src/commands/worker.ts # packages/cli/src/services/orchestration/worker/handleCommandMessageWorker.ts

improve status msg

379cb8f

flipswitchingmonkey requested a review from ivov October 6, 2023 13:19

ivov approved these changes Oct 6, 2023

View reviewed changes

flipswitchingmonkey merged commit b8608ce into master Oct 6, 2023
54 of 55 checks passed

flipswitchingmonkey deleted the noissue-add-job-summary-to-worker-response branch October 6, 2023 15:52

github-actions bot mentioned this pull request Oct 11, 2023

🚀 Release 1.11.0 #7402

Merged

janober added the Released label Oct 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(core): Add Job Summary to Worker response #7360

feat(core): Add Job Summary to Worker response #7360

flipswitchingmonkey commented Oct 5, 2023

github-actions bot commented Oct 5, 2023

ivov left a comment

ivov Oct 5, 2023

ivov Oct 5, 2023

ivov Oct 5, 2023

codecov bot commented Oct 5, 2023 •

edited

Loading

cypress bot commented Oct 6, 2023

github-actions bot commented Oct 6, 2023

janober commented Oct 11, 2023

	retryOf: fullExecutionData.retryOf ?? '',
	retryOf: fullExecutionData.retryOf ?? null,

	getRunningJobSummary: () => Object.values(Worker.runningJobsSummary),
	getRunningJobsSummary: () => Object.values(Worker.runningJobsSummary),

feat(core): Add Job Summary to Worker response #7360

feat(core): Add Job Summary to Worker response #7360

Conversation

flipswitchingmonkey commented Oct 5, 2023

github-actions bot commented Oct 5, 2023

ivov left a comment

Choose a reason for hiding this comment

ivov Oct 5, 2023

Choose a reason for hiding this comment

ivov Oct 5, 2023

Choose a reason for hiding this comment

ivov Oct 5, 2023

Choose a reason for hiding this comment

codecov bot commented Oct 5, 2023 • edited Loading

Codecov Report

cypress bot commented Oct 6, 2023

2 flaky tests on run #2421 ↗︎

Review all test suite changes for PR #7360 ↗︎

github-actions bot commented Oct 6, 2023

janober commented Oct 11, 2023

codecov bot commented Oct 5, 2023 •

edited

Loading