Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Add support for in-transit encryption (TLS) on Redis connections #7047

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented Aug 30, 2023

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (cc37a50) 31.90% compared to head (8213797) 31.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7047      +/-   ##
==========================================
- Coverage   31.90%   31.90%   -0.01%     
==========================================
  Files        3268     3268              
  Lines      197657   197659       +2     
  Branches    21528    21527       -1     
==========================================
- Hits        63058    63056       -2     
- Misses     133561   133565       +4     
  Partials     1038     1038              
Files Changed Coverage Δ
packages/cli/src/config/schema.ts 37.50% <ø> (ø)
...kages/cli/src/services/redis/RedisServiceHelper.ts 39.43% <0.00%> (-1.15%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Aug 30, 2023
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cypress
Copy link

cypress bot commented Sep 5, 2023

Passing run #2103 ↗︎

0 238 0 0 Flakiness 0

Details:

🌳 redis-tls 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project: n8n Commit: 8213797e86
Status: Passed Duration: 07:55 💡
Started: Sep 5, 2023 3:59 PM Ended: Sep 5, 2023 4:07 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

✅ All Cypress E2E specs passed

@netroy netroy merged commit a910757 into master Sep 5, 2023
19 checks passed
@netroy netroy deleted the redis-tls branch September 5, 2023 16:18
@Joffcom Joffcom mentioned this pull request Sep 6, 2023
@github-actions github-actions bot mentioned this pull request Sep 6, 2023
netroy added a commit that referenced this pull request Sep 6, 2023
# [1.6.0](https://github.com/n8n-io/n8n/compare/n8n@1.5.1...n8n@1.6.0)
(2023-09-06)


### Bug Fixes

* **core:** Add support for in-transit encryption (TLS) on Redis
connections ([#7047](#7047))
([a910757](a910757))
* **core:** Disallow orphan executions
([#7069](#7069))
([8a28e98](8a28e98))
* **core:** Split event bus controller into community and ee
([#7107](#7107))
([011ee2e](011ee2e))
* **editor:** Standardize save text
([#7093](#7093))
([58b3492](58b3492))
* Ensure all new executions are saved
([#7061](#7061))
([b8e06d2](b8e06d2))
* Load remote resources even if expressions in non requried parameters
resolve ([#6987](#6987))
([8a8d4e8](8a8d4e8))
* **Postgres Node:** Connection pool of the database object has been
destroyed ([#7074](#7074))
([9dd5f0e](9dd5f0e))
* **Postgres Node:** Tunnel doesn't always close
([#7087](#7087))
([58e55ba](58e55ba))


### Features

* **core:** Add list query middleware to credentials
([#7041](#7041))
([fd78021](fd78021))
* **core:** Add support for floating licenses
([#7090](#7090))
([e26553f](e26553f))
* **core:** Migration for soft deletions for executions
([#7088](#7088))
([413e0bc](413e0bc))
* **HTTP Request Node:** Determine binary file name from
content-disposition headers
([#7032](#7032))
([273d091](273d091))
* **TheHive Node:** Overhaul
([#6457](#6457))
([73e782e](73e782e))

Co-authored-by: netroy <netroy@users.noreply.github.com>
@janober
Copy link
Member

janober commented Sep 6, 2023

Got released with n8n@1.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants