Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Postgres Node): Tunnel doesn't always close #7087

Merged

Conversation

michael-radency
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):

https://community.n8n.io/t/postgresql-credentials-using-ssh-tunnel/27868/2

@michael-radency michael-radency added n8n team Authored by the n8n team node/issue Issue with a node labels Sep 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@cypress
Copy link

cypress bot commented Sep 4, 2023

1 flaky test on run #2070 ↗︎

0 238 0 0 Flakiness 1

Details:

🌳 node-742-postgres-tunnel-doesnt-always-close 🖥️ browsers:node18.12.0-chrome1...
Project: n8n Commit: 9a75a09bff
Status: Passed Duration: 08:04 💡
Started: Sep 4, 2023 10:15 AM Ended: Sep 4, 2023 10:23 AM
Flakiness  cypress/e2e/6-code-node.cy.ts • 1 flaky test

View Output Video

Test Artifacts
... > generate code button should have correct state & tooltips Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

✅ All Cypress E2E specs passed

@michael-radency michael-radency merged commit 58e55ba into master Sep 4, 2023
17 checks passed
@michael-radency michael-radency deleted the node-742-postgres-tunnel-doesnt-always-close branch September 4, 2023 10:26
@github-actions github-actions bot mentioned this pull request Sep 6, 2023
netroy added a commit that referenced this pull request Sep 6, 2023
# [1.6.0](https://github.com/n8n-io/n8n/compare/n8n@1.5.1...n8n@1.6.0)
(2023-09-06)


### Bug Fixes

* **core:** Add support for in-transit encryption (TLS) on Redis
connections ([#7047](#7047))
([a910757](a910757))
* **core:** Disallow orphan executions
([#7069](#7069))
([8a28e98](8a28e98))
* **core:** Split event bus controller into community and ee
([#7107](#7107))
([011ee2e](011ee2e))
* **editor:** Standardize save text
([#7093](#7093))
([58b3492](58b3492))
* Ensure all new executions are saved
([#7061](#7061))
([b8e06d2](b8e06d2))
* Load remote resources even if expressions in non requried parameters
resolve ([#6987](#6987))
([8a8d4e8](8a8d4e8))
* **Postgres Node:** Connection pool of the database object has been
destroyed ([#7074](#7074))
([9dd5f0e](9dd5f0e))
* **Postgres Node:** Tunnel doesn't always close
([#7087](#7087))
([58e55ba](58e55ba))


### Features

* **core:** Add list query middleware to credentials
([#7041](#7041))
([fd78021](fd78021))
* **core:** Add support for floating licenses
([#7090](#7090))
([e26553f](e26553f))
* **core:** Migration for soft deletions for executions
([#7088](#7088))
([413e0bc](413e0bc))
* **HTTP Request Node:** Determine binary file name from
content-disposition headers
([#7032](#7032))
([273d091](273d091))
* **TheHive Node:** Overhaul
([#6457](#6457))
([73e782e](73e782e))

Co-authored-by: netroy <netroy@users.noreply.github.com>
@janober
Copy link
Member

janober commented Sep 6, 2023

Got released with n8n@1.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/issue Issue with a node Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants