feat(core): Migration for soft deletions for executions #7088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
n8n-assistant
bot
added
core
netroy
reviewed
Sep 4, 2023
| */ | ||
| export class ExecutionSoftDelete1693491613982 implements ReversibleMigration { | ||
| async up({ schemaBuilder: { addColumns, column, createIndex } }: MigrationContext) { | ||
| await addColumns('execution_entity', [column('deletedAt').timestamp()]); |
There was a problem hiding this comment.
I was adding createdAt here because we are currently using startedAt incorrectly as createdAt in queue mode, and I wanted to avoid creating 2 separate migrations.
But now that the execution data is in a separate table, perhaps another migration isn't actually going to be that bad. if that's the case, we should also remove the field from the entity.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #7088 +/- ##
==========================================
- Coverage 32.11% 32.11% -0.01%
==========================================
Files 3188 3188
Lines 195897 195898 +1
Branches 21357 21361 +4
==========================================
- Hits 62906 62903 -3
- Misses 131959 131962 +3
- Partials 1032 1033 +1
☔ View full report in Codecov by Sentry. |
netroy
approved these changes
Sep 4, 2023
|
|
1 flaky test on run #2073 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
|
✅ All Cypress E2E specs passed |
ivov
deleted the
pay-770-migration-introducing-soft-deletes-for-executions
branch
Merged
netroy
added a commit
that referenced
this pull request
Sep 6, 2023
# [1.6.0](https://github.com/n8n-io/n8n/compare/n8n@1.5.1...n8n@1.6.0) (2023-09-06) ### Bug Fixes * **core:** Add support for in-transit encryption (TLS) on Redis connections ([#7047](#7047)) ([a910757](a910757)) * **core:** Disallow orphan executions ([#7069](#7069)) ([8a28e98](8a28e98)) * **core:** Split event bus controller into community and ee ([#7107](#7107)) ([011ee2e](011ee2e)) * **editor:** Standardize save text ([#7093](#7093)) ([58b3492](58b3492)) * Ensure all new executions are saved ([#7061](#7061)) ([b8e06d2](b8e06d2)) * Load remote resources even if expressions in non requried parameters resolve ([#6987](#6987)) ([8a8d4e8](8a8d4e8)) * **Postgres Node:** Connection pool of the database object has been destroyed ([#7074](#7074)) ([9dd5f0e](9dd5f0e)) * **Postgres Node:** Tunnel doesn't always close ([#7087](#7087)) ([58e55ba](58e55ba)) ### Features * **core:** Add list query middleware to credentials ([#7041](#7041)) ([fd78021](fd78021)) * **core:** Add support for floating licenses ([#7090](#7090)) ([e26553f](e26553f)) * **core:** Migration for soft deletions for executions ([#7088](#7088)) ([413e0bc](413e0bc)) * **HTTP Request Node:** Determine binary file name from content-disposition headers ([#7032](#7032)) ([273d091](273d091)) * **TheHive Node:** Overhaul ([#6457](#6457)) ([73e782e](73e782e)) Co-authored-by: netroy <netroy@users.noreply.github.com>
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #7065
Story: https://linear.app/n8n/issue/PAY-770/write-migrations-introducing-soft-deletion