ci(core): Load config schema after process.env has been overwritten (no-changelog) #7550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Make sure to check off this list before asking for review. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7550 +/- ##
===========================================
+ Coverage 17.46% 33.59% +16.12%
===========================================
Files 2768 3404 +636
Lines 102742 207791 +105049
Branches 19947 22486 +2539
===========================================
+ Hits 17941 69800 +51859
- Misses 83665 136844 +53179
- Partials 1136 1147 +11
☔ View full report in Codecov by Sentry. |
n8n-assistant
bot
added
core
netroy
force-pushed
the
fix-N8N_USER_FOLDER-in-e2e
branch
from
609156b
to
bb94b18
Compare
netroy
force-pushed
the
fix-N8N_USER_FOLDER-in-e2e
branch
from
bb94b18
to
6693287
Compare
tomi
reviewed
Nov 7, 2023
netroy
force-pushed
the
fix-N8N_USER_FOLDER-in-e2e
branch
from
6693287
to
b6f79a2
Compare
tomi
previously approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Nice one 🥇 Only one question: do we need to have a changelog entry for this, since this changes the path used for static cache? (I assume the no-changelog in the commit means it will not be included in automatically generated changelog)
E: Nevermind, the default stays the same
The path is still the same as before: |
Passing run #2758 ↗︎
Details:
Review all test suite changes for PR #7550 ↗︎ |
|||||||||||||||
|
✅ All Cypress E2E specs passed |
tomi
approved these changes
Nov 7, 2023
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Nov 8, 2023
* master: (24 commits) fix(Crypto Node): Fix issue with value not appearing for Sign action (#7619) feat(NocoDB Node): Add new data apis and workspace support (#7329) fix(Facebook Lead Ads Trigger Node): Fix issue with missing scope for business management (#7616) refactor(core): Stop reporting to Sentry missing-node-on-retry error (no-changelog) (#7648) fix(editor): Fix workflow history prune time limit (getting hours instead of days) (#7644) fix(core): Comply with custom default for workflow saving settings (#7634) feat(core): Initial support for two-way communication over websockets (#7570) ci: Conditionally re-enable coverage for frontend packages (no-changelog) (#7641) ci(core): Load config schema after process.env has been overwritten (no-changelog) (#7550) fix(core): Make password-reset urls valid only for single-use (#7622) fix: Error handling on forgot password page (no-changelog) (#7633) ci: Improve CI performance (no-changelog) (#7637) fix(core): Ensure pruning starts only after migrations have completed (#7626) feat(core): Coordinate workflow activation in multiple main scenario in internal API (#7566) fix(editor): Fix local storage flags defaulting to undefined string (#7603) fix(editor): Reset canvas zoom before workspace reset in node view (#7625) fix(editor): More dark-mode fixes (no-changelog) (#7624) fix(core): Fix accessor error when running partial execution (#7618) fix(editor): Fix issue that frontend breaks with unkown nodes (#7596) fix(core): Ensure `init` before checking leader or follower in multi-main scenario (#7621) ...
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.