fix(editor): More dark-mode fixes (no-changelog) #7624
Merged
+9
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutdmour
previously approved these changes
Nov 6, 2023
netroy
force-pushed
the
dark-mode-fixes
branch
from
ca637fe
to
599bcbe
Compare
mutdmour
approved these changes
Nov 6, 2023
n8n-assistant
bot
added
n8n team
1 flaky test on run #2736 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Resource Mapper > should correctly delete single field |
Output
Screenshots
Video
|
|
Review all test suite changes for PR #7624 ↗︎
|
✅ All Cypress E2E specs passed |
1 similar comment
|
✅ All Cypress E2E specs passed |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7624 +/- ##
==========================================
- Coverage 32.08% 32.02% -0.06%
==========================================
Files 3410 3410
Lines 208706 208706
Branches 22659 22660 +1
==========================================
- Hits 66971 66848 -123
- Misses 140570 140693 +123
Partials 1165 1165
☔ View full report in Codecov by Sentry. |
krynble
pushed a commit
that referenced
this pull request
Nov 7, 2023
This fixes: 1. The `OR` divider background when SSO Login is enabled 2. Scanning of QR code in settings in dark mode
|
Got released with |
MiloradFilipovic
added a commit
that referenced
this pull request
Nov 8, 2023
* master: (24 commits) fix(Crypto Node): Fix issue with value not appearing for Sign action (#7619) feat(NocoDB Node): Add new data apis and workspace support (#7329) fix(Facebook Lead Ads Trigger Node): Fix issue with missing scope for business management (#7616) refactor(core): Stop reporting to Sentry missing-node-on-retry error (no-changelog) (#7648) fix(editor): Fix workflow history prune time limit (getting hours instead of days) (#7644) fix(core): Comply with custom default for workflow saving settings (#7634) feat(core): Initial support for two-way communication over websockets (#7570) ci: Conditionally re-enable coverage for frontend packages (no-changelog) (#7641) ci(core): Load config schema after process.env has been overwritten (no-changelog) (#7550) fix(core): Make password-reset urls valid only for single-use (#7622) fix: Error handling on forgot password page (no-changelog) (#7633) ci: Improve CI performance (no-changelog) (#7637) fix(core): Ensure pruning starts only after migrations have completed (#7626) feat(core): Coordinate workflow activation in multiple main scenario in internal API (#7566) fix(editor): Fix local storage flags defaulting to undefined string (#7603) fix(editor): Reset canvas zoom before workspace reset in node view (#7625) fix(editor): More dark-mode fixes (no-changelog) (#7624) fix(core): Fix accessor error when running partial execution (#7618) fix(editor): Fix issue that frontend breaks with unkown nodes (#7596) fix(core): Ensure `init` before checking leader or follower in multi-main scenario (#7621) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes:
ORdivider background when SSO Login is enabled