Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Error handling on forgot password page (no-changelog) #7633

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

RicardoE105
Copy link
Contributor

@RicardoE105 RicardoE105 commented Nov 6, 2023

@RicardoE105 RicardoE105 changed the title Fix error handling on forgot password page fix: error handling on forgot password page Nov 6, 2023
@RicardoE105 RicardoE105 changed the title fix: error handling on forgot password page fix: error handling on forgot password page (no-changelog) Nov 6, 2023
@RicardoE105 RicardoE105 changed the title fix: error handling on forgot password page (no-changelog) fix: Error handling on forgot password page (no-changelog) Nov 6, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (26361df) 32.08% compared to head (b4033c8) 32.08%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7633      +/-   ##
==========================================
- Coverage   32.08%   32.08%   -0.01%     
==========================================
  Files        3410     3410              
  Lines      208706   208707       +1     
  Branches    22659    22656       -3     
==========================================
- Hits        66971    66970       -1     
- Misses     140570   140572       +2     
  Partials     1165     1165              
Files Coverage Δ
...es/cli/src/controllers/passwordReset.controller.ts 75.00% <ø> (ø)
packages/editor-ui/src/components/SSOLogin.vue 89.83% <100.00%> (ø)
packages/editor-ui/src/views/MfaView.vue 0.00% <ø> (ø)
packages/editor-ui/src/views/NodeView.vue 17.36% <0.00%> (-0.01%) ⬇️
...kages/editor-ui/src/views/ForgotMyPasswordView.vue 0.00% <0.00%> (ø)
...ackages/editor-ui/src/components/MfaSetupModal.vue 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 6, 2023
Copy link
Contributor

github-actions bot commented Nov 7, 2023

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Nov 7, 2023

Passing run #2750 ↗︎

0 271 0 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 RicardoE105 🗃️ e2e/*
Project: n8n Commit: b4033c82df
Status: Passed Duration: 07:05 💡
Started: Nov 7, 2023 12:07 PM Ended: Nov 7, 2023 1:15 PM

Review all test suite changes for PR #7633 ↗︎

Copy link
Contributor

github-actions bot commented Nov 7, 2023

✅ All Cypress E2E specs passed

@RicardoE105 RicardoE105 merged commit b3470fd into master Nov 7, 2023
59 of 62 checks passed
@RicardoE105 RicardoE105 deleted the fix/forgot-password-error-handling branch November 7, 2023 13:46
MiloradFilipovic added a commit that referenced this pull request Nov 8, 2023
* master: (24 commits)
  fix(Crypto Node): Fix issue with value not appearing for Sign action (#7619)
  feat(NocoDB Node): Add new data apis and workspace support (#7329)
  fix(Facebook Lead Ads Trigger Node): Fix issue with missing scope for business management  (#7616)
  refactor(core): Stop reporting to Sentry missing-node-on-retry error (no-changelog) (#7648)
  fix(editor): Fix workflow history prune time limit (getting hours instead of days) (#7644)
  fix(core): Comply with custom default for workflow saving settings (#7634)
  feat(core): Initial support for two-way communication over websockets (#7570)
  ci: Conditionally re-enable coverage for frontend packages (no-changelog) (#7641)
  ci(core): Load config schema after process.env has been overwritten (no-changelog) (#7550)
  fix(core): Make password-reset urls valid only for single-use (#7622)
  fix: Error handling on forgot password page (no-changelog) (#7633)
  ci: Improve CI performance (no-changelog) (#7637)
  fix(core): Ensure pruning starts only after migrations have completed (#7626)
  feat(core): Coordinate workflow activation in multiple main scenario in internal API (#7566)
  fix(editor): Fix local storage flags defaulting to undefined string (#7603)
  fix(editor): Reset canvas zoom before workspace reset in node view (#7625)
  fix(editor): More dark-mode fixes (no-changelog) (#7624)
  fix(core): Fix accessor error when running partial execution (#7618)
  fix(editor): Fix issue that frontend breaks with unkown nodes (#7596)
  fix(core): Ensure `init` before checking leader or follower in multi-main scenario (#7621)
  ...
@janober
Copy link
Member

janober commented Nov 8, 2023

Got released with n8n@1.16.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants