-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Error handling on forgot password page (no-changelog) #7633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RicardoE105
changed the title
Fix error handling on forgot password page
fix: error handling on forgot password page
Nov 6, 2023
RicardoE105
changed the title
fix: error handling on forgot password page
fix: error handling on forgot password page (no-changelog)
Nov 6, 2023
RicardoE105
changed the title
fix: error handling on forgot password page (no-changelog)
fix: Error handling on forgot password page (no-changelog)
Nov 6, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7633 +/- ##
==========================================
- Coverage 32.08% 32.08% -0.01%
==========================================
Files 3410 3410
Lines 208706 208707 +1
Branches 22659 22656 -3
==========================================
- Hits 66971 66970 -1
- Misses 140570 140572 +2
Partials 1165 1165
☔ View full report in Codecov by Sentry. |
n8n-assistant
bot
added
core
Enhancement outside /nodes-base and /editor-ui
n8n team
Authored by the n8n team
ui
Enhancement in /editor-ui or /design-system
labels
Nov 6, 2023
mutdmour
approved these changes
Nov 7, 2023
|
Passing run #2750 ↗︎
Details:
Review all test suite changes for PR #7633 ↗︎ |
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Nov 8, 2023
* master: (24 commits) fix(Crypto Node): Fix issue with value not appearing for Sign action (#7619) feat(NocoDB Node): Add new data apis and workspace support (#7329) fix(Facebook Lead Ads Trigger Node): Fix issue with missing scope for business management (#7616) refactor(core): Stop reporting to Sentry missing-node-on-retry error (no-changelog) (#7648) fix(editor): Fix workflow history prune time limit (getting hours instead of days) (#7644) fix(core): Comply with custom default for workflow saving settings (#7634) feat(core): Initial support for two-way communication over websockets (#7570) ci: Conditionally re-enable coverage for frontend packages (no-changelog) (#7641) ci(core): Load config schema after process.env has been overwritten (no-changelog) (#7550) fix(core): Make password-reset urls valid only for single-use (#7622) fix: Error handling on forgot password page (no-changelog) (#7633) ci: Improve CI performance (no-changelog) (#7637) fix(core): Ensure pruning starts only after migrations have completed (#7626) feat(core): Coordinate workflow activation in multiple main scenario in internal API (#7566) fix(editor): Fix local storage flags defaulting to undefined string (#7603) fix(editor): Reset canvas zoom before workspace reset in node view (#7625) fix(editor): More dark-mode fixes (no-changelog) (#7624) fix(core): Fix accessor error when running partial execution (#7618) fix(editor): Fix issue that frontend breaks with unkown nodes (#7596) fix(core): Ensure `init` before checking leader or follower in multi-main scenario (#7621) ...
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: https://linear.app/n8n/issue/ADO-1339/fix-error-handling-on-forgot-password-page