Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Make sure auto loading and auto scrolling works in executions tab #9505

Merged

Conversation

cstuncsik
Copy link
Contributor

@cstuncsik cstuncsik commented May 24, 2024

Summary

Auto loading more items and auto scrolling on the execution tab wasn't working on very tall screen size

Related tickets and issues

PAY-1584

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Tests included.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels May 24, 2024
@MiloradFilipovic MiloradFilipovic self-requested a review May 27, 2024 09:15
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 🙌 Works as expected. I left a couple of minor comments but otherwise good to go!

autoScrollDeps: {
activeExecutionSet: false,
cardsMounted: false,
scroll: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I find this name to be a bit unclear. Can we elaborate a bit more what this flag is doing (better name, or just a comment)?

@@ -117,6 +119,12 @@ export default defineComponent({
data() {
return {
filter: {} as ExecutionFilterType,
mountedItems: [] as string[],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we only care about number of mounted cards here, so can we just track that instead of keeping the list of ids (I guess it will be a bit more performant for longer lists)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it could be just a counter but I need to get a workflow card ref by its ID and since it is used in other places (it is needed for the auto scroll) I didn't want to change the ref so it seemed better to collect the IDs
CleanShot 2024-05-27 at 12 19 57

I don't think it will cause a performance issue, you would have to have like 100K (or a million) of IDs stored in the array, I don't think we will ever have that

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented May 27, 2024

1 failed test on run #5133 ↗︎

1 348 0 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
Project: n8n Commit: 64ad87a707
Status: Failed Duration: 04:30 💡
Started: May 27, 2024 9:58 AM Ended: May 27, 2024 10:03 AM
Failed  39-projects.cy.ts • 1 failed test

View Output Video

Test Artifacts
Projects > should handle workflows and credentials and menu items Test Replay Screenshots Video
Failed  35-admin-user-smoke-test.cy.ts • 0 failed tests

View Output

Test Artifacts

Review all test suite changes for PR #9505 ↗︎

@cstuncsik cstuncsik merged commit 3a2e545 into master May 27, 2024
27 of 30 checks passed
@cstuncsik cstuncsik deleted the pay-1584-executions-view-on-single-workflow-limited-to-10 branch May 27, 2024 10:44
MiloradFilipovic added a commit that referenced this pull request May 30, 2024
* master:
  ci: Upgrade storybook to address CVE-2024-36361 (no-changelog) (#9541)
  fix(editor): Improve contrast for `--color-danger` in dark mode (no-changelog) (#9537)
  fix(editor): Prevent updating node parameter value if it hasn't changed (#9535)
  fix(editor): Show execution error toast also if there is no error stack just message (#9526)
  fix(editor): Prevent expression editor focus being lost when user is selecting (#9525)
  fix(editor): Update webhook paths when duplicating workflow (#9516)
  refactor(core): Increase minimum supported Node.js version to 18.17 (#9533)
  fix(core): Set source control repository to track remote if ready (#9532)
  feat(editor): Show expression infobox on hover and cursor position (#9507)
  fix(core): Block Public API related REST calls when Public API is not enabled (#9521)
  test(core): Align test names with route names (no-changelog) (#9518)
  refactor(core): Prevent reporting to Sentry IMAP server error (no-changelog) (#9515)
  fix(editor): Executions view popup in dark mode (#9517)
  refactor: Delete dead crash recovery code (no-changelog) (#9512)
  fix(editor): Send only execution id in postMessage when previewing an execution (#9514)
  fix(editor): Make sure auto loading and auto scrolling works in executions tab (#9505)
  fix(core): Fix worker encryption key warning docs link (no-changelog) (#9513)
  build: Bump license-sdk to v2.12.0 (no-changelog) (#9510)
  Revert "build: Bump license-sdk to v2.11.1 (no-changelog)"
  build: Bump license-sdk to v2.11.1 (no-changelog)

# Conflicts:
#	pnpm-lock.yaml
@github-actions github-actions bot mentioned this pull request May 30, 2024
@janober
Copy link
Member

janober commented May 30, 2024

Got released with n8n@1.44.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants