Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(core): Align test names with route names (no-changelog) #9518

Merged
merged 1 commit into from
May 27, 2024

Conversation

despairblue
Copy link
Contributor

Summary

I keep having issues finding the share tests, because I mostly fold everything in the test file and look for the route I'm interested in. The test name for the sharing was not matching with the route name, also each test was repeating the name of the outer describe block.

I fixed this and some smaller inconsistencies.

Related tickets and issues

none

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)

@despairblue despairblue marked this pull request as ready for review May 27, 2024 14:17
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels May 27, 2024
Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented May 27, 2024

2 failed and 2 flaky tests on run #5140 ↗︎

2 223 0 0 Flakiness 2

Details:

🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Project: n8n Commit: e07de837b9
Status: Failed Duration: 05:21 💡
Started: May 28, 2024 3:10 AM Ended: May 28, 2024 3:16 AM
Failed  27-cloud.cy.ts • 2 failed tests

View Output Video

Test Artifacts
Cloud > Admin Home > Should show admin button Test Replay Screenshots Video
Cloud > Public API > Should show upgrade CTA for Public API if user is trialing Test Replay Screenshots Video
Failed  11-inline-expression-editor.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  9-expression-editor-modal.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  14-mapping.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  25-stickies.cy.ts • 0 failed tests

View Output

Test Artifacts

The first 5 failed specs are shown, see all 35 specs in Cypress Cloud.

Flakiness  cypress/e2e/5-ndv.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
NDV > Stop listening for trigger event from NDV Screenshots Video

Review all test suite changes for PR #9518 ↗︎

@despairblue despairblue merged commit e07de83 into master May 27, 2024
28 checks passed
@despairblue despairblue deleted the clean-up-test-names branch May 27, 2024 18:41
MiloradFilipovic added a commit that referenced this pull request May 29, 2024
* master:
  feat(editor): Show expression infobox on hover and cursor position (#9507)
  fix(core): Block Public API related REST calls when Public API is not enabled (#9521)
  test(core): Align test names with route names (no-changelog) (#9518)
  refactor(core): Prevent reporting to Sentry IMAP server error (no-changelog) (#9515)
  fix(editor): Executions view popup in dark mode (#9517)
  refactor: Delete dead crash recovery code (no-changelog) (#9512)
MiloradFilipovic added a commit that referenced this pull request May 30, 2024
* master:
  ci: Upgrade storybook to address CVE-2024-36361 (no-changelog) (#9541)
  fix(editor): Improve contrast for `--color-danger` in dark mode (no-changelog) (#9537)
  fix(editor): Prevent updating node parameter value if it hasn't changed (#9535)
  fix(editor): Show execution error toast also if there is no error stack just message (#9526)
  fix(editor): Prevent expression editor focus being lost when user is selecting (#9525)
  fix(editor): Update webhook paths when duplicating workflow (#9516)
  refactor(core): Increase minimum supported Node.js version to 18.17 (#9533)
  fix(core): Set source control repository to track remote if ready (#9532)
  feat(editor): Show expression infobox on hover and cursor position (#9507)
  fix(core): Block Public API related REST calls when Public API is not enabled (#9521)
  test(core): Align test names with route names (no-changelog) (#9518)
  refactor(core): Prevent reporting to Sentry IMAP server error (no-changelog) (#9515)
  fix(editor): Executions view popup in dark mode (#9517)
  refactor: Delete dead crash recovery code (no-changelog) (#9512)
  fix(editor): Send only execution id in postMessage when previewing an execution (#9514)
  fix(editor): Make sure auto loading and auto scrolling works in executions tab (#9505)
  fix(core): Fix worker encryption key warning docs link (no-changelog) (#9513)
  build: Bump license-sdk to v2.12.0 (no-changelog) (#9510)
  Revert "build: Bump license-sdk to v2.11.1 (no-changelog)"
  build: Bump license-sdk to v2.11.1 (no-changelog)

# Conflicts:
#	pnpm-lock.yaml
@janober
Copy link
Member

janober commented May 30, 2024

Got released with n8n@1.44.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants