fix(editor): Update webhook paths when duplicating workflow #9516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiloradFilipovic
changed the title
n8n-assistant
bot
added
n8n team
netroy
requested changes
May 27, 2024
OlegIvaniv
force-pushed
the
ADO-2149-update-webhook-path-when-duplicating
branch
from
9a2791a
to
a6dae64
Compare
OlegIvaniv
reviewed
May 28, 2024
* master: feat(editor): Show expression infobox on hover and cursor position (#9507) fix(core): Block Public API related REST calls when Public API is not enabled (#9521) test(core): Align test names with route names (no-changelog) (#9518) refactor(core): Prevent reporting to Sentry IMAP server error (no-changelog) (#9515) fix(editor): Executions view popup in dark mode (#9517) refactor: Delete dead crash recovery code (no-changelog) (#9512)
OlegIvaniv
previously approved these changes
May 29, 2024
2 flaky tests on run #5164 ↗︎
Details:
|
||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
Review all test suite changes for PR #9516 ↗︎
|
✅ All Cypress E2E specs passed |
OlegIvaniv
approved these changes
May 29, 2024
|
✅ All Cypress E2E specs passed |
netroy
approved these changes
May 29, 2024
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
deleted the
ADO-2149-update-webhook-path-when-duplicating
branch
MiloradFilipovic
added a commit
that referenced
this pull request
May 30, 2024
* master: ci: Upgrade storybook to address CVE-2024-36361 (no-changelog) (#9541) fix(editor): Improve contrast for `--color-danger` in dark mode (no-changelog) (#9537) fix(editor): Prevent updating node parameter value if it hasn't changed (#9535) fix(editor): Show execution error toast also if there is no error stack just message (#9526) fix(editor): Prevent expression editor focus being lost when user is selecting (#9525) fix(editor): Update webhook paths when duplicating workflow (#9516) refactor(core): Increase minimum supported Node.js version to 18.17 (#9533) fix(core): Set source control repository to track remote if ready (#9532) feat(editor): Show expression infobox on hover and cursor position (#9507) fix(core): Block Public API related REST calls when Public API is not enabled (#9521) test(core): Align test names with route names (no-changelog) (#9518) refactor(core): Prevent reporting to Sentry IMAP server error (no-changelog) (#9515) fix(editor): Executions view popup in dark mode (#9517) refactor: Delete dead crash recovery code (no-changelog) (#9512) fix(editor): Send only execution id in postMessage when previewing an execution (#9514) fix(editor): Make sure auto loading and auto scrolling works in executions tab (#9505) fix(core): Fix worker encryption key warning docs link (no-changelog) (#9513) build: Bump license-sdk to v2.12.0 (no-changelog) (#9510) Revert "build: Bump license-sdk to v2.11.1 (no-changelog)" build: Bump license-sdk to v2.11.1 (no-changelog) # Conflicts: # pnpm-lock.yaml
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When duplicating workflows, we are updating webhook ids but not the paths, this PR fixes that.
Also fixing Vue options order in duplicate dialog, so
eslintis not complaining anymore:Related tickets and issues
ADO-2149
Review / Merge checklist
(no-changelog)otherwise. (conventions)