chore: Remove examples/shim #2484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amychisholm03
changed the title
bizob2828
requested changes
Aug 19, 2024
There was a problem hiding this comment.
You need to add a jsdoc.json so we can have a page in https://newrelic.github.io/node-newrelic/ that will publish this markdown.
If you run npm run public-docs this now fails because it's expecting examples/shim. you can just update the public-docs script to include documentation/examples.md
bizob2828
reviewed
Aug 19, 2024
jsumners-nr
previously approved these changes
Aug 19, 2024
bizob2828
reviewed
Aug 19, 2024
bizob2828
reviewed
Aug 19, 2024
examples/instrumentation.md
Outdated
| @@ -0,0 +1,14 @@ | |||
| # node-newrelic examples | |||
There was a problem hiding this comment.
not sure you need this. because when it renders in a tutorial it has a title
bizob2828
requested changes
Aug 19, 2024
Co-authored-by: Bob Evans <robert.evans25@gmail.com>
bizob2828
approved these changes
Aug 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the examples/shim folder, added instrumentation.md to redirect users, and updated jsdoc