Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title bar uses wrong "dark" theme even in light mode #6386

Closed
arnowelzel opened this issue Sep 15, 2024 · 7 comments
Closed

Title bar uses wrong "dark" theme even in light mode #6386

arnowelzel opened this issue Sep 15, 2024 · 7 comments
Assignees
Labels
1. to develop bug Something isn't working

Comments

@arnowelzel
Copy link

Describe the bug
When Nextcloud is using a "light" theme, the text editor uses a "dark" theme title bar which makes the elements very hard to see due to the light grey color.

In the HTML source you can also see the wrong theme data-theme-dark used:

<div data-v-1d602fb0="" data-theme-dark="" class="modal-header">

This would be the correct code:

<div data-v-1d602fb0="" data-theme-light="" class="modal-header">

To Reproduce
Steps to reproduce the behavior:

  1. Make sure Nextcloud is using a "light" theme.
  2. Open or create a text document.
  3. See the title bar in light grey color instead of the expected dark color.

Expected behavior
The title bar uses the correct theme.

Screenshots

image

Server details:

  • Nextcloud version: 30.0.0
  • PHP Version: 8.3
  • Database: MariaDB 10.6

Client details:

  • OS: Windows 11
  • Browser: Vivaldi, Chrome, Firefox
  • Browser version: latest versions as of 2024-09-15
  • Device: Desktop
@arnowelzel arnowelzel added the bug Something isn't working label Sep 15, 2024
@Rahul-2006
Copy link

Hi @arnowelzel
If the theme is only the concern , i can adjust it and it can help me in growing my open source journey

@arnowelzel
Copy link
Author

Hi @arnowelzel If the theme is only the concern , i can adjust it and it can help me in growing my open source journey

Yes, only the attribute for the theme should match the current Nextcloud theme. Thanks for your help!

@Rahul-2006
Copy link

So can i get it assigned ?

@arnowelzel
Copy link
Author

I am not a team member of Nextcloud, so I can not assign you. Maybe they can help. However you can always start working on that anyway and provide a pull request with your changes.

mejo- added a commit that referenced this issue Sep 15, 2024
Fixes: #6386

Signed-off-by: Jonas <jonas@freesources.org>
@Rahul-2006
Copy link

Ok I will start working on this then...

@mejo-
Copy link
Member

mejo- commented Sep 15, 2024

@Rahul-2006, before you start working on this, we already have a fix ready sorry. It was a rather complex fix in other components: nextcloud-libraries/nextcloud-vue#6083 and nextcloud/viewer#2528

Thanks still for your interest in contributing. Feel free to pick another issue that you want to work on 😊

@Rahul-2006
Copy link

Ok!!
Thank you

@mejo- mejo- self-assigned this Sep 16, 2024
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Sep 16, 2024
@mejo- mejo- moved this from 🧭 Planning evaluation (don't pick) to 🏗️ In progress in 📝 Office team Sep 16, 2024
@mejo- mejo- removed the good first issue Good for newcomers label Sep 16, 2024
mejo- added a commit to nextcloud/viewer that referenced this issue Sep 17, 2024
Required to fix regression with Text in Viewer in Nextcloud 30, where we
still want a white viewer header.

Also fixes the header color for PDFs with light theme.

Fixes: nextcloud/text#6386

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit to nextcloud/viewer that referenced this issue Sep 17, 2024
Required to fix regression with Text in Viewer in Nextcloud 30, where we
still want a white viewer header.

Also fixes the header color for PDFs with light theme.

Fixes: nextcloud/text#6386

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit to nextcloud/viewer that referenced this issue Sep 17, 2024
Required to fix regression with Text in Viewer in Nextcloud 30, where we
still want a white viewer header.

Also fixes the header color for PDFs with light theme.

Fixes: nextcloud/text#6386

Signed-off-by: Jonas <jonas@freesources.org>
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 📝 Office team Sep 17, 2024
backportbot bot pushed a commit to nextcloud/viewer that referenced this issue Sep 17, 2024
Required to fix regression with Text in Viewer in Nextcloud 30, where we

still want a white viewer header.

Also fixes the header color for PDFs with light theme.

Fixes: nextcloud/text#6386

Co-authored-by: Jonas <jonas@freesources.org>

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

[skip ci]
mejo- added a commit to nextcloud/viewer that referenced this issue Sep 17, 2024
Required to fix regression with Text in Viewer in Nextcloud 30, where we
still want a white viewer header.

Also fixes the header color for PDFs with light theme.
Fixes: nextcloud/text#6386

Co-authored-by: Jonas <jonas@freesources.org>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

4 participants