-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Title bar uses wrong "dark" theme even in light mode #6386
Comments
Hi @arnowelzel |
Yes, only the attribute for the theme should match the current Nextcloud theme. Thanks for your help! |
So can i get it assigned ? |
I am not a team member of Nextcloud, so I can not assign you. Maybe they can help. However you can always start working on that anyway and provide a pull request with your changes. |
Fixes: #6386 Signed-off-by: Jonas <jonas@freesources.org>
Ok I will start working on this then... |
@Rahul-2006, before you start working on this, we already have a fix ready sorry. It was a rather complex fix in other components: nextcloud-libraries/nextcloud-vue#6083 and nextcloud/viewer#2528 Thanks still for your interest in contributing. Feel free to pick another issue that you want to work on 😊 |
Ok!! |
Required to fix regression with Text in Viewer in Nextcloud 30, where we still want a white viewer header. Also fixes the header color for PDFs with light theme. Fixes: nextcloud/text#6386 Signed-off-by: Jonas <jonas@freesources.org>
Required to fix regression with Text in Viewer in Nextcloud 30, where we still want a white viewer header. Also fixes the header color for PDFs with light theme. Fixes: nextcloud/text#6386 Signed-off-by: Jonas <jonas@freesources.org>
Required to fix regression with Text in Viewer in Nextcloud 30, where we still want a white viewer header. Also fixes the header color for PDFs with light theme. Fixes: nextcloud/text#6386 Signed-off-by: Jonas <jonas@freesources.org>
Required to fix regression with Text in Viewer in Nextcloud 30, where we still want a white viewer header. Also fixes the header color for PDFs with light theme. Fixes: nextcloud/text#6386 Co-authored-by: Jonas <jonas@freesources.org> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de> [skip ci]
Required to fix regression with Text in Viewer in Nextcloud 30, where we still want a white viewer header. Also fixes the header color for PDFs with light theme. Fixes: nextcloud/text#6386 Co-authored-by: Jonas <jonas@freesources.org> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Describe the bug
When Nextcloud is using a "light" theme, the text editor uses a "dark" theme title bar which makes the elements very hard to see due to the light grey color.
In the HTML source you can also see the wrong theme
data-theme-dark
used:This would be the correct code:
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The title bar uses the correct theme.
Screenshots
Server details:
Client details:
The text was updated successfully, but these errors were encountered: