Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NcModal): make dark header configurable #6083

Merged
merged 1 commit into from
Sep 16, 2024
Merged

feat(NcModal): make dark header configurable #6083

merged 1 commit into from
Sep 16, 2024

Conversation

mejo-
Copy link
Contributor

@mejo- mejo- commented Sep 15, 2024 •
edited
Loading

Required to fix regression with Text in Viewer in Nextcloud 30, where we still want a white viewer header.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@mejo- mejo- added bug Something isn't working 3. to review Waiting for reviews regression Regression of a previous working feature feature: modal Related to the modal component labels Sep 15, 2024
@mejo- mejo- self-assigned this Sep 15, 2024
@mejo-
Copy link
Contributor Author

mejo- commented Sep 15, 2024

/backport to next

@mejo- mejo- force-pushed the fix/modal_configurable_header_dark branch from 96f58f3 to 94baa37 Compare September 15, 2024 12:16
@mejo- mejo- mentioned this pull request Sep 15, 2024
Merged
@mejo-
Copy link
Contributor Author

mejo- commented Sep 15, 2024

nextcloud/text#6404 contains screenshots of the regression this fixes.

@susnux susnux requested a review from ShGKme September 15, 2024 13:18
@skjnldsv
Copy link
Contributor

Not sure this is the right approach though.
Wouldn't it be easier to have a dark/light Viewer entirely? Focusing on th eheader only seems like a confusing solution 🤔

@mejo-
Copy link
Contributor Author

mejo- commented Sep 15, 2024

Wouldn't it be easier to have a dark/light Viewer entirely? Focusing on th eheader only seems like a confusing solution 🤔

I get your point. But we have the situation that in light mode we want dark header per default but light headers when opening Text files 🙃

@mejo-
fix(NcModal): make dark header configurable
c35fefd 
Required to fix regression with Text in Viewer in Nextcloud 30, where we
still want a white viewer header.

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- requested a review from susnux September 15, 2024 15:12
@mejo- mejo- force-pushed the fix/modal_configurable_header_dark branch from 94baa37 to c35fefd Compare September 15, 2024 15:43
@mejo- mejo- mentioned this pull request Sep 15, 2024
Closed
susnux
susnux approved these changes Sep 15, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skjnldsv it does allow to have a light backdrop, no only the header.
We tested this with text and pdf viewer which will correctly adapt based on the color scheme.

But also the image viewer stays always dark as expected:)

@mejo- mejo- merged commit bbec1da into master Sep 16, 2024
19 checks passed
@mejo- mejo- deleted the fix/modal_configurable_header_dark branch September 16, 2024 09:14
@backportbot backportbot bot mentioned this pull request Sep 16, 2024
Merged
@mejo- mejo- mentioned this pull request Sep 16, 2024
Merged
@susnux susnux changed the title fix(NcModal): make dark header configurable feat(NcModal): make dark header configurable Sep 16, 2024
@susnux susnux added enhancement New feature or request and removed bug Something isn't working regression Regression of a previous working feature labels Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@susnux susnux susnux approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@mejo- mejo-

Labels
3. to review Waiting for reviews enhancement New feature or request feature: modal Related to the modal component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mejo- @skjnldsv @susnux